@@ -82,6 +82,7 @@ module Geokit @@logger=Logger.new(STDOUT) @@logger.level=Logger::INFO @@domain = nil + @@lang = nil def self.__define_accessors class_variables.each do |v| @@ -130,8 +131,8 @@ module Geokit # Main method which calls the do_reverse_geocode template method which subclasses # are responsible for implementing. Returns a populated GeoLoc or an # empty one with a failed success code. - def self.reverse_geocode(latlng) - res = do_reverse_geocode(latlng) + def self.reverse_geocode(latlng, options = {}) + res = do_reverse_geocode(latlng, options) return res.success? ? res : GeoLoc.new end @@ -146,7 +147,7 @@ module Geokit # Not all geocoders can do reverse geocoding. So, unless the subclass explicitly overrides this method, # a call to reverse_geocode will return an empty GeoLoc. If you happen to be using MultiGeocoder, # this will cause it to failover to the next geocoder, which will hopefully be one which supports reverse geocoding. - def self.do_reverse_geocode(latlng) + def self.do_reverse_geocode(latlng, options = {}) return GeoLoc.new end @@ -392,9 +393,19 @@ module Geokit private # Template method which does the reverse-geocode lookup. - def self.do_reverse_geocode(latlng) + # + # ==== OPTIONS + # * :lang - This option makes the Google Geocoder return localized results. + # Just give a country code and hope Google supports it ;-) + # Defaults to 'en'. + # + # ==== EXAMPLE + # # Get German locality names + # Geokit::Geocoders::GoogleGeocoder.reverse_geocode('51.0, 9.0', :lang => :de) + def self.do_reverse_geocode(latlng, options = {}) latlng=LatLng.normalize(latlng) - res = self.call_geocoder_service("http://maps.google.com/maps/geo?ll=#{Geokit::Inflector::url_escape(latlng.ll)}&output=xml&key=#{Geokit::Geocoders::google}&oe=utf-8") + lang = options[:lang] || Geokit::Geocoders::lang || 'en' + res = self.call_geocoder_service("http://maps.google.com/maps/geo?ll=#{Geokit::Inflector::url_escape(latlng.ll)}&output=xml&key=#{Geokit::Geocoders::google}&oe=utf-8&hl=#{lang.to_s.downcase}") # res = Net::HTTP.get_response(URI.parse("http://maps.google.com/maps/geo?ll=#{Geokit::Inflector::url_escape(address_str)}&output=xml&key=#{Geokit::Geocoders::google}&oe=utf-8")) return GeoLoc.new unless (res.is_a?(Net::HTTPSuccess) || res.is_a?(Net::HTTPOK)) xml = res.body @@ -667,11 +678,11 @@ module Geokit # This method will call one or more geocoders in the order specified in the # configuration until one of the geocoders work, only this time it's going # to try to reverse geocode a geographical point. - def self.do_reverse_geocode(latlng) + def self.do_reverse_geocode(latlng, options = {}) Geokit::Geocoders::provider_order.each do |provider| begin klass = Geokit::Geocoders.const_get "#{Geokit::Inflector::camelize(provider.to_s)}Geocoder" - res = klass.send :reverse_geocode, latlng + res = klass.send :reverse_geocode, latlng, options return res if res.success? rescue logger.error("Something has gone very wrong during reverse geocoding, OR you have configured an invalid class name in Geokit::Geocoders::provider_order. LatLng: #{latlng}. Provider: #{provider}") lib/geokit/geocoders.rb @@ -167,7 +167,7 @@ class GoogleGeocoderTest < BaseGeocoderTest #:nodoc: all madrid.lat, madrid.lng = "40.4167413", "-3.7032498" response = MockSuccess.new response.expects(:body).returns(GOOGLE_REVERSE_MADRID) - url = "http://maps.google.com/maps/geo?ll=#{Geokit::Inflector::url_escape(madrid.ll)}&output=xml&key=#{Geokit::Geocoders::google}&oe=utf-8" + url = "http://maps.google.com/maps/geo?ll=#{Geokit::Inflector::url_escape(madrid.ll)}&output=xml&key=#{Geokit::Geocoders::google}&oe=utf-8&hl=en" Geokit::Geocoders::GoogleGeocoder.expects(:call_geocoder_service).with(url). returns(response) res=Geokit::Geocoders::GoogleGeocoder.do_reverse_geocode(madrid.ll) test/test_google_geocoder.rb @@ -33,7 +33,7 @@ class GoogleReverseGeocoderTest < BaseGeocoderTest #:nodoc: all @latlng = "51.4578329,7.0166848" - url = "http://maps.google.com/maps/geo?ll=#{Geokit::Inflector.url_escape(@latlng)}&output=xml&key=Google&oe=utf-8" + url = "http://maps.google.com/maps/geo?ll=#{Geokit::Inflector.url_escape(@latlng)}&output=xml&key=Google&oe=utf-8&hl=en" Geokit::Geocoders::GoogleGeocoder.expects(:call_geocoder_service).with(url).returns(response) res=Geokit::Geocoders::GoogleGeocoder.reverse_geocode(@latlng) assert_equal "Nordrhein-Westfalen", res.state test/test_google_reverse_geocoder.rb b67a04600aad96e1c21965de2619105d012f6dd4 Torsten Schönebaum torsten.schoenebaum@planquadrat-software.de http://github.com/tosch/geokit-gem/commit/9a7232d7d56059558107129ab3bcf51bcb67d45b 9a7232d7d56059558107129ab3bcf51bcb67d45b 2009-09-29T09:06:22-07:00 2009-09-29T09:06:22-07:00 enable localized responses when reverse geocoding with the Google geocoder c246529738fe1f91af8a8ab02a66bed2741feb0b Torsten Schönebaum torsten.schoenebaum@planquadrat-software.de