feature #2271 Deprecate support for mbstring.func_overload != 0 (fabpot)

This PR was merged into the 1.x branch. Discussion ---------- Deprecate support for mbstring.func_overload != 0 see https://wiki.php.net/rfc/deprecations_php_7_2 Commits ------- 6668d47 deprecated support for mbstring.func_overload != 0
twigphp · Nov 23, 2016 · 717365d · 717365d
2 parents 2436915 + 6668d47
commit 717365d
Show file tree

Hide file tree

Showing 6 changed files with 14 additions and 8 deletions.
diff --git a/CHANGELOG b/CHANGELOG
@@ -1,6 +1,6 @@
-* 1.28.3 (2016-XX-XX)
+* 1.29.0 (2016-XX-XX)
 
- * n/a
+ * deprecated support for mbstring.func_overload != 0
 
 * 1.28.2 (2016-11-23)
 

diff --git a/composer.json b/composer.json
@@ -40,7 +40,7 @@
     },
     "extra": {
         "branch-alias": {
-            "dev-master": "1.28-dev"
+            "dev-master": "1.29-dev"
         }
     }
 }
diff --git a/ext/twig/php_twig.h b/ext/twig/php_twig.h
@@ -15,7 +15,7 @@
 #ifndef PHP_TWIG_H
 #define PHP_TWIG_H
 
-#define PHP_TWIG_VERSION "1.28.3-DEV"
+#define PHP_TWIG_VERSION "1.29.0-DEV"
 
 #include "php.h"
 

diff --git a/lib/Twig/Compiler.php b/lib/Twig/Compiler.php
@@ -216,6 +216,8 @@ public function addDebugInfo(Twig_NodeInterface $node)
             // mb_substr_count() replaces substr_count()
             // but they have different signatures!
             if (((int) ini_get('mbstring.func_overload')) & 2) {
+                @trigger_error('Support for having "mbstring.func_overload" different from 0 is deprecated version 1.29 and will be removed in 2.0.', E_USER_DEPRECATED);
+
                 // this is much slower than the "right" version
                 $this->sourceLine += mb_substr_count(mb_substr($this->source, $this->sourceOffset), "\n");
             } else {

diff --git a/lib/Twig/Environment.php b/lib/Twig/Environment.php
@@ -16,11 +16,11 @@
  */
 class Twig_Environment
 {
-    const VERSION = '1.28.3';
-    const VERSION_ID = 12803;
+    const VERSION = '1.29.0-DEV';
+    const VERSION_ID = 12900;
     const MAJOR_VERSION = 1;
-    const MINOR_VERSION = 28;
-    const RELEASE_VERSION = 3;
+    const MINOR_VERSION = 20;
+    const RELEASE_VERSION = 0;
     const EXTRA_VERSION = 'DEV';
 
     protected $charset;

diff --git a/lib/Twig/Lexer.php b/lib/Twig/Lexer.php
@@ -85,6 +85,10 @@ public function tokenize($code, $name = null)
             $source = $code;
         }
 
+        if (((int) ini_get('mbstring.func_overload')) & 2) {
+            @trigger_error('Support for having "mbstring.func_overload" different from 0 is deprecated version 1.29 and will be removed in 2.0.', E_USER_DEPRECATED);
+        }
+
         if (function_exists('mb_internal_encoding') && ((int) ini_get('mbstring.func_overload')) & 2) {
             $mbEncoding = mb_internal_encoding();
             mb_internal_encoding('ASCII');