test/fixtures/hatom_without_author.html @@ -54,7 +54,13 @@ class HEntry < Microformat def add_in_parent_hcard @properties << 'author' - @author = self.class.find_in_parent_hcard + @author = in_parent_hcard + end + + # Per spec: if the entry author is missing find the nearest in + # parent <address> element(s) with class name author + def in_parent_hcard + @in_parent_hcard ||= self.class.find_in_parent_hcard end class << self @@ -64,11 +70,10 @@ class HEntry < Microformat hentry end - # Per spec: if the entry author is missing find the nearest in - # parent <address> element(s) with class name author def find_in_parent_hcard - @in_parent_hcard ||= prepare_value(HCard.find( - :text => (@doc/"//.hentry/../address.vcard").to_s)) + author = HCard.find(:text => (@doc/"//.hentry/..//address.vcard").to_s) + raise InvalidMicroformat if @options[:strict] && author.empty? + prepare_value(author) end end end lib/mofo/hentry.rb @@ -20,6 +20,13 @@ context "A parsed hEntry object" do :base => 'http://journal.redflavor.com') with_parent.author.should.be.an.instance_of HCard with_parent.author.fn.should.equal "Eivind Uggedal" + with_parent.author.url.should.equal "http://redflavor.com" + end + + specify "should be invalid without any author in strict mode" do + proc { HEntry.find(:first => fixture(:hatom_without_author), + :base => 'http://bogus.redflavor.com', + :strict => true) }.should.raise InvalidMicroformat end specify "should have content" do test/hatom_test.rb c25faa0e5f7fa7dbf5cc93fde9c20ec888ab0fb5 Eivind Uggedal eu@redflavor.com http://github.com/uggedal/mofo/commit/70d22bd059e417b30b2f85e8575077febdee9dd5 70d22bd059e417b30b2f85e8575077febdee9dd5 2008-01-27T05:30:50-08:00 2008-01-27T05:27:33-08:00 hentry invalid without author. in_parent_hcard object instance instead of class instance. address node need not be child of parent but can be descendant. 82530f6054dd4a9216e94f639eb27ee763418578 Eivind Uggedal eu@redflavor.com