@@ -1,5 +1,11 @@ Revision history for WWW-Facebook-API +0.4.10 Sat Dec 1 17:30:58 PST 2007 + Fixed bug where session_key parameter value wasn't being used when + passed to a call (thanks Louise-Philippe) + Perl-tidied and critiqued + Added stub documentation for base and new methods + 0.4.9 Sun Nov 25 11:39:47 PST 2007 Fixed some documentation errors Updated documentation to match current documentation on Facebook site Changes @@ -21,5 +21,6 @@ #Avoid bin directory, for now \bbin/ -# Avoid Subversion files +# Avoid Subversion and git files \.svn +\.git MANIFEST.SKIP @@ -2,7 +2,7 @@ NAME WWW::Facebook::API - Facebook API implementation VERSION - This document describes WWW::Facebook::API version 0.4.9 + This document describes WWW::Facebook::API version 0.4.10 SYNOPSIS use WWW::Facebook::API; @@ -466,7 +466,7 @@ ATTRIBUTE METHODS "confess" when an error is returned from the REST server. ua The LWP::UserAgent agent used to communicate with the REST server. - The agent_alias is initially set to "Perl-WWW-Facebook-API/0.4.9". + The agent_alias is initially set to "Perl-WWW-Facebook-API/0.4.10". PUBLIC METHODS call( $method, %args ) @@ -663,10 +663,18 @@ DIAGNOSTICS report. "<_format_and_check_params must be called in list context!"> - You're using a privat method call and you're not calling it in list + You're using a private method call and you're not calling it in list context. It returns a list of items, all of which should be interesting to you. + "Cannot open %s" + Cannot open the configuration file. Make sure the filename is + correct and that the program has the appropriate permissions. + + "Cannot close %s" + Cannot close the configuration file. Make sure the filename is + correct and that the program has the appropriate permissions. + FAQ Id numbers returned by Facebook are being rounded. What is the problem? The JSON module that is installed on your system is converting the @@ -732,11 +740,11 @@ TESTING ---------------------------- ------ ------ ------ ------ ------ ------ ------ File stmt bran cond sub pod time total ---------------------------- ------ ------ ------ ------ ------ ------ ------ - blib/lib/WWW/Facebook/API.pm 97.5 83.1 63.6 98.3 100.0 7.6 92.9 - .../WWW/Facebook/API/Auth.pm 95.1 77.3 100.0 90.9 100.0 92.0 91.3 - ...WW/Facebook/API/Canvas.pm 97.6 87.5 100.0 100.0 100.0 0.1 97.1 + blib/lib/WWW/Facebook/API.pm 97.5 82.8 63.8 98.3 100.0 10.2 92.7 + .../WWW/Facebook/API/Auth.pm 95.1 77.3 100.0 90.9 100.0 89.1 91.3 + ...WW/Facebook/API/Canvas.pm 97.6 87.5 100.0 100.0 100.0 0.2 97.1 ...WW/Facebook/API/Events.pm 100.0 n/a n/a 100.0 100.0 0.0 100.0 - .../WWW/Facebook/API/FBML.pm 100.0 n/a n/a 100.0 100.0 0.0 100.0 + .../WWW/Facebook/API/FBML.pm 100.0 n/a n/a 100.0 100.0 0.1 100.0 ...b/WWW/Facebook/API/FQL.pm 100.0 n/a n/a 100.0 100.0 0.0 100.0 .../WWW/Facebook/API/Feed.pm 100.0 n/a n/a 100.0 100.0 0.0 100.0 ...W/Facebook/API/Friends.pm 100.0 n/a n/a 100.0 100.0 0.0 100.0 @@ -747,7 +755,7 @@ TESTING ...WW/Facebook/API/Photos.pm 100.0 n/a n/a 100.0 100.0 0.0 100.0 ...W/Facebook/API/Profile.pm 100.0 n/a n/a 100.0 100.0 0.0 100.0 ...WWW/Facebook/API/Users.pm 100.0 n/a n/a 100.0 100.0 0.0 100.0 - Total 97.6 82.7 68.3 97.8 100.0 100.0 94.1 + Total 97.6 82.5 68.2 97.8 100.0 100.0 94.0 ---------------------------- ------ ------ ------ ------ ------ ------ ------ AUTHOR @@ -786,6 +794,8 @@ CONTRIBUTORS King Mak "none" + Louis-Philippe "none" + LICENSE AND COPYRIGHT Copyright (c) 2007, David Romano "<unobe@cpan.org>". All rights reserved. README @@ -10,7 +10,7 @@ use warnings; use strict; use Carp; -use version; our $VERSION = qv('0.4.9'); +use version; our $VERSION = qv('0.4.10'); use LWP::UserAgent; use Time::HiRes qw(time); @@ -115,8 +115,7 @@ sub _set_from_file { my $app_path = shift; my %ENV_VARS = @_; - # fail silently if file can't be opened - open my $config, '<', $self->{'config'} + open my $config, '<', $self->{'config'} ## no critic or croak "Cannot open $self->{'config'}"; while (<$config>) { @@ -132,6 +131,8 @@ sub _set_from_file { $ENV{$key} ||= $val; } + close $config or croak "Cannot close $self->{'config'}"; + return; } @@ -161,7 +162,7 @@ sub new { $self->{'ua'} ||= LWP::UserAgent->new( agent => "Perl-WWW-Facebook-API/$VERSION" ); my $is_attribute = join q{|}, keys %attributes; - delete $self->{$_} for grep { !/^($is_attribute)$/xms } keys %{$self}; + delete $self->{$_} for grep { !/^ $is_attribute $/xms } keys %{$self}; # set up default namespaces $self->$_($self) for map {"\L$_"} @namespaces; @@ -243,7 +244,7 @@ sub redirect { if ( $self->canvas->in_fb_canvas ) { return qq{<fb:redirect url="$url" />}; } - elsif ($url =~ m[^https?://([^/]*\.)?facebook\.com(:\d+)?]ixms + elsif ($url =~ m{^https?://([^/]*\.)?facebook\.com(:\d+)?}ixms && $self->session_uid ) { return join q{}, @@ -333,7 +334,7 @@ sub _add_url_params { if ( @_ % 2 ) { # Odd number of elelemts, so didn't pass in canvas => 1 - $params .= q{&canvas} if grep { $_ eq 'canvas' } @_; + $params .= q{&canvas} if grep { $_ eq 'canvas' } @_; ## no critic @_ = grep { $_ ne 'canvas' } @_; } my %params = @_; @@ -388,7 +389,7 @@ sub _check_values_of { } if ( $params->{'method'} !~ m/^auth/xms ) { - $params->{'session_key'} = $self->session_key; + $params->{'session_key'} ||= $self->session_key; if ( !$params->{'callback'} && $self->callback ) { $params->{'callback'} = $self->callback; } @@ -446,7 +447,7 @@ sub _reformat_response { # get actual response when web app if ( $params->{'callback'} ) { - $response =~ s/^$params->{'callback'} [^\(]* \((.+) \);$/$1/xms; + $response =~ s/^$params->{'callback'} [^(]* [(](.+) [)];$/$1/xms; } undef $params; @@ -503,7 +504,7 @@ WWW::Facebook::API - Facebook API implementation =head1 VERSION -This document describes WWW::Facebook::API version 0.4.9 +This document describes WWW::Facebook::API version 0.4.10 =head1 SYNOPSIS @@ -1004,7 +1005,7 @@ when an error is returned from the REST server. =item ua The L<LWP::UserAgent> agent used to communicate with the REST server. -The agent_alias is initially set to "Perl-WWW-Facebook-API/0.4.9". +The agent_alias is initially set to "Perl-WWW-Facebook-API/0.4.10". =back @@ -1242,9 +1243,19 @@ Cannot create the needed attribute method. Contact the developer to report. =item C<<_format_and_check_params must be called in list context!>> -You're using a privat method call and you're not calling it in list context. +You're using a private method call and you're not calling it in list context. It returns a list of items, all of which should be interesting to you. +=item C<< Cannot open %s >> + +Cannot open the configuration file. Make sure the filename is correct and that +the program has the appropriate permissions. + +=item C<< Cannot close %s >> + +Cannot close the configuration file. Make sure the filename is correct and +that the program has the appropriate permissions. + =back =head1 FAQ @@ -1329,11 +1340,11 @@ With live tests enabled, here is the current test coverage: ---------------------------- ------ ------ ------ ------ ------ ------ ------ File stmt bran cond sub pod time total ---------------------------- ------ ------ ------ ------ ------ ------ ------ - blib/lib/WWW/Facebook/API.pm 97.5 83.1 63.6 98.3 100.0 7.6 92.9 - .../WWW/Facebook/API/Auth.pm 95.1 77.3 100.0 90.9 100.0 92.0 91.3 - ...WW/Facebook/API/Canvas.pm 97.6 87.5 100.0 100.0 100.0 0.1 97.1 + blib/lib/WWW/Facebook/API.pm 97.5 82.8 63.8 98.3 100.0 10.2 92.7 + .../WWW/Facebook/API/Auth.pm 95.1 77.3 100.0 90.9 100.0 89.1 91.3 + ...WW/Facebook/API/Canvas.pm 97.6 87.5 100.0 100.0 100.0 0.2 97.1 ...WW/Facebook/API/Events.pm 100.0 n/a n/a 100.0 100.0 0.0 100.0 - .../WWW/Facebook/API/FBML.pm 100.0 n/a n/a 100.0 100.0 0.0 100.0 + .../WWW/Facebook/API/FBML.pm 100.0 n/a n/a 100.0 100.0 0.1 100.0 ...b/WWW/Facebook/API/FQL.pm 100.0 n/a n/a 100.0 100.0 0.0 100.0 .../WWW/Facebook/API/Feed.pm 100.0 n/a n/a 100.0 100.0 0.0 100.0 ...W/Facebook/API/Friends.pm 100.0 n/a n/a 100.0 100.0 0.0 100.0 @@ -1344,7 +1355,7 @@ With live tests enabled, here is the current test coverage: ...WW/Facebook/API/Photos.pm 100.0 n/a n/a 100.0 100.0 0.0 100.0 ...W/Facebook/API/Profile.pm 100.0 n/a n/a 100.0 100.0 0.0 100.0 ...WWW/Facebook/API/Users.pm 100.0 n/a n/a 100.0 100.0 0.0 100.0 - Total 97.6 82.7 68.3 97.8 100.0 100.0 94.1 + Total 97.6 82.5 68.2 97.8 100.0 100.0 94.0 ---------------------------- ------ ------ ------ ------ ------ ------ ------ =head1 AUTHOR @@ -1385,6 +1396,8 @@ Derek Del Conte C<< derek@delconte.org >> King Mak C<< none >> +Louis-Philippe C<< none >> + =head1 LICENSE AND COPYRIGHT Copyright (c) 2007, David Romano C<< <unobe@cpan.org> >>. All rights reserved. lib/WWW/Facebook/API.pm @@ -10,7 +10,7 @@ use warnings; use strict; use Carp; -use version; our $VERSION = qv('0.4.9'); +use version; our $VERSION = qv('0.4.10'); sub create_token { my $self = shift; @@ -57,7 +57,7 @@ sub get_session { $self->_use_http_uri() if $self->base->desktop; # Copy values from response to object's hash - AUTH_RESPONSE: +AUTH_RESPONSE: for my $key ( keys %{$resp} ) { next AUTH_RESPONSE if $key eq 'secret' && !$self->base->desktop; carp "Setting $field{$key}: $resp->{$key}" if $self->base->debug; @@ -100,13 +100,13 @@ sub logout { return; } -sub _use_http_uri { return shift->_flip_scheme(0); } ## no critic -sub _use_https_uri { return shift->_flip_scheme(1); } ## no critic +sub _use_http_uri { return shift->_flip_scheme(0); } ## no critic +sub _use_https_uri { return shift->_flip_scheme(1); } ## no critic sub _flip_scheme { - my $self = shift; + my $self = shift; my $make_https = shift; - my $scheme = $make_https ? 'http' : 'https'; + my $scheme = $make_https ? 'http' : 'https'; ( my $uri = $self->base->server_uri() ) =~ s{^[^:]+:}{$scheme:}xms; $self->base->server_uri($uri); @@ -123,7 +123,7 @@ WWW::Facebook::API::Auth - Facebook Authentication =head1 VERSION -This document describes WWW::Facebook::API::Auth version 0.4.9 +This document describes WWW::Facebook::API::Auth version 0.4.10 =head1 SYNOPSIS @@ -137,6 +137,14 @@ Methods for accessing auth with L<WWW::Facebook::API> =over +=item base + +Returns the L<WWW::Facebook::API> base object. + +=item new + +Constructor. + =item create_token() auth.createToken of the Facebook API. Will always return the token string, lib/WWW/Facebook/API/Auth.pm @@ -9,7 +9,7 @@ use warnings; use strict; use Carp; -use version; our $VERSION = qv('0.4.9'); +use version; our $VERSION = qv('0.4.10'); sub get_fb_params { my $self = shift; @@ -82,7 +82,7 @@ WWW::Facebook::API::Canvas - Facebook Canvas =head1 VERSION -This document describes WWW::Facebook::API::Canvas version 0.4.9 +This document describes WWW::Facebook::API::Canvas version 0.4.10 =head1 SYNOPSIS @@ -99,6 +99,14 @@ L<Apache::Request> object). =over +=item base + +Returns the L<WWW::Facebook::API> base object. + +=item new + +Constructor. + =item get_user( $q ) Return the UID of the canvas user or "" if it does not exist (See lib/WWW/Facebook/API/Canvas.pm @@ -10,7 +10,7 @@ use warnings; use strict; use Carp; -use version; our $VERSION = qv('0.4.9'); +use version; our $VERSION = qv('0.4.10'); sub get { return shift->base->call( 'events.get', @_ ) } sub get_members { return shift->base->call( 'events.getMembers', @_ ) } @@ -24,7 +24,7 @@ WWW::Facebook::API::Events - Facebook Events =head1 VERSION -This document describes WWW::Facebook::API::Events version 0.4.9 +This document describes WWW::Facebook::API::Events version 0.4.10 =head1 SYNOPSIS @@ -39,6 +39,14 @@ Methods for accessing events with L<WWW::Facebook::API> =over +=item base + +Returns the L<WWW::Facebook::API> base object. + +=item new + +Constructor. + =item get( %params ) The events.get method of the Facebook API: lib/WWW/Facebook/API/Events.pm @@ -4,7 +4,7 @@ use warnings; use strict; use Carp; -use version; our $VERSION = qv('0.4.9'); +use version; our $VERSION = qv('0.4.10'); sub refresh_img_src { return shift->base->call( 'fbml.refreshImgSrc', @_ ) } sub refresh_ref_url { return shift->base->call( 'fbml.refreshRefUrl', @_ ) } @@ -19,7 +19,7 @@ WWW::Facebook::API::FBML - Facebook Markup Language =head1 VERSION -This document describes WWW::Facebook::API::FBML version 0.4.9 +This document describes WWW::Facebook::API::FBML version 0.4.10 =head1 SYNOPSIS @@ -33,6 +33,14 @@ Methods for updating FBML references with L<WWW::Facebook::API> =over +=item base + +Returns the L<WWW::Facebook::API> base object. + +=item new + +Constructor. + =item set_ref_handle( handle => 'handleName', fbml => 'fbml' ) The fbml.setRefHandle method of the Facebook API. See this page on the wiki: lib/WWW/Facebook/API/FBML.pm @@ -9,7 +9,7 @@ use warnings; use strict; use Carp; -use version; our $VERSION = qv('0.4.9'); +use version; our $VERSION = qv('0.4.10'); # always return an array reference. The value returned by Facebook is a hash # reference when there are no results, so this shouldn't be a problem. @@ -27,7 +27,7 @@ WWW::Facebook::API::FQL - Facebook Query Language =head1 VERSION -This document describes WWW::Facebook::API::FQL version 0.4.9 +This document describes WWW::Facebook::API::FQL version 0.4.10 =head1 SYNOPSIS @@ -41,6 +41,14 @@ Methods for accessing messages with L<WWW::Facebook::API> =over +=item base + +Returns the L<WWW::Facebook::API> base object. + +=item new + +Constructor. + =item query( query => 'FQL QUERY LANGUAGE' ) The fql.query method of the Facebook API: lib/WWW/Facebook/API/FQL.pm @@ -10,7 +10,7 @@ use warnings; use strict; use Carp; -use version; our $VERSION = qv('0.4.9'); +use version; our $VERSION = qv('0.4.10'); sub publish_story_to_user { return shift->base->call( 'feed.publishStoryToUser', @_ ); @@ -33,7 +33,7 @@ WWW::Facebook::API::Feed - Facebook Feeds =head1 VERSION -This document describes WWW::Facebook::API::Feed version 0.4.9 +This document describes WWW::Facebook::API::Feed version 0.4.10 =head1 SYNOPSIS @@ -47,6 +47,14 @@ Methods for accessing feeds with L<WWW::Facebook::API> =over +=item base + +Returns the L<WWW::Facebook::API> base object. + +=item new + +Constructor. + =item publish_story_to_user( %params ) The feed.publishStoryToUser method of the Facebook API. C<title> is the only lib/WWW/Facebook/API/Feed.pm @@ -10,7 +10,7 @@ use warnings; use strict; use Carp; -use version; our $VERSION = qv('0.4.9'); +use version; our $VERSION = qv('0.4.10'); sub get { return shift->base->call( 'friends.get', @_ ) } sub get_app_users { return shift->base->call( 'friends.getAppUsers', @_ ) } @@ -25,7 +25,7 @@ WWW::Facebook::API::Friends - Facebook Friends =head1 VERSION -This document describes WWW::Facebook::API::Friends version 0.4.9 +This document describes WWW::Facebook::API::Friends version 0.4.10 =head1 SYNOPSIS @@ -39,6 +39,14 @@ Methods for accessing friends with L<WWW::Facebook::API> =over +=item base + +Returns the L<WWW::Facebook::API> base object. + +=item new + +Constructor. + =item get() The friends.get method of the Facebook API: lib/WWW/Facebook/API/Friends.pm @@ -10,7 +10,7 @@ use warnings; use strict; use Carp; -use version; our $VERSION = qv('0.4.9'); +use version; our $VERSION = qv('0.4.10'); sub get { return shift->base->call( 'groups.get', @_ ) } sub get_members { return shift->base->call( 'groups.getMembers', @_ ) } @@ -24,7 +24,7 @@ WWW::Facebook::API::Groups - Facebook Groups =head1 VERSION -This document describes WWW::Facebook::API::Groups version 0.4.9 +This document describes WWW::Facebook::API::Groups version 0.4.10 =head1 SYNOPSIS @@ -38,6 +38,14 @@ Methods for accessing groups with L<WWW::Facebook::API> =over +=item base + +Returns the L<WWW::Facebook::API> base object. + +=item new + +Constructor. + =item get( uid => 'uid', gids => [ @gids ] ) The groups.get method of the Facebook API: lib/WWW/Facebook/API/Groups.pm @@ -10,7 +10,7 @@ use warnings; use strict; use Carp; -use version; our $VERSION = qv('0.4.9'); +use version; our $VERSION = qv('0.4.10'); sub get_categories { return shift->base->call( 'marketplace.getCategories', @_ ); @@ -46,7 +46,7 @@ WWW::Facebook::API::Marketplace - Facebook Marketplace =head1 VERSION -This document describes WWW::Facebook::API::Marketplace version 0.4.9 +This document describes WWW::Facebook::API::Marketplace version 0.4.10 =head1 SYNOPSIS @@ -60,6 +60,14 @@ Methods for accessing the marketplace with L<WWW::Facebook::API> =over +=item base + +Returns the L<WWW::Facebook::API> base object. + +=item new + +Constructor. + =item get_categories() The marketplace.getCategories method of the Facebook API: lib/WWW/Facebook/API/Marketplace.pm @@ -10,7 +10,7 @@ use warnings; use strict; use Carp; -use version; our $VERSION = qv('0.4.9'); +use version; our $VERSION = qv('0.4.10'); sub get { return shift->base->call( 'notifications.get', @_ ) } sub send { return shift->base->call( 'notifications.send', @_ ) } ## no critic @@ -25,7 +25,7 @@ WWW::Facebook::API::Notifications - Facebook Notifications =head1 VERSION -This document describes WWW::Facebook::API::Notifications version 0.4.9 +This document describes WWW::Facebook::API::Notifications version 0.4.10 =head1 SYNOPSIS @@ -39,6 +39,14 @@ Methods for accessing notification information with L<WWW::Facebook::API> =over +=item base + +Returns the L<WWW::Facebook::API> base object. + +=item new + +Constructor. + =item get() The notifications.get method of the Facebook API: lib/WWW/Facebook/API/Notifications.pm @@ -9,12 +9,12 @@ use warnings; use strict; use Carp; -use version; our $VERSION = qv('0.4.9'); +use version; our $VERSION = qv('0.4.10'); -sub get_info { return shift->base->call( 'pages.getInfo', @_ ) } -sub is_app_added { return shift->base->call( 'pages.isAppAdded', @_ ) } -sub is_admin { return shift->base->call( 'pages.isAdmin', @_ ) } -sub is_fan { return shift->base->call( 'pages.isFan', @_ ) } +sub get_info { return shift->base->call( 'pages.getInfo', @_ ) } +sub is_app_added { return shift->base->call( 'pages.isAppAdded', @_ ) } +sub is_admin { return shift->base->call( 'pages.isAdmin', @_ ) } +sub is_fan { return shift->base->call( 'pages.isFan', @_ ) } 1; # Magic true value required at end of module __END__ @@ -25,7 +25,7 @@ WWW::Facebook::API::Pages - Facebook Pages Info =head1 VERSION -This document describes WWW::Facebook::API::Pages version 0.4.9 +This document describes WWW::Facebook::API::Pages version 0.4.10 =head1 SYNOPSIS @@ -39,6 +39,14 @@ Methods for accessing messages with L<WWW::Facebook::API> =over +=item base + +Returns the L<WWW::Facebook::API> base object. + +=item new + +Constructor. + =item get_info( %params ) The pages.getInfo method of the Facebook API: lib/WWW/Facebook/API/Pages.pm @@ -10,7 +10,7 @@ use warnings; use strict; use Carp; -use version; our $VERSION = qv('0.4.9'); +use version; our $VERSION = qv('0.4.10'); sub add_tag { return shift->base->call( 'photos.addTag', @_ ) } sub create_album { return shift->base->call( 'photos.createAlbum', @_ ) } @@ -28,7 +28,7 @@ WWW::Facebook::API::Photos - Facebook Photos =head1 VERSION -This document describes WWW::Facebook::API::Photos version 0.4.9 +This document describes WWW::Facebook::API::Photos version 0.4.10 =head1 SYNOPSIS @@ -42,6 +42,14 @@ Methods for accessing photos with L<WWW::Facebook::API> =over +=item base + +Returns the L<WWW::Facebook::API> base object. + +=item new + +Constructor. + =item add_tag( %params ) The photos.addTag method of the Facebook API: lib/WWW/Facebook/API/Photos.pm @@ -10,7 +10,7 @@ use warnings; use strict; use Carp; -use version; our $VERSION = qv('0.4.9'); +use version; our $VERSION = qv('0.4.10'); sub set_fbml { return shift->base->call( 'profile.setFBML', @_ ) } sub get_fbml { return shift->base->call( 'profile.getFBML', @_ ) } @@ -24,7 +24,7 @@ WWW::Facebook::API::Profile - Facebook Profile =head1 VERSION -This document describes WWW::Facebook::API::Profile version 0.4.9 +This document describes WWW::Facebook::API::Profile version 0.4.10 =head1 SYNOPSIS @@ -38,6 +38,14 @@ Methods for accessing profiles with L<WWW::Facebook::API> =over +=item base + +Returns the L<WWW::Facebook::API> base object. + +=item new + +Constructor. + =item set_fbml( markup => $fbml_markup, uid => $single_uid ) The profile.setFBML method of the Facebook API. lib/WWW/Facebook/API/Profile.pm @@ -10,7 +10,7 @@ use warnings; use strict; use Carp; -use version; our $VERSION = qv('0.4.9'); +use version; our $VERSION = qv('0.4.10'); sub get_info { return shift->base->call( 'users.getInfo', @_ ); } @@ -39,7 +39,7 @@ WWW::Facebook::API::Users - Facebook Users =head1 VERSION -This document describes WWW::Facebook::API::Users version 0.4.9 +This document describes WWW::Facebook::API::Users version 0.4.10 =head1 SYNOPSIS @@ -53,6 +53,14 @@ Methods for accessing users with L<WWW::Facebook::API> =over +=item base + +Returns the L<WWW::Facebook::API> base object. + +=item new + +Constructor. + =item get_info( uids => $uids, fields => $fields ) The users.getInfo method of the Facebook API: lib/WWW/Facebook/API/Users.pm @@ -4,7 +4,7 @@ # $Author: david.romano $ # ex: set ts=8 sw=4 et ######################################################################### -use Test::More tests => 16; +use Test::More tests => 19; use WWW::Facebook::API; use strict; use warnings; @@ -67,6 +67,13 @@ is $params->{'call_id'}, $time, 'time not reset'; is $params->{'session_key'}, q{}, 'session key set from object\'s value'; ok !exists $params->{'callback'}, 'callback not set'; +# Mostly just testing that session_key's passed in value is kept... +$params = { method => 'hello2', session_key => 'foo' }; +$api->_check_values_of( $params ); +is $params->{'method'}, 'facebook.hello2', 'method changed again'; +is $params->{'session_key'}, q{foo}, 'session key not changed'; +ok !exists $params->{'callback'}, 'callback not set'; + $api->callback('/new_info'); $params = { call_id => $time, method => 'fun' }; $api->_check_values_of( $params ); t/internal.t @@ -3,3 +3,5 @@ exclude = CodeLayout::RequireTidyCode [-ControlStructures::ProhibitUnlessBlocks] [-Variables::ProhibitPackageVars] [-Miscellanea::RequireRcsKeywords] +[-Subroutines::RequireArgUnpacking] +[-InputOutput::RequireCheckedSyscalls] t/perlcriticrc f20ebd4dcc0888608153df9f3bf5eb0af1676877 david.romano david.romano@a3c37c4d-c931-0410-83b8-a36781ac0157 http://github.com/unobe/perl-wfa/commit/eceb76664eade14c0fc192d2274a9d9889214ced eceb76664eade14c0fc192d2274a9d9889214ced 2007-12-01T20:34:27-08:00 2007-12-01T20:34:27-08:00 Version 0.4.10 session_key bug fix and perl-tidy/critic run-thru modified: Changes modified: MANIFEST.SKIP modified: README modified: lib/WWW/Facebook/API.pm modified: lib/WWW/Facebook/API/Auth.pm modified: lib/WWW/Facebook/API/Canvas.pm modified: lib/WWW/Facebook/API/Events.pm modified: lib/WWW/Facebook/API/FBML.pm modified: lib/WWW/Facebook/API/FQL.pm modified: lib/WWW/Facebook/API/Feed.pm modified: lib/WWW/Facebook/API/Friends.pm modified: lib/WWW/Facebook/API/Groups.pm modified: lib/WWW/Facebook/API/Marketplace.pm modified: lib/WWW/Facebook/API/Notifications.pm modified: lib/WWW/Facebook/API/Pages.pm modified: lib/WWW/Facebook/API/Photos.pm modified: lib/WWW/Facebook/API/Profile.pm modified: lib/WWW/Facebook/API/Users.pm modified: t/internal.t modified: t/perlcriticrc git-svn-id: https://perl-www-facebook-api.googlecode.com/svn/trunk@204 a3c37c4d-c931-0410-83b8-a36781ac0157 daf7511bd5f82fc54b985f6f39a751e73d2ecc9a david.romano david.romano@a3c37c4d-c931-0410-83b8-a36781ac0157