@@ -12,4 +12,16 @@ Style guide for lawnelephant developers: (I know this hasn't been done universally in LeftParen, but we're trying to get there.) +* Comment full-line comments like this: + +;; this is a full-line comment + +(with two semi-colons, indented as you would any other Scheme +expression at that position.) + +If you add a comment to the end of a line, use one semi-colon, like this: + +(define (foo x) + (* x x) ; this is a neat line of code! + docs/style-guide.txt @@ -32,8 +32,8 @@ (li (a ((href "http://github.com/vegashacker/lawnelephant/tree/master")) "github")) (li (a ((href "http://blog.lawnelephant.com")) "blog")) (li (a ((href "mailto:ask@lawnelephant.com")) "ask@lawnelephant.com")) - ;goog analytics really needs to be just before the closing body tag, but I don't know - ;how to put it there just yet + ;; XXX goog analytics really needs to be just before the closing body tag, but I + ;; don't know how to put it there just yet ,(raw-str goog-analytics))) (define (index-page-view sesh #:form-view (form-markup request-feature-form-view)) @@ -70,42 +70,40 @@ (div ((id "ft")) ,standard-footer))))) (define (feature-req-view sesh feat) - `(li - (span ((class "explanation")) - ,(feature-request-expl feat)) + `(li (span ((class "explanation")) + ,(feature-request-expl feat)) (div ((class "explanation-rest")) - ,(web-link "[link]" (page-url feature-detail-page (rec-id feat))) - " " - ,(xexpr-if (can-vote-on? sesh feat) - (** (web-link "[vote up]" (make-up-voter-url sesh feat)) - " ")) - ,(format "~A pts " (vote-score feat)) - ,(xexpr-if (in-admin-mode?) - (delete-entry-view feat))))) + ,(web-link "[link]" (page-url feature-detail-page (rec-id feat))) + " " + ,(xexpr-if (can-vote-on? sesh feat) + (** (web-link "[vote up]" (make-up-voter-url sesh feat)) + " ")) + ,(format "~A pts " (vote-score feat)) + ,(xexpr-if (in-admin-mode?) + (delete-entry-view feat))))) (define-page (feature-feed-page req) - #:blank #t - (atom-feed feature-feed-page - #:feed-title "features for lawnelephant" - #:feed-description "all the features so far" - #:feed-updated/epoch-seconds (current-seconds) - #:author-name "the lawnelephant staff" - #:items - (map (lambda (fr) - (let ((explanation (rec-prop fr 'explanation))) - (atom-item - #:title (string-ellide explanation 40) - #:url (string-append (setting *WEB_APP_URL*) "feature/" (rec-id fr)) - #:updated-epoch-seconds (rec-prop fr 'created-at) - #:content explanation))) - (get-feature-requests)))) + #:blank #t + (atom-feed feature-feed-page + #:feed-title "features for lawnelephant" + #:feed-description "all the features so far" + #:feed-updated/epoch-seconds (current-seconds) + #:author-name "the lawnelephant staff" + #:items + (map (lambda (fr) + (let ((explanation (rec-prop fr 'explanation))) + (atom-item + #:title (string-ellide explanation 40) + #:url (string-append (setting *WEB_APP_URL*) "feature/" (rec-id fr)) + #:updated-epoch-seconds (rec-prop fr 'created-at) + #:content explanation))) + (get-feature-requests)))) (define (delete-entry-view feat-req-rec) (** " " (web-link "[delete]" (body-as-url (req) (delete-rec! feat-req-rec) (redirect-to (page-url index-page)))))) - (define (base-design #:title (title "lawnelephant")) (design #:atom-feed-page feature-feed-page @@ -114,4 +112,3 @@ "/css/main.css") #:title title)) - view.ss 85df339a84bb204db91de3f9a9b43b9298e1c760 Rob Hunter rob.hunter@gmail.com http://github.com/vegashacker/lawnelephant/commit/72f4ac4547e47fd7e54f99ce17b0ab67ad7d7d90 72f4ac4547e47fd7e54f99ce17b0ab67ad7d7d90 2009-02-06T10:58:45-08:00 2009-02-06T10:58:45-08:00 a formatting-only checkin 4d3bc853e06084badb75b80dccabb47d66c6eae8 Rob Hunter rob.hunter@gmail.com