@@ -8,7 +8,6 @@ (newest-page (url "/newest")) (completed-page (url "/completed")) (feature-detail-page (url "/feature/" (string-arg))) - (feature-feed-page (url "/atom.xml")) (signin-page (url "/signin")) (adminified-index-page (url "/admin")) ) app.scm @@ -43,12 +43,8 @@ (if redirect (redirect-to redirect) "comment saved.")))) - (div ((id "ft")) - (ul ((class "simple")) - ,(li-a "http://github.com/vegashacker/lawnelephant/tree/master" "source code") - ,(li-a "http://blog.lawnelephant.com" "blog") - ,(li-a "mailto:ask@lawnelephant.com" "ask@lawnelephant.com")))))) -;;XXX using nonstandard footer - don't want goog analytics to track this page + (div ((id "ft")) + ,standard-footer)))) (define (show-all-comments-view sesh parent-item #:threaded (threaded #f) discuss.ss @@ -3,17 +3,20 @@ (require (planet "leftparen.scm" ("vegashacker" "leftparen.plt" 4 (= 1))) (planet "util.scm" ("vegashacker" "leftparen.plt" 4 (= 1))) ) + (provide base-design li-a - ;goog-analytics - ;standard-footer + goog-analytics + standard-footer ) + + (define (base-design #:title (title "lawnelephant")) (design - ;#:atom-feed-page feature-feed-page - #:js '("http://yui.yahooapis.com/combo?2.6.0/build/yahoo-dom-event/yahoo-dom-event.js&2.6.0/build/element/element-beta-min.js&2.6.0/build/tabview/tabview-min.js") + #:js '("http://ajax.googleapis.com/ajax/libs/jquery/1.3.1/jquery.min.js" + "scripts/init.js") #:css '("http://yui.yahooapis.com/combo?2.6.0/build/reset-fonts-grids/reset-fonts-grids.css&2.6.0/build/base/base-min.css&2.6.0/build/tabview/assets/skins/sam/tabview.css" "/css/main.css") #:title title)) @@ -36,10 +39,17 @@ (define standard-footer - `(ul ((class "simple")) - ,(li-a "http://github.com/vegashacker/lawnelephant/tree/master" "github") + `(div + (ul ((class "simple")) + (li "features:") + ,(li-a "/popular" "popular") + ,(li-a "/newest" "newest") + ,(li-a "/completed" "completed")) + (ul ((class "simple")) + ,(li-a "http://blog.lawnelephant.com/post/74637624/introducing-lawnelephant-com" "about") ,(li-a "http://blog.lawnelephant.com" "blog") + ,(li-a "http://github.com/vegashacker/lawnelephant/tree/master" "source code") ,(li-a "mailto:ask@lawnelephant.com" "ask@lawnelephant.com") ;; XXX goog analytics really needs to be just before the closing body tag, but I ;; don't know how to put it there just yet - ,(raw-str goog-analytics))) + ,(raw-str goog-analytics)))) templates.ss @@ -7,47 +7,16 @@ "data.ss" "social.ss" "discuss.ss" + "templates.ss" "admin.ss") (provide index-page-view feature-detail-page-view - base-design list-page-view ) -(define goog-analytics - " - <script type=\"text/javascript\"> - var gaJsHost = ((\"https:\" == document.location.protocol) ? \"https://ssl.\" : \"http://www.\"); - document.write(unescape(\"%3Cscript src='\" + gaJsHost + \"google-analytics.com/ga.js' type='text/javascript'%3E%3C/script%3E\")); - </script> - <script type=\"text/javascript\"> - try { - var pageTracker = _gat._getTracker(\"UA-7294827-1\"); - pageTracker._trackPageview(); - } catch(err) {}</script> -") - -(define (li-a link name) - `(li (a ((href ,link)) ,name))) - -(define standard-footer - `(div - (ul ((class "simple")) - (li "features:") - ,(li-a "/popular" "popular") - ,(li-a "/newest" "newest") - ,(li-a "/completed" "completed")) - (ul ((class "simple")) - ,(li-a "http://blog.lawnelephant.com/post/74637624/introducing-lawnelephant-com" "about") - ,(li-a "http://blog.lawnelephant.com" "blog") - ,(li-a "http://github.com/vegashacker/lawnelephant/tree/master" "source code") - ,(li-a "mailto:ask@lawnelephant.com" "ask@lawnelephant.com") - ;; XXX goog analytics really needs to be just before the closing body tag, but I - ;; don't know how to put it there just yet - ,(raw-str goog-analytics)))) (define (index-page-view sesh #:form-view (form-markup request-feature-form-view)) (page @@ -170,22 +139,7 @@ ,(xexpr-if (and (not is-completed?) (in-admin-mode?)) (mark-as-completed-view feat)))))) -(define-page (feature-feed-page req) - #:blank #t - (atom-feed feature-feed-page - #:feed-title "features for lawnelephant" - #:feed-description "all the features so far" - #:feed-updated/epoch-seconds (current-seconds) - #:author-name "the lawnelephant staff" - #:items - (map (lambda (fr) - (let ((explanation (rec-prop fr 'explanation))) - (atom-item - #:title (string-ellide explanation 40) - #:url (string-append (setting *WEB_APP_URL*) "feature/" (rec-id fr)) - #:updated-epoch-seconds (rec-prop fr 'created-at) - #:content explanation))) - (get-feature-requests-newest)))) + (define (delete-entry-view feat-req-rec) (** " " @@ -200,12 +154,4 @@ (redirect-to (page-url adminified-index-page)))))) -(define (base-design #:title (title "lawnelephant")) - (design - #:atom-feed-page feature-feed-page - #:js '("http://ajax.googleapis.com/ajax/libs/jquery/1.3.1/jquery.min.js" - "scripts/init.js") - #:css '("http://yui.yahooapis.com/combo?2.6.0/build/reset-fonts-grids/reset-fonts-grids.css&2.6.0/build/base/base-min.css&2.6.0/build/tabview/assets/skins/sam/tabview.css" - "/css/main.css") - #:title title)) view.ss 88562d6e715a1600c382ada8144fc074a2b4e021 Idoh Gersten idoh@idoh.com http://github.com/vegashacker/lawnelephant/commit/befdc64849fa74ed97482aa0f4dfbd5e478f5fce befdc64849fa74ed97482aa0f4dfbd5e478f5fce

2009-03-19T23:55:29-07:00

moving things over to template.ss, removed rss feed (didn't work right anyway) for now. This change makes the comment box work right for the reply to comments area as well. afb79efd5690921a0619fff314967a424a5ddefe Idoh Gersten idoh@idoh.com