Fix C++17 build. #437
Merged
Fix C++17 build. #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe we avoided the removal of Thanks for the PR. |
noloader
referenced
this pull request
Jul 16, 2017
… globally scoped byte This check-in supports Romain Geissler's work on cleaning up our use of ::byte when it collides with std::byte. Regardless of what happens, such as removing ::byte and adding CryptoPP::byte, providing the typedef here makes Kalyna immune to the outside changes. Also see Pull Request 437 and 438.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I am having issues when compiling Cryptopp with gcc 7 and -std=gnu++17. The reason is ::byte (defined by cryptopp) and std::byte (defined by C++17) are ambiguous when having a "using namespace std" statement.
This pull request fixes the very minimal things to make the build work. Yet another pull request is required to make Cryptopp usable by someone who used "using namespace std" in it's source file when including cryptopp. That will come later.
Cheers,
Romain