Don't replace exceptions in *Configuration with an easy-to-miss println.

- Percolate them on up, and fail. Fail hard.
thorntail · Oct 23, 2015 · e85495e · e85495e
1 parent 73f00d3
commit e85495e
Show file tree

Hide file tree

Showing 22 changed files with 146 additions and 186 deletions.
diff --git a/.../src/main/java/org/wildfly/swarm/bean/validation/runtime/BeanValidationConfiguration.java b/.../src/main/java/org/wildfly/swarm/bean/validation/runtime/BeanValidationConfiguration.java
@@ -1,14 +1,17 @@
 package org.wildfly.swarm.bean.validation.runtime;
 
+import java.util.ArrayList;
+import java.util.List;
+
 import org.jboss.dmr.ModelNode;
 import org.wildfly.swarm.bean.validation.BeanValidationFraction;
 import org.wildfly.swarm.config.runtime.invocation.Marshaller;
 import org.wildfly.swarm.container.runtime.AbstractServerConfiguration;
 
-import java.util.ArrayList;
-import java.util.List;
-
-import static org.jboss.as.controller.descriptions.ModelDescriptionConstants.*;
+import static org.jboss.as.controller.descriptions.ModelDescriptionConstants.ADD;
+import static org.jboss.as.controller.descriptions.ModelDescriptionConstants.EXTENSION;
+import static org.jboss.as.controller.descriptions.ModelDescriptionConstants.OP;
+import static org.jboss.as.controller.descriptions.ModelDescriptionConstants.OP_ADDR;
 
 /**
  * @author Bob McWhirter
@@ -25,7 +28,7 @@ public BeanValidationFraction defaultFraction() {
     }
 
     @Override
-    public List<ModelNode> getList(BeanValidationFraction fraction) {
+    public List<ModelNode> getList(BeanValidationFraction fraction) throws Exception {
 
         List<ModelNode> list = new ArrayList<>();
 
@@ -34,13 +37,8 @@ public List<ModelNode> getList(BeanValidationFraction fraction) {
         node.get(OP).set(ADD);
         list.add(node);
 
-        try {
-            list.addAll(Marshaller.marshal(fraction));
-        } catch (Exception e) {
-            System.err.println("Unable to configure bean-validation " + e);
-        }
+        list.addAll(Marshaller.marshal(fraction));
 
         return list;
-
     }
 }
diff --git a/container/runtime/src/main/java/org/wildfly/swarm/container/runtime/RuntimeServer.java b/container/runtime/src/main/java/org/wildfly/swarm/container/runtime/RuntimeServer.java
@@ -297,7 +297,7 @@ private void loadFractionConfigurations() throws Exception {
         }
     }
 
-    private List<ModelNode> getList(Container config) throws ModuleLoadException {
+    private List<ModelNode> getList(Container config) throws Exception {
         List<ModelNode> list = new ArrayList<>();
 
         configureInterfaces(config, list);
@@ -373,7 +373,7 @@ private void configureSocketBinding(PathAddress address, SocketBinding binding,
         list.add(node);
     }
 
-    private void configureFractions(Container config, List<ModelNode> list) throws ModuleLoadException {
+    private void configureFractions(Container config, List<ModelNode> list) throws Exception {
 
         OUTER:
         for (ServerConfiguration eachConfig : this.configList) {

diff --git a/container/runtime/src/main/java/org/wildfly/swarm/container/runtime/ServerConfiguration.java b/container/runtime/src/main/java/org/wildfly/swarm/container/runtime/ServerConfiguration.java
@@ -25,11 +25,11 @@ default void prepareArchive(Archive a) {
 
     }
 
-    default List<Archive> getImplicitDeployments(T fraction) {
+    default List<Archive> getImplicitDeployments(T fraction) throws Exception {
         return Collections.emptyList();
     }
 
-    default List<ModelNode> getList(T fraction) {
+    default List<ModelNode> getList(T fraction) throws Exception {
         return Collections.emptyList();
     }
 

diff --git a/...runtime/src/main/java/org/wildfly/swarm/datasources/runtime/DatasourcesConfiguration.java b/...runtime/src/main/java/org/wildfly/swarm/datasources/runtime/DatasourcesConfiguration.java
@@ -24,15 +24,12 @@ public DatasourcesFraction defaultFraction() {
     }
 
     @Override
-    public List<ModelNode> getList(DatasourcesFraction fraction) {
+    public List<ModelNode> getList(DatasourcesFraction fraction) throws Exception {
 
         List<ModelNode> list = new ArrayList<>();
 
-        try {
-            list.addAll(Marshaller.marshal(fraction));
-        } catch (Exception e) {
-            System.err.println("Cannot configure datasources subsystem");
-        }
+        list.addAll(Marshaller.marshal(fraction));
+
         return list;
     }
 

diff --git a/ee/runtime/src/main/java/org/wildfly/swarm/ee/runtime/EEConfiguration.java b/ee/runtime/src/main/java/org/wildfly/swarm/ee/runtime/EEConfiguration.java
@@ -1,14 +1,17 @@
 package org.wildfly.swarm.ee.runtime;
 
+import java.util.ArrayList;
+import java.util.List;
+
 import org.jboss.dmr.ModelNode;
 import org.wildfly.swarm.config.runtime.invocation.Marshaller;
 import org.wildfly.swarm.container.runtime.AbstractServerConfiguration;
 import org.wildfly.swarm.ee.EEFraction;
 
-import java.util.ArrayList;
-import java.util.List;
-
-import static org.jboss.as.controller.descriptions.ModelDescriptionConstants.*;
+import static org.jboss.as.controller.descriptions.ModelDescriptionConstants.ADD;
+import static org.jboss.as.controller.descriptions.ModelDescriptionConstants.EXTENSION;
+import static org.jboss.as.controller.descriptions.ModelDescriptionConstants.OP;
+import static org.jboss.as.controller.descriptions.ModelDescriptionConstants.OP_ADDR;
 
 /**
  * @author Bob McWhirter
@@ -26,7 +29,7 @@ public EEFraction defaultFraction() {
     }
 
     @Override
-    public List<ModelNode> getList(EEFraction fraction) {
+    public List<ModelNode> getList(EEFraction fraction) throws Exception {
 
         List<ModelNode> list = new ArrayList<>();
 
@@ -35,11 +38,8 @@ public List<ModelNode> getList(EEFraction fraction) {
         node.get(OP).set(ADD);
         list.add(node);
 
-        try {
-            list.addAll(Marshaller.marshal(fraction));
-        } catch (Exception e) {
-            System.err.println("Cannot configure EE subsystem " + e);
-        }
+        list.addAll(Marshaller.marshal(fraction));
+
         return list;
 
     }

diff --git a/ejb/runtime/src/main/java/org/wildfly/swarm/ejb/runtime/EJBConfiguration.java b/ejb/runtime/src/main/java/org/wildfly/swarm/ejb/runtime/EJBConfiguration.java
@@ -1,14 +1,17 @@
 package org.wildfly.swarm.ejb.runtime;
 
+import java.util.ArrayList;
+import java.util.List;
+
 import org.jboss.dmr.ModelNode;
 import org.wildfly.swarm.config.runtime.invocation.Marshaller;
 import org.wildfly.swarm.container.runtime.AbstractServerConfiguration;
 import org.wildfly.swarm.ejb.EJBFraction;
 
-import java.util.ArrayList;
-import java.util.List;
-
-import static org.jboss.as.controller.descriptions.ModelDescriptionConstants.*;
+import static org.jboss.as.controller.descriptions.ModelDescriptionConstants.ADD;
+import static org.jboss.as.controller.descriptions.ModelDescriptionConstants.EXTENSION;
+import static org.jboss.as.controller.descriptions.ModelDescriptionConstants.OP;
+import static org.jboss.as.controller.descriptions.ModelDescriptionConstants.OP_ADDR;
 
 /**
  * @author Ken Finnigan
@@ -25,19 +28,16 @@ public EJBFraction defaultFraction() {
     }
 
     @Override
-    public List<ModelNode> getList(EJBFraction fraction) {
+    public List<ModelNode> getList(EJBFraction fraction) throws Exception {
         List<ModelNode> list = new ArrayList<>();
 
         ModelNode node = new ModelNode();
         node.get(OP_ADDR).set(EXTENSION, "org.jboss.as.ejb3");
         node.get(OP).set(ADD);
         list.add(node);
 
-        try {
-            list.addAll(Marshaller.marshal(fraction));
-        } catch (Exception e) {
-            System.err.println("Cannot configure EJB subsystem. " + e);
-        }
+        list.addAll(Marshaller.marshal(fraction));
+
         return list;
     }
 }
diff --git a/...n/runtime/src/main/java/org/wildfly/swarm/infinispan/runtime/InfinispanConfiguration.java b/...n/runtime/src/main/java/org/wildfly/swarm/infinispan/runtime/InfinispanConfiguration.java
@@ -12,7 +12,6 @@
 import static org.jboss.as.controller.descriptions.ModelDescriptionConstants.EXTENSION;
 import static org.jboss.as.controller.descriptions.ModelDescriptionConstants.OP;
 import static org.jboss.as.controller.descriptions.ModelDescriptionConstants.OP_ADDR;
-import static org.jboss.as.controller.descriptions.ModelDescriptionConstants.SUBSYSTEM;
 
 /**
  * @author Lance Ball
@@ -29,18 +28,15 @@ public InfinispanFraction defaultFraction() {
     }
 
     @Override
-    public List<ModelNode> getList(InfinispanFraction fraction) {
+    public List<ModelNode> getList(InfinispanFraction fraction) throws Exception {
         List<ModelNode> list = new ArrayList<>();
 
         ModelNode node = new ModelNode();
         node.get(OP_ADDR).set(EXTENSION, "org.jboss.as.clustering.infinispan");
         node.get(OP).set(ADD);
         list.add(node);
-        try {
-            list.addAll(Marshaller.marshal(fraction));
-        } catch (Exception e) {
-            System.err.println("Cannot configure Infinispan subsystem. " + e);
-        }
+
+        list.addAll(Marshaller.marshal(fraction));
 
         return list;
 

diff --git a/io/runtime/src/main/java/org/wildfly/swarm/io/runtime/IOConfiguration.java b/io/runtime/src/main/java/org/wildfly/swarm/io/runtime/IOConfiguration.java
@@ -28,19 +28,15 @@ public IOFraction defaultFraction() {
     }
 
     @Override
-    public List<ModelNode> getList(IOFraction fraction) {
+    public List<ModelNode> getList(IOFraction fraction) throws Exception {
         List<ModelNode> list = new ArrayList<>();
 
         ModelNode node = new ModelNode();
         node.get(OP_ADDR).set(EXTENSION, "org.wildfly.extension.io");
         node.get(OP).set(ADD);
         list.add(node);
 
-        try {
-            list.addAll(Marshaller.marshal(fraction));
-        } catch (Exception e) {
-            System.err.println("Cannot configure IO subsystem " + e);
-        }
+        list.addAll(Marshaller.marshal(fraction));
 
         return list;
 

diff --git a/jaxrs/runtime/src/main/java/org/wildfly/swarm/jaxrs/runtime/JAXRSConfiguration.java b/jaxrs/runtime/src/main/java/org/wildfly/swarm/jaxrs/runtime/JAXRSConfiguration.java
@@ -1,14 +1,17 @@
 package org.wildfly.swarm.jaxrs.runtime;
 
+import java.util.ArrayList;
+import java.util.List;
+
 import org.jboss.dmr.ModelNode;
 import org.wildfly.swarm.config.runtime.invocation.Marshaller;
 import org.wildfly.swarm.container.runtime.AbstractServerConfiguration;
 import org.wildfly.swarm.jaxrs.JAXRSFraction;
 
-import java.util.ArrayList;
-import java.util.List;
-
-import static org.jboss.as.controller.descriptions.ModelDescriptionConstants.*;
+import static org.jboss.as.controller.descriptions.ModelDescriptionConstants.ADD;
+import static org.jboss.as.controller.descriptions.ModelDescriptionConstants.EXTENSION;
+import static org.jboss.as.controller.descriptions.ModelDescriptionConstants.OP;
+import static org.jboss.as.controller.descriptions.ModelDescriptionConstants.OP_ADDR;
 
 /**
  * @author Bob McWhirter
@@ -25,18 +28,15 @@ public JAXRSFraction defaultFraction() {
     }
 
     @Override
-    public List<ModelNode> getList(JAXRSFraction fraction) {
+    public List<ModelNode> getList(JAXRSFraction fraction) throws Exception {
         List<ModelNode> list = new ArrayList<>();
 
         ModelNode node = new ModelNode();
         node.get(OP_ADDR).set(EXTENSION, "org.jboss.as.jaxrs");
         node.get(OP).set(ADD);
         list.add(node);
-        try {
-            list.addAll(Marshaller.marshal(fraction));
-        } catch (Exception e) {
-            System.err.println("Cannot configure JAXRS. " + e);
-        }
+
+        list.addAll(Marshaller.marshal(fraction));
 
         return list;
 

diff --git a/jca/runtime/src/main/java/org/wildfly/swarm/jca/runtime/JCAConfiguration.java b/jca/runtime/src/main/java/org/wildfly/swarm/jca/runtime/JCAConfiguration.java
@@ -1,13 +1,12 @@
 package org.wildfly.swarm.jca.runtime;
 
+import java.util.List;
+
 import org.jboss.dmr.ModelNode;
 import org.wildfly.swarm.config.runtime.invocation.Marshaller;
 import org.wildfly.swarm.container.runtime.AbstractServerConfiguration;
 import org.wildfly.swarm.jca.JCAFraction;
 
-import java.util.ArrayList;
-import java.util.List;
-
 /**
  * @author Bob McWhirter
  * @author Lance Ball
@@ -24,12 +23,7 @@ public JCAFraction defaultFraction() {
     }
 
     @Override
-    public List<ModelNode> getList(JCAFraction fraction) {
-        try {
-            return Marshaller.marshal(fraction);
-        } catch (Exception e) {
-            System.err.println("Cannot configure JCA subsystem. " + e);
-        }
-        return new ArrayList<>();
+    public List<ModelNode> getList(JCAFraction fraction) throws Exception {
+        return Marshaller.marshal(fraction);
     }
 }
diff --git a/jolokia/runtime/src/main/java/org/wildfly/swarm/jolokia/runtime/JolokiaConfiguration.java b/jolokia/runtime/src/main/java/org/wildfly/swarm/jolokia/runtime/JolokiaConfiguration.java
@@ -21,22 +21,19 @@ public JolokiaConfiguration() {
 
     @Override
     public JolokiaFraction defaultFraction() {
-        System.err.println( "create default fraction for Jolokia" );
+        System.err.println("create default fraction for Jolokia");
         return new JolokiaFraction();
     }
 
     @Override
-    public List<Archive> getImplicitDeployments(JolokiaFraction fraction) {
-        List<Archive> list =new ArrayList<>();
+    public List<Archive> getImplicitDeployments(JolokiaFraction fraction) throws Exception {
+        List<Archive> list = new ArrayList<>();
         JavaArchive war = null;
-        try {
-            war = Swarm.artifact("org.jolokia:jolokia-war:war:*");
-            war.as(WARArchive.class).setContextRoot( fraction.context() );
-            list.add(war);
-        } catch (Exception e) {
-            e.printStackTrace();
-
-        }
+
+        war = Swarm.artifact("org.jolokia:jolokia-war:war:*");
+        war.as(WARArchive.class).setContextRoot(fraction.context());
+        list.add(war);
+
         return list;
     }
 }
diff --git a/jpa/runtime/src/main/java/org/wildfly/swarm/jpa/jpa/JPAConfiguration.java b/jpa/runtime/src/main/java/org/wildfly/swarm/jpa/jpa/JPAConfiguration.java
@@ -1,14 +1,17 @@
 package org.wildfly.swarm.jpa.jpa;
 
+import java.util.ArrayList;
+import java.util.List;
+
 import org.jboss.dmr.ModelNode;
 import org.wildfly.swarm.config.runtime.invocation.Marshaller;
 import org.wildfly.swarm.container.runtime.AbstractServerConfiguration;
 import org.wildfly.swarm.jpa.JPAFraction;
 
-import java.util.ArrayList;
-import java.util.List;
-
-import static org.jboss.as.controller.descriptions.ModelDescriptionConstants.*;
+import static org.jboss.as.controller.descriptions.ModelDescriptionConstants.ADD;
+import static org.jboss.as.controller.descriptions.ModelDescriptionConstants.EXTENSION;
+import static org.jboss.as.controller.descriptions.ModelDescriptionConstants.OP;
+import static org.jboss.as.controller.descriptions.ModelDescriptionConstants.OP_ADDR;
 
 /**
  * @author Ken Finnigan
@@ -26,17 +29,15 @@ public JPAFraction defaultFraction() {
     }
 
     @Override
-    public List<ModelNode> getList(JPAFraction fraction) {
+    public List<ModelNode> getList(JPAFraction fraction) throws Exception {
         List<ModelNode> list = new ArrayList<>();
         ModelNode node = new ModelNode();
         node.get(OP_ADDR).set(EXTENSION, "org.jboss.as.jpa");
         node.get(OP).set(ADD);
         list.add(node);
-        try {
-            list.addAll(Marshaller.marshal(fraction));
-        } catch (Exception e) {
-            System.err.println("Cannot configure JPA subsystem. " + e);
-        }
+
+        list.addAll(Marshaller.marshal(fraction));
+
         return list;
     }
 }