{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":65852069,"defaultBranch":"master","name":"WRF","ownerLogin":"wrf-model","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2016-08-16T20:39:14.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/12666893?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1715890111.0","currentOid":""},"activityList":{"items":[{"before":null,"after":"0a11865f97680fdd6865b278ea29d910e5db3ed7","ref":"refs/heads/release-v4.6.1","pushedAt":"2024-05-16T20:08:31.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"islas","name":"Anthony Islas","path":"/islas","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/128631809?s=80&v=4"},"commit":{"message":"Merge branch 'release-v4.6.0' of github.com:wrf-model/WRF","shortMessageHtmlLink":"Merge branch 'release-v4.6.0' of github.com:wrf-model/WRF"}},{"before":"b7f31dcde42beb4be468edb0541ec02f23b20455","after":"754f0e5a4265018ef61d56ec4e28306537b05d57","ref":"refs/heads/develop","pushedAt":"2024-05-09T01:34:23.000Z","pushType":"push","commitsCount":12,"pusher":{"login":"islas","name":"Anthony Islas","path":"/islas","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/128631809?s=80&v=4"},"commit":{"message":"Merge branch 'master' of github.com:wrf-model/WRF into develop","shortMessageHtmlLink":"Merge branch 'master' of github.com:wrf-model/WRF into develop"}},{"before":"a8eb846859cb39d0acfd1d3297ea9992ce66424a","after":"0a11865f97680fdd6865b278ea29d910e5db3ed7","ref":"refs/heads/master","pushedAt":"2024-05-09T00:53:16.000Z","pushType":"push","commitsCount":89,"pusher":{"login":"islas","name":"Anthony Islas","path":"/islas","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/128631809?s=80&v=4"},"commit":{"message":"Merge branch 'release-v4.6.0' of github.com:wrf-model/WRF","shortMessageHtmlLink":"Merge branch 'release-v4.6.0' of github.com:wrf-model/WRF"}},{"before":"c3a7139ae8ae088ca2c23f19856857b9e2a694f6","after":"b11c63ea97b8a5e565135b68ac7c1701cf4c251d","ref":"refs/heads/release-v4.6.0","pushedAt":"2024-05-08T23:32:03.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"islas","name":"Anthony Islas","path":"/islas","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/128631809?s=80&v=4"},"commit":{"message":"Updating version for v4.6.0 (#2042)\n\nTYPE: text only\r\n\r\nKEYWORDS: v4.6.0, release, version_decl, README\r\n\r\nSOURCE: internal\r\n\r\nDESCRIPTION OF CHANGES:\r\nUpdated the top-level README and inc/version_decl files to reflect V4.6.0, in preparation for the v4.6.0 release\r\n\r\nLIST OF MODIFIED FILES:\r\nM README\r\nM inc/version_decl\r\n\r\nTESTS CONDUCTED:\r\n\r\nNo tests necessary - text only","shortMessageHtmlLink":"Updating version for v4.6.0 (#2042)"}},{"before":"a977865db9a32a73b3bc4c50d29d4db175003f2f","after":"c3a7139ae8ae088ca2c23f19856857b9e2a694f6","ref":"refs/heads/release-v4.6.0","pushedAt":"2024-05-06T23:31:54.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"weiwangncar","name":null,"path":"/weiwangncar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12705680?s=80&v=4"},"commit":{"message":"add texts to make routines exactly the same as in shared-physics (#2041)\n\nTYPE: text only\r\n\r\nKEYWORDS: doxygen comments, shared physics routines\r\n\r\nSOURCE: internal\r\n\r\nDESCRIPTION OF CHANGES:\r\nAdded some doxygen comments to make routines in physics_mmm/ the same as those in future MMM shared physics repository.\r\n\r\nLIST OF MODIFIED FILES:\r\nM phys/physics_mmm/cu_ntiedtke.F90\r\nM phys/physics_mmm/mp_wsm6_effectRad.F90\r\n\r\nTESTS CONDUCTED: \r\nThe Jenkins tests are all passing.","shortMessageHtmlLink":"add texts to make routines exactly the same as in shared-physics (#2041)"}},{"before":"bbc791528f2ed202dc1fdfb8a8105d38bfcb5d2c","after":"a977865db9a32a73b3bc4c50d29d4db175003f2f","ref":"refs/heads/release-v4.6.0","pushedAt":"2024-04-29T16:07:07.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"weiwangncar","name":null,"path":"/weiwangncar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12705680?s=80&v=4"},"commit":{"message":"Remove print max/min w in microphysics driver (#2040)\n\nTYPE: almost text only\r\n\r\nKEYWORDS: extra print, microphysics driver\r\n\r\nSOURCE: internal\r\n\r\nDESCRIPTION OF CHANGES:\r\nProblem:\r\nPR-1876 accidentally turned on a diagnostic print for max and min vertical motions.\r\n\r\nSolution:\r\nThe print is removed as in previous code.\r\n\r\nLIST OF MODIFIED FILES: \r\nM phys/module_microphysics_driver.F\r\n\r\nTESTS CONDUCTED: \r\nThe Jenkins tests are all passing.","shortMessageHtmlLink":"Remove print max/min w in microphysics driver (#2040)"}},{"before":"dbbb563a144deb28fa6e0a85d5586261212cacda","after":"bbc791528f2ed202dc1fdfb8a8105d38bfcb5d2c","ref":"refs/heads/release-v4.6.0","pushedAt":"2024-04-17T15:53:20.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"weiwangncar","name":null,"path":"/weiwangncar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12705680?s=80&v=4"},"commit":{"message":"Correct diffusion coefficients for tke in LES (#2034)\n\nTYPE: bug-fix\r\n\r\nKEYWORDS: Diffusion of tke\r\n\r\nSOURCE: internal (issue raised by Branko Kosovic)\r\n\r\nDESCRIPTION OF CHANGES:\r\nProblem:\r\nReported in #2026 For km_opt=2, tke diffusion should be twice momentum diffusion, but was twice heat diffusion (three times larger). For km_opt=5 it was 3 times momentum diffusion instead of twice.\r\n\r\nSolution:\r\nxkmv and xkmh passed into diffusion routines for tke calls instead of xkhv and xkhh.\r\n\r\nISSUE: For use when this PR closes an issue.\r\nFixes #2026 \r\n\r\nLIST OF MODIFIED FILES: \r\nmodified: dyn_em/module_diffusion_em.F\r\n\r\nTESTS CONDUCTED: \r\n1. LES case was run with shalconv sounding to verify the change.\r\n2. The Jenkins tests are all passing.\r\n\r\nRELEASE NOTE: km_opt=2 and km_opt=5 tke diffusion was reduced to one third its value to match theory.","shortMessageHtmlLink":"Correct diffusion coefficients for tke in LES (#2034)"}},{"before":"30e547cd447660743a9f0cfe06923b2cc92fe08f","after":"dbbb563a144deb28fa6e0a85d5586261212cacda","ref":"refs/heads/release-v4.6.0","pushedAt":"2024-04-16T18:16:02.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"weiwangncar","name":null,"path":"/weiwangncar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12705680?s=80&v=4"},"commit":{"message":"Final bug fixes and tuning for MYNN PBL in v4.6 (#2037)\n\nTYPE: bug fix + tuning\r\n\r\nKEYWORDS: MYNN EDMF\r\n\r\nSOURCE: Joseph Olson (NOAA-GSL)\r\n\r\nDESCRIPTION OF CHANGES:\r\nProblems:\r\n1. overly diminished TKE in stable PBL - always dropping to the lower limit\r\n2. negative mass flux area fractions found (rarely) with activation criteria change from flt to fltv.\r\n3. edmf diagnostics erroneously included rho.\r\n\r\nSolution:\r\n1. retuning of mixing lengths and stability function for momentum - mostly just limit changes.\r\n2. check for mf transfer of heat out of the lowest layer was modified\r\n3. removed rho.\r\n\r\nLIST OF MODIFIED FILES:\r\nphys/module_bl_mynn.F\r\n\r\nTESTS CONDUCTED:\r\n1. Tested in RRFSv1.\r\n2. The Jenkins tests are all passing.\r\n\r\nThis commit contains the final tuning of the MYNN for RRFSv1, and part of the update for 4.6 (together with PR-1938 and 1996).","shortMessageHtmlLink":"Final bug fixes and tuning for MYNN PBL in v4.6 (#2037)"}},{"before":"46dc7401bff616ae7740bd46be144abc28d57244","after":"30e547cd447660743a9f0cfe06923b2cc92fe08f","ref":"refs/heads/release-v4.6.0","pushedAt":"2024-04-12T03:59:17.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"weiwangncar","name":null,"path":"/weiwangncar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12705680?s=80&v=4"},"commit":{"message":"Add PXLSM change from PR-2023 (#2035)\n\nPleim-Xiu LSM MODIS LCZ Compatibility & Surface Evaporation Update\r\n\r\nTYPE: bug fix & physics refinement\r\n\r\nKEYWORDS: MODIS, LCZ, P-X LSM, Latent Heat Flux\r\n\r\nSOURCE: Robert Gilliam & Jon Pleim, US EPA\r\n\r\nDESCRIPTION OF CHANGES:\r\nProblem:\r\n\r\nUser indicated that the P-X LSM errored for MODIS LCZ 61 NUM_LAND_CAT configuration.\r\nCurrently, we account for evaporation from transpiration, soil in both vegetated and non-veg parts, and wet leaves. But we only account for the latent heat effects on Tg from transpiration and evaporation from non-veg soil.\r\nThis fix adds latent heat effects on Tg from soil in vegetated parts and from wet leaves.\r\nFix for rare case where GRDFLX goes NaN because of a divide by zero based on a soil parameter when a water cell turns to sea ice.\r\nSolution:\r\nLogic checks in module_physics_init.F and module_sf_pxlsm.F were adjusted for 61 category inputs. P-X LSM data table, module_sf_pxlsm_data.F was updated for MODIS 61 categories. Default for LCZ 51-61 was set to MODIS urban class. We also added updates for the evaporation from vegetation and wet canopy.\r\n\r\nISSUE:\r\nFixes: #1965\r\n\r\nLIST OF MODIFIED FILES:\r\nM phys/module_physics_init.F\r\nM phys/module_sf_pxlsm.F\r\nM phys/module_sf_pxlsm_data.F\r\n\r\nTESTS CONDUCTED:\r\n\r\n- Tested 61 class LCZ with PX LSM for a 1 day simulation with updated codes. Ran base MODIS 21 class scheme with same code before and after LCZ update. The results were identical after a 24 hour simulation. This confirms updates do not impact other MODIS settings in the P-X LSM. The MODIS 21 was by nature not identical to the MODIS 61, but similar enough and differences follow underlying differences in MODIS datasets.\r\n- The Jenkins tests are all passing.\r\n\r\nRELEASE NOTE:\r\nPleim-Xiu LSM is now compatible with 61 category MODIS LCZ landuse dataset. A mode of latent heat effects on Tg from vegetated parts and from wet leaves is added to Pleim-Xiu LSM.","shortMessageHtmlLink":"Add PXLSM change from PR-2023 (#2035)"}},{"before":"f630b3d7d12bb703161d0605f85ae3974a03ce24","after":"46dc7401bff616ae7740bd46be144abc28d57244","ref":"refs/heads/release-v4.6.0","pushedAt":"2024-04-11T01:47:07.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"weiwangncar","name":null,"path":"/weiwangncar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12705680?s=80&v=4"},"commit":{"message":"Update RUC LSM to the latest version used in version 1 of RRFS. (#2028)\n\nTYPE: bug fix, enhancement\r\n\r\nKEYWORDS: snow model, irrigation, conductivities\r\n\r\nSOURCE: Tanya Smirnova, NOAA/GSL\r\n\r\nDESCRIPTION OF CHANGES:\r\n\r\n1. Changes to the snow model. Added options to compute thermal snow conductivity and snow cover fraction:\r\nisncond_opt = 1 or 2 (1 is default, 2 is recommended to use) isncov_opt = 1, 2 or 3 (1 is default, 2 is recommended to use for more accurate SCF)\r\n2. Changes to irrigation scheme, use real-time vegetation fraction as an indicator of crops maturity.\r\n3. Changes to soil diffusional and hydraulic conductivities.\r\n\r\nLIST OF MODIFIED FILES:\r\nM phys/module_sf_ruclsm.F\r\n\r\nTESTS CONDUCTED:\r\n- Tested in RRFS\r\n- The Jenkins tests are all passing.\r\n\r\nRELEASE NOTE: This PR modifies the RUC LSM to add options to the snow model, use real-time vegetation fraction as an indicator for irrigation scheme, and change soil diffusional and hydraulic conductivities.","shortMessageHtmlLink":"Update RUC LSM to the latest version used in version 1 of RRFS. (#2028)"}},{"before":"0b68af0d7f397ccee9a6402530a6f4927bf8a65f","after":"f630b3d7d12bb703161d0605f85ae3974a03ce24","ref":"refs/heads/release-v4.6.0","pushedAt":"2024-04-02T21:56:23.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"islas","name":"Anthony Islas","path":"/islas","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/128631809?s=80&v=4"},"commit":{"message":"Fix issue with generalized compiler version output using the wrong flags (#2030)\n\nFix issue with generalized compiler version output using the wrong flags\r\n\r\nTYPE: bug fix\r\n\r\nKEYWORDS: compile, version\r\n\r\nSOURCE: internal\r\n\r\nDESCRIPTION OF CHANGES:\r\nProblem:\r\nA generalized compile version check was proposed in #1987. This logic was implemented in #1942 but the originating logic contains a bug where the `-V` and `--version` flag commands' output is flipped.\r\n\r\nSolution:\r\nUse `-V` in the appropriate spot when `$status` is zero for the `-V` check, and respectively for the `--version` check.\r\n\r\nLIST OF MODIFIED FILES: \r\nM compile\r\n\r\nTESTS CONDUCTED: \r\n1. With previous bad logic the compile log output shows a compiler error as the wrong flag is used to output version info. With the fix, the correct output now shows in the compile log.","shortMessageHtmlLink":"Fix issue with generalized compiler version output using the wrong fl…"}},{"before":"9e265af51ddb41cd1993d55289e13a5bcb3ae0c4","after":"b7f31dcde42beb4be468edb0541ec02f23b20455","ref":"refs/heads/develop","pushedAt":"2024-03-27T22:11:32.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"weiwangncar","name":null,"path":"/weiwangncar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12705680?s=80&v=4"},"commit":{"message":"2024 Updates and Bug Fixes for the P-X LSM (#2023)\n\nPleim-Xiu LSM MODIS LCZ Compatibility & Surface Evaporation Update\r\n\r\nTYPE: bug fix & physics refinement\r\n\r\nKEYWORDS: MODIS, LCZ, P-X LSM, Latent Heat Flux\r\n\r\nSOURCE: Robert Gilliam & Jon Pleim, US EPA\r\n\r\nDESCRIPTION OF CHANGES:\r\nProblem:\r\n\r\nUser indicated that the P-X LSM errored for MODIS LCZ 61 NUM_LAND_CAT configuration.\r\nCurrently, we account for evaporation from transpiration, soil in both vegetated and non-veg parts, and wet leaves. But we only account for the latent heat effects on Tg from transpiration and evaporation from non-veg soil.\r\nThis fix adds latent heat effects on Tg from soil in vegetated parts and from wet leaves.\r\nFix for rare case where GRDFLX goes NaN because of a divide by zero based on a soil parameter when a water cell turns to sea ice.\r\nSolution:\r\nLogic checks in module_physics_init.F and module_sf_pxlsm.F were adjusted for 61 category inputs. P-X LSM data table, module_sf_pxlsm_data.F was updated for MODIS 61 categories. Default for LCZ 51-61 was set to MODIS urban class. We also added updates for the evaporation from vegetation and wet canopy.\r\n\r\nISSUE:\r\nFixes: #1965\r\n\r\nLIST OF MODIFIED FILES:\r\nM phys/module_physics_init.F\r\nM phys/module_sf_pxlsm.F\r\nM phys/module_sf_pxlsm_data.F\r\n\r\n- Tested 61 class LCZ with PX LSM for a 1 day simulation with updated codes. Ran base MODIS 21 class scheme with same code before and after LCZ update. The results were identical after a 24 hour simulation. This confirms updates do not impact other MODIS settings in the P-X LSM. The MODIS 21 was by nature not identical to the MODIS 61, but similar enough and differences follow underlying differences in MODIS datasets.\r\n- The Jenkins tests are all passing.\r\n\r\nRELEASE NOTE:\r\nPleim-Xiu LSM is now compatible with 61 category MODIS LCZ landuse dataset. A mode of latent heat effects on Tg from vegetated parts and from wet leaves is added to Pleim-Xiu LSM.","shortMessageHtmlLink":"2024 Updates and Bug Fixes for the P-X LSM (#2023)"}},{"before":"9c09ef9ed4617a7daf0fd03d3556bca7f6b7e604","after":"0b68af0d7f397ccee9a6402530a6f4927bf8a65f","ref":"refs/heads/release-v4.6.0","pushedAt":"2024-03-27T22:03:46.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"weiwangncar","name":null,"path":"/weiwangncar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12705680?s=80&v=4"},"commit":{"message":"correct the logic to use specific humidity or mixing ratio directly (#2031)\n\nTYPE: bug fix\r\n\r\nKEYWORDS: real, use_sh_qv\r\n\r\nSOURCE: internal\r\n\r\nDESCRIPTION OF CHANGES:\r\nThe logic to control whether specific humidity or mixing ratio is used instead of RH is wrong (PR-1959) when either SH or Qv is available. It is corrected in this PR.\r\n\r\nLIST OF MODIFIED FILES:\r\nM dyn_em/module_initialize_real.F\r\n\r\nTESTS CONDUCTED:\r\n\r\nTested before and after this change. The data without SH is not affected, and the data with SH (EC model level data) is now used directly if use_sh_qv is set to true.\r\nThe Jenkins tests are all passing.","shortMessageHtmlLink":"correct the logic to use specific humidity or mixing ratio directly (#…"}},{"before":"9e265af51ddb41cd1993d55289e13a5bcb3ae0c4","after":"9c09ef9ed4617a7daf0fd03d3556bca7f6b7e604","ref":"refs/heads/release-v4.6.0","pushedAt":"2024-03-26T22:11:54.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"weiwangncar","name":null,"path":"/weiwangncar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12705680?s=80&v=4"},"commit":{"message":"remove unneeded depends (#2029)\n\nTYPE: bug fix, clean up\r\n\r\nKEYWORDS: dependencies, unused\r\n\r\nSOURCE: internal\r\n\r\nDESCRIPTION OF CHANGES:\r\nProblem:\r\nSome dependency is declared twice, some are no longer needed.\r\n\r\nSolution:\r\nRemove un-used dependencies. Complimentary to PR-1950.\r\n\r\nLIST OF MODIFIED FILES: \r\nM main/depend.common\r\n\r\nTESTS CONDUCTED: \r\n1. Tested on Derecho with 6 proc to compile\r\n2. The Jenkins tests are all passing.","shortMessageHtmlLink":"remove unneeded depends (#2029)"}},{"before":null,"after":"9e265af51ddb41cd1993d55289e13a5bcb3ae0c4","ref":"refs/heads/release-v4.6.0","pushedAt":"2024-03-15T23:09:32.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"islas","name":"Anthony Islas","path":"/islas","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/128631809?s=80&v=4"},"commit":{"message":"Hydro CMake and Updates (#2009)\n\nTYPE: new feature, bug fixes, enhancement\r\n\r\nKEYWORDS: CMake, Build System, Hydro\r\n\r\nSOURCE: Soren Rasmussen and Ryan Cabell, NCAR\r\n\r\nDESCRIPTION OF CHANGES:\r\n- Build Systems:\r\n - CMake build system added and renaming .F and .f90 files to .F90 so they automatically get preprocessed and the editor recognizes them as free-form\r\n - added compiler info to all netcdf output files\r\n - Alma support added\r\n - Cray compiler fixes:\r\n - Removes comma after write statement and changes A*-B*C statements to A*(-B)*C\r\n - Use assumed shape / volatile arrays with ext libs - Replace timestep multiple check with mod operator\r\n - Update CMake with proper MPI and PGI/NVHPC support\r\n\r\n- General:\r\n - whitespace cleanup\r\n\r\n- MPI\r\n - Optimized inefficient MPI routines. Converted MPP_LAND p2p MPI to collectives, Remove unneeded mpp_land_sync() calls\r\n\r\n- Routing changes\r\n - Add scrape of outer edge of domain so water doesn't pile up\r\n - Remove 'FATAL ERROR' from SMCRT depletion message\r\n - Add to retro IO option (NWM)\r\n - routing bugfix: removed CHANN_K from debug print statement. The variable is unitialized and can change values every time executable is run.\r\n - bugfix: unallocated variables\r\n\r\n- Nudging\r\n - Update nudging_io to NF90 API\r\n - Since NetCDF subroutines have been converted to nf90 we can remove the 'include netcdf.inc' statements\r\n\r\n- Config\r\n - config debug: fixes in read_crocus_namelist subroutine\r\n\r\n\r\nTESTS CONDUCTED: \r\n1. Currently testing hydro's WRF testcase on new CMake and old Makefile build systems. PR will be draft until fully tested.\r\n\r\nRELEASE NOTE: Hydro has added CMake build option. General bug fixes and code cleanup. MPI routine made more efficient. All hydro file suffixes are now `.F90`.\r\n\r\nLIST OF MODIFIED FILES:\r\n\r\n```\r\nM CMakeLists.txt\r\nA hydro/CMakeLists.txt\r\nM hydro/CPL/WRF_cpl/Makefile\r\nR094 hydro/CPL/WRF_cpl/module_wrf_HYDRO.F hydro/CPL/WRF_cpl/module_wrf_HYDRO.F90\r\nR096 hydro/CPL/WRF_cpl/module_wrf_HYDRO_downscale.F hydro/CPL/WRF_cpl/module_wrf_HYDRO_downscale.F90\r\nR093 hydro/CPL/WRF_cpl/wrf_drv_HYDRO.F hydro/CPL/WRF_cpl/wrf_drv_HYDRO.F90\r\nA hydro/Data_Rec/CMakeLists.txt\r\nM hydro/Data_Rec/Makefile\r\nD hydro/Data_Rec/module_RT_data.F\r\nR069 hydro/Data_Rec/module_gw_gw2d_data.F hydro/Data_Rec/module_RT_data.F90\r\nA hydro/Data_Rec/module_gw_gw2d_data.F90\r\nR099 hydro/Data_Rec/module_namelist.F hydro/Data_Rec/module_namelist.F90\r\nA hydro/Data_Rec/module_namelist_inc.F90\r\nA hydro/Data_Rec/module_rt_inc.F90\r\nA hydro/Debug_Utilities/CMakeLists.txt\r\nM hydro/Debug_Utilities/Makefile\r\nR100 hydro/Debug_Utilities/debug_dump_variable.F hydro/Debug_Utilities/debug_dump_variable.F90\r\nA hydro/HYDRO_drv/CMakeLists.txt\r\nM hydro/HYDRO_drv/Makefile\r\nR099 hydro/HYDRO_drv/module_HYDRO_drv.F hydro/HYDRO_drv/module_HYDRO_drv.F90\r\nA hydro/IO/CMakeLists.txt\r\nM hydro/IO/Makefile\r\nR100 hydro/IO/netcdf_layer.f90 hydro/IO/netcdf_layer.F90\r\nA hydro/MPP/CMakeLists.txt\r\nR094 hydro/MPP/CPL_WRF.F hydro/MPP/CPL_WRF.F90\r\nM hydro/MPP/Makefile\r\nR099 hydro/MPP/hashtable.F hydro/MPP/hashtable.F90\r\nR100 hydro/MPP/module_mpp_GWBUCKET.F hydro/MPP/module_mpp_GWBUCKET.F90\r\nR100 hydro/MPP/module_mpp_ReachLS.F hydro/MPP/module_mpp_ReachLS.F90\r\nD hydro/MPP/mpp_land.F\r\nA hydro/MPP/mpp_land.F90\r\nA hydro/OrchestratorLayer/CMakeLists.txt\r\nM hydro/OrchestratorLayer/Makefile\r\nR099 hydro/OrchestratorLayer/config.f90 hydro/OrchestratorLayer/config.F90\r\nR098 hydro/OrchestratorLayer/io_manager.f90 hydro/OrchestratorLayer/io_manager.F90\r\nR094 hydro/OrchestratorLayer/orchestrator.f90 hydro/OrchestratorLayer/orchestrator.F90\r\nA hydro/Routing/CMakeLists.txt\r\nM hydro/Routing/Makefile\r\nR099 hydro/Routing/Noah_distr_routing.F hydro/Routing/Noah_distr_routing.F90\r\nR100 hydro/Routing/Noah_distr_routing_overland.F hydro/Routing/Noah_distr_routing_overland.F90\r\nR100 hydro/Routing/Noah_distr_routing_subsurface.F hydro/Routing/Noah_distr_routing_subsurface.F90\r\nA hydro/Routing/Overland/CMakeLists.txt\r\nM hydro/Routing/Overland/Makefile\r\nR099 hydro/Routing/Noah_distr_routing.F hydro/Routing/Noah_distr_routing.F90\r\nR100 hydro/Routing/Noah_distr_routing_overland.F hydro/Routing/Noah_distr_routing_overland.F90\r\nR100 hydro/Routing/Noah_distr_routing_subsurface.F hydro/Routing/Noah_distr_routing_subsurface.F90\r\nA hydro/Routing/Overland/CMakeLists.txt\r\nM hydro/Routing/Overland/Makefile\r\nR100 hydro/Routing/Overland/module_overland.F hydro/Routing/Overland/module_overland.F90\r\nR100 hydro/Routing/Overland/module_overland_control.F hydro/Routing/Overland/module_overland_control.F90\r\nR098 hydro/Routing/Overland/module_overland_mass_balance.F hydro/Routing/Overland/module_overland_mass_balance.F90\r\nR100 hydro/Routing/Overland/module_overland_routing_properties.F hydro/Routing/Overland/module_overland_routing_properties.F90\r\nR100 hydro/Routing/Overland/module_overland_streams_and_lakes.F hydro/Routing/Overland/module_overland_streams_and_lakes.F90\r\nR100 hydro/Routing/Overland/overland_tests.F hydro/Routing/Overland/overland_tests.F90\r\nA hydro/Routing/Reservoirs/CMakeLists.txt\r\nA hydro/Routing/Reservoirs/Level_Pool/CMakeLists.txt\r\nM hydro/Routing/Reservoirs/Level_Pool/Makefile\r\nR100 hydro/Routing/Reservoirs/Level_Pool/module_levelpool.F hydro/Routing/Reservoirs/Level_Pool/module_levelpool.F90\r\nR100 hydro/Routing/Reservoirs/Level_Pool/module_levelpool_properties.F hydro/Routing/Reservoirs/Level_Pool/module_levelpool_properties.F90\r\nR100 hydro/Routing/Reservoirs/Level_Pool/module_levelpool_state.F hydro/Routing/Reservoirs/Level_Pool/module_levelpool_state.F90\r\nR100 hydro/Routing/Reservoirs/Level_Pool/module_levelpool_tests.F hydro/Routing/Reservoirs/Level_Pool/module_levelpool_tests.F90\r\nM hydro/Routing/Reservoirs/Makefile\r\nA hydro/Routing/Reservoirs/Persistence_Level_Pool_Hybrid/CMakeLists.txt\r\nM hydro/Routing/Reservoirs/Persistence_Level_Pool_Hybrid/Makefile\r\nR100 hydro/Routing/Reservoirs/Persistence_Level_Pool_Hybrid/module_persistence_levelpool_hybrid.F hydro/Routing/Reservoirs/Persistence_Level_Pool_Hybrid/module_persisten\\\r\nce_levelpool_hybrid.F90\r\nR100 hydro/Routing/Reservoirs/Persistence_Level_Pool_Hybrid/module_persistence_levelpool_hybrid_properties.F hydro/Routing/Reservoirs/Persistence_Level_Pool_Hybrid/module_p\\\r\nersistence_levelpool_hybrid_properties.F90\r\nR100 hydro/Routing/Reservoirs/Persistence_Level_Pool_Hybrid/module_persistence_levelpool_hybrid_state.F hydro/Routing/Reservoirs/Persistence_Level_Pool_Hybrid/module_p\\\r\nersistence_levelpool_hybrid_state.F90\r\nR100 hydro/Routing/Reservoirs/Persistence_Level_Pool_Hybrid/module_persistence_levelpool_hybrid_tests.F hydro/Routing/Reservoirs/Persistence_Level_Pool_Hybrid/module_p\\\r\nersistence_levelpool_hybrid_tests.F90\r\nA hydro/Routing/Reservoirs/RFC_Forecasts/CMakeLists.txt\r\nM hydro/Routing/Reservoirs/RFC_Forecasts/Makefile\r\nR100 hydro/Routing/Reservoirs/RFC_Forecasts/module_rfc_forecasts.F hydro/Routing/Reservoirs/RFC_Forecasts/module_rfc_forecasts.F90\r\nR100 hydro/Routing/Reservoirs/RFC_Forecasts/module_rfc_forecasts_properties.F hydro/Routing/Reservoirs/RFC_Forecasts/module_rfc_forecasts_properties.F90\r\nR100 hydro/Routing/Reservoirs/RFC_Forecasts/module_rfc_forecasts_state.F hydro/Routing/Reservoirs/RFC_Forecasts/module_rfc_forecasts_state.F90\r\nR100 hydro/Routing/Reservoirs/RFC_Forecasts/module_rfc_forecasts_tests.F hydro/Routing/Reservoirs/RFC_Forecasts/module_rfc_forecasts_tests.F90\r\nR100 hydro/Routing/Reservoirs/module_reservoir.F hydro/Routing/Reservoirs/module_reservoir.F90\r\nR100 hydro/Routing/Reservoirs/module_reservoir_read_rfc_time_series_data.F hydro/Routing/Reservoirs/module_reservoir_read_rfc_time_series_data.F90\r\nR100 hydro/Routing/Reservoirs/module_reservoir_read_timeslice_data.F hydro/Routing/Reservoirs/module_reservoir_read_timeslice_data.F90\r\nR100 hydro/Routing/Reservoirs/module_reservoir_utilities.F hydro/Routing/Reservoirs/module_reservoir_utilities.F90\r\nR100 hydro/Routing/Reservoirs/reservoir_tests.F hydro/Routing/Reservoirs/reservoir_tests.F90\r\nA hydro/Routing/Subsurface/CMakeLists.txt\r\nM hydro/Routing/Subsurface/Makefile\r\nR100 hydro/Routing/Subsurface/module_subsurface.F hydro/Routing/Subsurface/module_subsurface.F90\r\nR100 hydro/Routing/Subsurface/module_subsurface_grid_transform.F hydro/Routing/Subsurface/module_subsurface_grid_transform.F90\r\nR100 hydro/Routing/Subsurface/module_subsurface_input.F hydro/Routing/Subsurface/module_subsurface_input.F90\r\nR100 hydro/Routing/Subsurface/module_subsurface_output.F hydro/Routing/Subsurface/module_subsurface_output.F90\r\nR100 hydro/Routing/Subsurface/module_subsurface_properties.F hydro/Routing/Subsurface/module_subsurface_properties.F90\r\nR100 hydro/Routing/Subsurface/module_subsurface_state.F hydro/Routing/Subsurface/module_subsurface_state.F90\r\nR098 hydro/Routing/Subsurface/module_subsurface_static_data.F hydro/Routing/Subsurface/module_subsurface_static_data.F90\r\nR100 hydro/Routing/Subsurface/subsurface_tests.F hydro/Routing/Subsurface/subsurface_tests.F90\r\nR097 hydro/Routing/module_GW_baseflow.F hydro/Routing/module_GW_baseflow.F90\r\nR099 hydro/Routing/module_HYDRO_io.F hydro/Routing/module_HYDRO_io.F90\r\nR088 hydro/Routing/module_HYDRO_utils.F hydro/Routing/module_HYDRO_utils.F90\r\nR098 hydro/Routing/module_NWM_io.F hydro/Routing/module_NWM_io.F90\r\nR099 hydro/Routing/module_NWM_io_dict.F hydro/Routing/module_NWM_io_dict.F90\r\nR100 hydro/Routing/module_RT.F hydro/Routing/module_RT.F90\r\nR094 hydro/Routing/module_UDMAP.F hydro/Routing/module_UDMAP.F90\r\nR099 hydro/Routing/module_channel_routing.F hydro/Routing/module_channel_routing.F90\r\nR100 hydro/Routing/module_date_utilities_rt.F hydro/Routing/module_date_utilities_rt.F90\r\nR097 hydro/Routing/module_gw_gw2d.F hydro/Routing/module_gw_gw2d.F90\r\nR099 hydro/Routing/module_lsm_forcing.F hydro/Routing/module_lsm_forcing.F90\r\nR093 hydro/Routing/module_noah_chan_param_init_rt.F hydro/Routing/module_noah_chan_param_init_rt.F90\r\nR099 hydro/Routing/module_reservoir_routing.F hydro/Routing/module_reservoir_routing.F90\r\nM hydro/arc/Makefile.NoahMP\r\nA hydro/nudging/CMakeLists.txt\r\nM hydro/nudging/Makefile\r\nR100 hydro/nudging/module_date_utils_nudging.F hydro/nudging/module_date_utils_nudging.F90\r\nR090 hydro/nudging/module_nudging_io.F hydro/nudging/module_nudging_io.F90\r\nR085 hydro/nudging/module_nudging_utils.F hydro/nudging/module_nudging_utils.F90\r\nR100 hydro/nudging/module_stream_nudging.F hydro/nudging/module_stream_nudging.F90\r\nA hydro/utils/CMakeLists.txt\r\nM hydro/utils/Makefile\r\nR100 hydro/utils/module_hydro_stop.F hydro/utils/module_hydro_stop.F90\r\nR100 hydro/utils/module_version.F hydro/utils/module_version.F90\r\n```","shortMessageHtmlLink":"Hydro CMake and Updates (#2009)"}},{"before":"01228e7dfc0c4c257a7511e028088eddf3dfb388","after":"9e265af51ddb41cd1993d55289e13a5bcb3ae0c4","ref":"refs/heads/develop","pushedAt":"2024-03-15T21:10:23.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"islas","name":"Anthony Islas","path":"/islas","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/128631809?s=80&v=4"},"commit":{"message":"Hydro CMake and Updates (#2009)\n\nTYPE: new feature, bug fixes, enhancement\r\n\r\nKEYWORDS: CMake, Build System, Hydro\r\n\r\nSOURCE: Soren Rasmussen and Ryan Cabell, NCAR\r\n\r\nDESCRIPTION OF CHANGES:\r\n- Build Systems:\r\n - CMake build system added and renaming .F and .f90 files to .F90 so they automatically get preprocessed and the editor recognizes them as free-form\r\n - added compiler info to all netcdf output files\r\n - Alma support added\r\n - Cray compiler fixes:\r\n - Removes comma after write statement and changes A*-B*C statements to A*(-B)*C\r\n - Use assumed shape / volatile arrays with ext libs - Replace timestep multiple check with mod operator\r\n - Update CMake with proper MPI and PGI/NVHPC support\r\n\r\n- General:\r\n - whitespace cleanup\r\n\r\n- MPI\r\n - Optimized inefficient MPI routines. Converted MPP_LAND p2p MPI to collectives, Remove unneeded mpp_land_sync() calls\r\n\r\n- Routing changes\r\n - Add scrape of outer edge of domain so water doesn't pile up\r\n - Remove 'FATAL ERROR' from SMCRT depletion message\r\n - Add to retro IO option (NWM)\r\n - routing bugfix: removed CHANN_K from debug print statement. The variable is unitialized and can change values every time executable is run.\r\n - bugfix: unallocated variables\r\n\r\n- Nudging\r\n - Update nudging_io to NF90 API\r\n - Since NetCDF subroutines have been converted to nf90 we can remove the 'include netcdf.inc' statements\r\n\r\n- Config\r\n - config debug: fixes in read_crocus_namelist subroutine\r\n\r\n\r\nTESTS CONDUCTED: \r\n1. Currently testing hydro's WRF testcase on new CMake and old Makefile build systems. PR will be draft until fully tested.\r\n\r\nRELEASE NOTE: Hydro has added CMake build option. General bug fixes and code cleanup. MPI routine made more efficient. All hydro file suffixes are now `.F90`.\r\n\r\nLIST OF MODIFIED FILES:\r\n\r\n```\r\nM CMakeLists.txt\r\nA hydro/CMakeLists.txt\r\nM hydro/CPL/WRF_cpl/Makefile\r\nR094 hydro/CPL/WRF_cpl/module_wrf_HYDRO.F hydro/CPL/WRF_cpl/module_wrf_HYDRO.F90\r\nR096 hydro/CPL/WRF_cpl/module_wrf_HYDRO_downscale.F hydro/CPL/WRF_cpl/module_wrf_HYDRO_downscale.F90\r\nR093 hydro/CPL/WRF_cpl/wrf_drv_HYDRO.F hydro/CPL/WRF_cpl/wrf_drv_HYDRO.F90\r\nA hydro/Data_Rec/CMakeLists.txt\r\nM hydro/Data_Rec/Makefile\r\nD hydro/Data_Rec/module_RT_data.F\r\nR069 hydro/Data_Rec/module_gw_gw2d_data.F hydro/Data_Rec/module_RT_data.F90\r\nA hydro/Data_Rec/module_gw_gw2d_data.F90\r\nR099 hydro/Data_Rec/module_namelist.F hydro/Data_Rec/module_namelist.F90\r\nA hydro/Data_Rec/module_namelist_inc.F90\r\nA hydro/Data_Rec/module_rt_inc.F90\r\nA hydro/Debug_Utilities/CMakeLists.txt\r\nM hydro/Debug_Utilities/Makefile\r\nR100 hydro/Debug_Utilities/debug_dump_variable.F hydro/Debug_Utilities/debug_dump_variable.F90\r\nA hydro/HYDRO_drv/CMakeLists.txt\r\nM hydro/HYDRO_drv/Makefile\r\nR099 hydro/HYDRO_drv/module_HYDRO_drv.F hydro/HYDRO_drv/module_HYDRO_drv.F90\r\nA hydro/IO/CMakeLists.txt\r\nM hydro/IO/Makefile\r\nR100 hydro/IO/netcdf_layer.f90 hydro/IO/netcdf_layer.F90\r\nA hydro/MPP/CMakeLists.txt\r\nR094 hydro/MPP/CPL_WRF.F hydro/MPP/CPL_WRF.F90\r\nM hydro/MPP/Makefile\r\nR099 hydro/MPP/hashtable.F hydro/MPP/hashtable.F90\r\nR100 hydro/MPP/module_mpp_GWBUCKET.F hydro/MPP/module_mpp_GWBUCKET.F90\r\nR100 hydro/MPP/module_mpp_ReachLS.F hydro/MPP/module_mpp_ReachLS.F90\r\nD hydro/MPP/mpp_land.F\r\nA hydro/MPP/mpp_land.F90\r\nA hydro/OrchestratorLayer/CMakeLists.txt\r\nM hydro/OrchestratorLayer/Makefile\r\nR099 hydro/OrchestratorLayer/config.f90 hydro/OrchestratorLayer/config.F90\r\nR098 hydro/OrchestratorLayer/io_manager.f90 hydro/OrchestratorLayer/io_manager.F90\r\nR094 hydro/OrchestratorLayer/orchestrator.f90 hydro/OrchestratorLayer/orchestrator.F90\r\nA hydro/Routing/CMakeLists.txt\r\nM hydro/Routing/Makefile\r\nR099 hydro/Routing/Noah_distr_routing.F hydro/Routing/Noah_distr_routing.F90\r\nR100 hydro/Routing/Noah_distr_routing_overland.F hydro/Routing/Noah_distr_routing_overland.F90\r\nR100 hydro/Routing/Noah_distr_routing_subsurface.F hydro/Routing/Noah_distr_routing_subsurface.F90\r\nA hydro/Routing/Overland/CMakeLists.txt\r\nM hydro/Routing/Overland/Makefile\r\nR099 hydro/Routing/Noah_distr_routing.F hydro/Routing/Noah_distr_routing.F90\r\nR100 hydro/Routing/Noah_distr_routing_overland.F hydro/Routing/Noah_distr_routing_overland.F90\r\nR100 hydro/Routing/Noah_distr_routing_subsurface.F hydro/Routing/Noah_distr_routing_subsurface.F90\r\nA hydro/Routing/Overland/CMakeLists.txt\r\nM hydro/Routing/Overland/Makefile\r\nR100 hydro/Routing/Overland/module_overland.F hydro/Routing/Overland/module_overland.F90\r\nR100 hydro/Routing/Overland/module_overland_control.F hydro/Routing/Overland/module_overland_control.F90\r\nR098 hydro/Routing/Overland/module_overland_mass_balance.F hydro/Routing/Overland/module_overland_mass_balance.F90\r\nR100 hydro/Routing/Overland/module_overland_routing_properties.F hydro/Routing/Overland/module_overland_routing_properties.F90\r\nR100 hydro/Routing/Overland/module_overland_streams_and_lakes.F hydro/Routing/Overland/module_overland_streams_and_lakes.F90\r\nR100 hydro/Routing/Overland/overland_tests.F hydro/Routing/Overland/overland_tests.F90\r\nA hydro/Routing/Reservoirs/CMakeLists.txt\r\nA hydro/Routing/Reservoirs/Level_Pool/CMakeLists.txt\r\nM hydro/Routing/Reservoirs/Level_Pool/Makefile\r\nR100 hydro/Routing/Reservoirs/Level_Pool/module_levelpool.F hydro/Routing/Reservoirs/Level_Pool/module_levelpool.F90\r\nR100 hydro/Routing/Reservoirs/Level_Pool/module_levelpool_properties.F hydro/Routing/Reservoirs/Level_Pool/module_levelpool_properties.F90\r\nR100 hydro/Routing/Reservoirs/Level_Pool/module_levelpool_state.F hydro/Routing/Reservoirs/Level_Pool/module_levelpool_state.F90\r\nR100 hydro/Routing/Reservoirs/Level_Pool/module_levelpool_tests.F hydro/Routing/Reservoirs/Level_Pool/module_levelpool_tests.F90\r\nM hydro/Routing/Reservoirs/Makefile\r\nA hydro/Routing/Reservoirs/Persistence_Level_Pool_Hybrid/CMakeLists.txt\r\nM hydro/Routing/Reservoirs/Persistence_Level_Pool_Hybrid/Makefile\r\nR100 hydro/Routing/Reservoirs/Persistence_Level_Pool_Hybrid/module_persistence_levelpool_hybrid.F hydro/Routing/Reservoirs/Persistence_Level_Pool_Hybrid/module_persisten\\\r\nce_levelpool_hybrid.F90\r\nR100 hydro/Routing/Reservoirs/Persistence_Level_Pool_Hybrid/module_persistence_levelpool_hybrid_properties.F hydro/Routing/Reservoirs/Persistence_Level_Pool_Hybrid/module_p\\\r\nersistence_levelpool_hybrid_properties.F90\r\nR100 hydro/Routing/Reservoirs/Persistence_Level_Pool_Hybrid/module_persistence_levelpool_hybrid_state.F hydro/Routing/Reservoirs/Persistence_Level_Pool_Hybrid/module_p\\\r\nersistence_levelpool_hybrid_state.F90\r\nR100 hydro/Routing/Reservoirs/Persistence_Level_Pool_Hybrid/module_persistence_levelpool_hybrid_tests.F hydro/Routing/Reservoirs/Persistence_Level_Pool_Hybrid/module_p\\\r\nersistence_levelpool_hybrid_tests.F90\r\nA hydro/Routing/Reservoirs/RFC_Forecasts/CMakeLists.txt\r\nM hydro/Routing/Reservoirs/RFC_Forecasts/Makefile\r\nR100 hydro/Routing/Reservoirs/RFC_Forecasts/module_rfc_forecasts.F hydro/Routing/Reservoirs/RFC_Forecasts/module_rfc_forecasts.F90\r\nR100 hydro/Routing/Reservoirs/RFC_Forecasts/module_rfc_forecasts_properties.F hydro/Routing/Reservoirs/RFC_Forecasts/module_rfc_forecasts_properties.F90\r\nR100 hydro/Routing/Reservoirs/RFC_Forecasts/module_rfc_forecasts_state.F hydro/Routing/Reservoirs/RFC_Forecasts/module_rfc_forecasts_state.F90\r\nR100 hydro/Routing/Reservoirs/RFC_Forecasts/module_rfc_forecasts_tests.F hydro/Routing/Reservoirs/RFC_Forecasts/module_rfc_forecasts_tests.F90\r\nR100 hydro/Routing/Reservoirs/module_reservoir.F hydro/Routing/Reservoirs/module_reservoir.F90\r\nR100 hydro/Routing/Reservoirs/module_reservoir_read_rfc_time_series_data.F hydro/Routing/Reservoirs/module_reservoir_read_rfc_time_series_data.F90\r\nR100 hydro/Routing/Reservoirs/module_reservoir_read_timeslice_data.F hydro/Routing/Reservoirs/module_reservoir_read_timeslice_data.F90\r\nR100 hydro/Routing/Reservoirs/module_reservoir_utilities.F hydro/Routing/Reservoirs/module_reservoir_utilities.F90\r\nR100 hydro/Routing/Reservoirs/reservoir_tests.F hydro/Routing/Reservoirs/reservoir_tests.F90\r\nA hydro/Routing/Subsurface/CMakeLists.txt\r\nM hydro/Routing/Subsurface/Makefile\r\nR100 hydro/Routing/Subsurface/module_subsurface.F hydro/Routing/Subsurface/module_subsurface.F90\r\nR100 hydro/Routing/Subsurface/module_subsurface_grid_transform.F hydro/Routing/Subsurface/module_subsurface_grid_transform.F90\r\nR100 hydro/Routing/Subsurface/module_subsurface_input.F hydro/Routing/Subsurface/module_subsurface_input.F90\r\nR100 hydro/Routing/Subsurface/module_subsurface_output.F hydro/Routing/Subsurface/module_subsurface_output.F90\r\nR100 hydro/Routing/Subsurface/module_subsurface_properties.F hydro/Routing/Subsurface/module_subsurface_properties.F90\r\nR100 hydro/Routing/Subsurface/module_subsurface_state.F hydro/Routing/Subsurface/module_subsurface_state.F90\r\nR098 hydro/Routing/Subsurface/module_subsurface_static_data.F hydro/Routing/Subsurface/module_subsurface_static_data.F90\r\nR100 hydro/Routing/Subsurface/subsurface_tests.F hydro/Routing/Subsurface/subsurface_tests.F90\r\nR097 hydro/Routing/module_GW_baseflow.F hydro/Routing/module_GW_baseflow.F90\r\nR099 hydro/Routing/module_HYDRO_io.F hydro/Routing/module_HYDRO_io.F90\r\nR088 hydro/Routing/module_HYDRO_utils.F hydro/Routing/module_HYDRO_utils.F90\r\nR098 hydro/Routing/module_NWM_io.F hydro/Routing/module_NWM_io.F90\r\nR099 hydro/Routing/module_NWM_io_dict.F hydro/Routing/module_NWM_io_dict.F90\r\nR100 hydro/Routing/module_RT.F hydro/Routing/module_RT.F90\r\nR094 hydro/Routing/module_UDMAP.F hydro/Routing/module_UDMAP.F90\r\nR099 hydro/Routing/module_channel_routing.F hydro/Routing/module_channel_routing.F90\r\nR100 hydro/Routing/module_date_utilities_rt.F hydro/Routing/module_date_utilities_rt.F90\r\nR097 hydro/Routing/module_gw_gw2d.F hydro/Routing/module_gw_gw2d.F90\r\nR099 hydro/Routing/module_lsm_forcing.F hydro/Routing/module_lsm_forcing.F90\r\nR093 hydro/Routing/module_noah_chan_param_init_rt.F hydro/Routing/module_noah_chan_param_init_rt.F90\r\nR099 hydro/Routing/module_reservoir_routing.F hydro/Routing/module_reservoir_routing.F90\r\nM hydro/arc/Makefile.NoahMP\r\nA hydro/nudging/CMakeLists.txt\r\nM hydro/nudging/Makefile\r\nR100 hydro/nudging/module_date_utils_nudging.F hydro/nudging/module_date_utils_nudging.F90\r\nR090 hydro/nudging/module_nudging_io.F hydro/nudging/module_nudging_io.F90\r\nR085 hydro/nudging/module_nudging_utils.F hydro/nudging/module_nudging_utils.F90\r\nR100 hydro/nudging/module_stream_nudging.F hydro/nudging/module_stream_nudging.F90\r\nA hydro/utils/CMakeLists.txt\r\nM hydro/utils/Makefile\r\nR100 hydro/utils/module_hydro_stop.F hydro/utils/module_hydro_stop.F90\r\nR100 hydro/utils/module_version.F hydro/utils/module_version.F90\r\n```","shortMessageHtmlLink":"Hydro CMake and Updates (#2009)"}},{"before":"95eb02c21e0493e1311208a7fe5f1db8b78e9244","after":"01228e7dfc0c4c257a7511e028088eddf3dfb388","ref":"refs/heads/develop","pushedAt":"2024-03-15T17:54:11.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"weiwangncar","name":null,"path":"/weiwangncar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12705680?s=80&v=4"},"commit":{"message":"The net longwave flux absorbed by the building wall, RB2, in module_sf_urban.F is underestimating the value by a factor of emissivty of the wall, EPSG, as it is multiplied twice. I corrected the equation in the aforementioned module. (#2016)\n\nTYPE: Bug fix\r\n\r\nKEYWORDS: Longwave flux, radiation/energy balance, Surface temperature, Urban climate, SLUCM\r\n\r\nSOURCE: Parag Joshi (Brookhaven National Lab), Katia Lamer (Brookhaven National Lab)\r\n\r\nDESCRIPTION OF CHANGES:\r\nProblem:\r\nThe net long wave fluxes absorbed by the building walls is being underestimated due to multiplication of the emissivity twice in the equation. The command/lines that evaluate RB2 in the module_sf_urban.F (Lines 1300 and 1419 of WRF version-4.5.2) reflect the net long wave fluxes absorbed by building walls.\r\n\r\nSolution:\r\nThe code has been corrected by referring to the equation A9 of in the article, Kusaka & Kimora 2004, Journal of Applied Meteorology.\r\n\r\nISSUE: For use when this PR closes an issue.\r\nFixes #2011\r\n\r\nLIST OF MODIFIED FILES: \r\nM module_sf_urban.F\r\n\r\nTESTS CONDUCTED:\r\n1. Tests were conducted by the LSM group at NCAR/RAL.\r\n2. It passed Jenkins tests.\r\n\r\nRELEASE NOTE: Correcting the net long wave fluxes for application in modeling urban climate using Single Layer Urban Canopy Model (SLUCM). It slightly improved 2-m temperature in urban area.","shortMessageHtmlLink":"The net longwave flux absorbed by the building wall, RB2, in module_s…"}},{"before":"e1ebb1052d433093a0395337ef1465d336545c25","after":"95eb02c21e0493e1311208a7fe5f1db8b78e9244","ref":"refs/heads/develop","pushedAt":"2024-02-28T21:43:02.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"weiwangncar","name":null,"path":"/weiwangncar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12705680?s=80&v=4"},"commit":{"message":"Add prints for parameters used in auto_levels_opt = 2 in real.exe (#2015)\n\nTYPE: enhancement\r\n\r\nKEYWORDS: auto_levels_opt, dzbot, dzstretch\r\n\r\nSOURCE: internal\r\n\r\nDESCRIPTION OF CHANGES:\r\nProblem:\r\nLack of information in the standard output when running real.exe using auto_levels_opt = 2.\r\n\r\nSolution:\r\nAdds print for parameters used to define vertical levels.\r\n\r\nLIST OF MODIFIED FILES: \r\nM dyn_em/module_initialize_real.F\r\n\r\nTESTS CONDUCTED: \r\n1. Now print like the following is added to output from running real.exe:\r\n p_top = 1000. Pa, dzbot = 30.0 m, dzstretch_s/u = 1.20 1.02\r\n2. The Jenkins tests are all passing.\r\n\r\nRELEASE NOTE: This PR adds a print for parameters used when running real.exe using auto_levels_opt = 2 option, which is the default.","shortMessageHtmlLink":"Add prints for parameters used in auto_levels_opt = 2 in real.exe (#2015"}},{"before":"e2da0f64d8149588d058e97524f905d455389036","after":"e1ebb1052d433093a0395337ef1465d336545c25","ref":"refs/heads/develop","pushedAt":"2024-02-28T21:40:58.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"weiwangncar","name":null,"path":"/weiwangncar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12705680?s=80&v=4"},"commit":{"message":" Makes mp_zero_out affect only the 'moist' array. New separate flags for scalar/chem/tracer (#2010)\n\nTYPE: bug fix\r\n\r\nKEYWORDS: mp_zero_out\r\n\r\nSOURCE: Ted Mansell (NOAA)\r\n\r\nDESCRIPTION OF CHANGES:\r\nThis fixes the side-effect of mp_zero_out being applied not only to the moist array, but also to the scalar/chem/tracer arrays using the same threshold. This behavior would be unexpected from the documentation (readme) which indicated that only mixing ratios were affected. This PR restricts mp_zero_out to the moist array and adds a separate mp_zero_out_all flag to apply it to all the arrays in the off chance that somebody needs to replicate the previous behavior.\r\n\r\nISSUE: Addresses https://github.com/wrf-model/WRF/issues/2007\r\n\r\nLIST OF MODIFIED FILES: \r\nM Registry/Registry.EM_COMMON \r\nM dyn_em/solve_em.F \r\nM run/README.namelist\r\nM wrftladj/solve_em_ad.F\r\nM wrftladj/solve_em_tl.F\r\n\r\nTESTS CONDUCTED: \r\nThe Jenkins tests have passed.\r\n\r\nRELEASE NOTE: The behavior of the mp_zero_out flag was changed affect only the 'moist' array, whereas previously it also caused the scalar/chem/tracer arrays to also be set to zero for values below threshold. Now there is a separate flag (mp_zero_out_all) if one wishes to reproduce the old behavior.","shortMessageHtmlLink":" Makes mp_zero_out affect only the 'moist' array. New separate flags …"}},{"before":"794843fe72a92b373401660625bdcc08e1fd8409","after":"e2da0f64d8149588d058e97524f905d455389036","ref":"refs/heads/develop","pushedAt":"2024-02-28T20:51:21.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"islas","name":"Anthony Islas","path":"/islas","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/128631809?s=80&v=4"},"commit":{"message":"CMake build of diffwrf binaries (#2013)\n\nTYPE: enhancement\r\n\r\nKEYWORDS: cmake, diffwrf\r\n\r\nSOURCE: internal\r\n\r\nDESCRIPTION OF CHANGES:\r\nProblem:\r\nNew CMake build did not create binaries for io_* `diffwrf`\r\n\r\nSolution:\r\nSlight restructure of certain targets to allow for easy creation of the diffwrf executables. Since previously all `diffwrf` binaries were named the same, to house them int the same `install/bin/` location they have been prefix with the type of io or shorthand of that option ( io_int -> `diffwrf_int`, io_netcdf -> `diffwrf_nc`, io_netcdfpar -> `diffwrf_ncpar` ). \r\n\r\nLIST OF MODIFIED FILES: \r\nM CMakeLists.txt\r\nM external/io_int/CMakeLists.txt\r\nM external/io_netcdf/CMakeLists.txt\r\nM external/io_netcdfpar/CMakeLists.txt\r\n\r\nTESTS CONDUCTED: \r\n1. Diffwrf execs should now be located in cmake install location\r\n\r\nRELEASE NOTE: \r\nCMake build of diffwrf binaries","shortMessageHtmlLink":"CMake build of diffwrf binaries (#2013)"}},{"before":"2e15abb75d1fa04e3a99e7dc2e775a2c2de7927d","after":"794843fe72a92b373401660625bdcc08e1fd8409","ref":"refs/heads/develop","pushedAt":"2024-02-22T17:05:20.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"weiwangncar","name":null,"path":"/weiwangncar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12705680?s=80&v=4"},"commit":{"message":"Fix AHE option 2 and a problem with mosaic (#2005)\n\nThis PR fixes 2 issues from the original PR#1986: 1. FRC_URB2D declaration for mosaic option; and 2. AHE option 2 should be added before PBL physics is called. This PR also removes a few un-used variables in surface_driver.\r\n\r\nLIST OF MODIFIED FILES:\r\nM dyn_em/module_first_rk_step_part1.F\r\nM phys/module_pbl_driver.F\r\nM phys/module_sf_noahdrv.F\r\nM phys/module_surface_driver.F\r\n\r\nTESTS CONDUCTED: \r\nThe Jenkins tests are all passing.","shortMessageHtmlLink":"Fix AHE option 2 and a problem with mosaic (#2005)"}},{"before":"d66b39985c5cfaa9e550ae4de48b849b66e031e7","after":"2e15abb75d1fa04e3a99e7dc2e775a2c2de7927d","ref":"refs/heads/develop","pushedAt":"2024-02-20T20:45:58.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"weiwangncar","name":null,"path":"/weiwangncar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12705680?s=80&v=4"},"commit":{"message":"Resolves building issues (WRF/WRF-chem) with Intel compilers (ifx/icx) (#1942)\n\nTYPE: bug fix\r\n\r\nKEYWORDS: Missing/Wrong Prototypes in C code, WRF-Chem\r\n\r\nSOURCE: Changgui Lin\r\n\r\nDESCRIPTION OF CHANGES:\r\nProblem:\r\nProblem: Most C code written long ago. No prototypes were used. See PR#1823. And, this pr is kind of an extension to PR#1823 addressing the same issue for building WRF-chem.\r\n\r\nSolution:\r\nAdd missing prototypes; rearrange function order to support new Intel oneAPI compiler\r\n\r\nRELEASE NOTE: This PR fixed missing and/or wrong prototypes in C code to support successful compilation of WRF-Chem when using the Intel oneAPI compiler ifx/icx.","shortMessageHtmlLink":"Resolves building issues (WRF/WRF-chem) with Intel compilers (ifx/icx) ("}},{"before":"5db9f7fcef70c118de7ce624eebfcd12d9e4c711","after":"d66b39985c5cfaa9e550ae4de48b849b66e031e7","ref":"refs/heads/develop","pushedAt":"2024-02-16T16:51:54.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"islas","name":"Anthony Islas","path":"/islas","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/128631809?s=80&v=4"},"commit":{"message":"CMake Build (#1896)\n\nTYPE: new feature\r\n\r\nKEYWORDS: CMake, build, make\r\n\r\nSOURCE: internal\r\n\r\nDESCRIPTION OF CHANGES:\r\nProblem:\r\nThe current WRF build system is fragile with many pitfalls making it difficult for users to build & add to it without perpetuating existing problems. Many options exist across various layers of files, languages, and option control-flow.\r\n\r\nSolution:\r\n*This requires CMake version 3.20 or newer*\r\nA redesign of the build system from the ground up, maintaining the interfacing feel and knowledge accumulated in `arch/configure.defaults`. Condense option selection and control to single locations and as best as possible reduce the complexity of this control.\r\n\r\nThis will be a work in progress as gaps are identified in reproducing the full functionality of the makefile build system. Currently only `em_real` and `em_ideal` have limited supported\r\n\r\n\r\nBrief how to use:\r\nAs this is a work in progress, the original `configure` and `compile` scripts have been left as-is. Alongside them are now `configure_new` and `compile_new` which walk a user through a slightly similar experience of configuring & compiling WRF.\r\n\r\nA simple usage example would be:\r\n```bash\r\n# Ensure you have cmake 3.20+ and configuration environment set up\r\n./configure_new\r\n# Follow prompts to select configuration\r\n./compile_new [-j N]\r\n```\r\n\r\nNotable differences are :\r\n* Submodule code must be checked out beforehand and is not checked out during the compile process\r\n* Stanzas presented to a user are only those for which the compiler exists in the current environment\r\n* `!!` warnings appear for subconfigurations (MPI) that would not be supported in the current environment\r\n* DM/SM selection is now done after selecting a base configuration rather than an individual configuration # within a family of compilers\r\n* Compilation via `compile_new` does not take target to build as an argument - parallel `-j N` jobs still supported\r\n* Users do not need to set `NETCDF` or `LD_LIBRARY_PATH` variables\r\n* Base binaries do not have `.exe` extension, but symlinks are provided\r\n* Binaries, test setups, and everything else generated from compilation is copy-placed (not softlinked) to a separate location - default is `./install`. This means the equivalent `test/em_real/wrf.exe` is now at `install/test/em_real/wrf.exe`\r\n\r\n\r\nLIST OF MODIFIED FILES: \r\nA CMakeLists.txt\r\nA arch/configure_reader.py\r\nA chem/CMakeLists.txt\r\nA cleanCMake.sh\r\nA cmake/c_preproc.cmake\r\nA cmake/confcheck.cmake\r\nA cmake/gitinfo.cmake\r\nA cmake/m4_preproc.cmake\r\nA cmake/modules/FindJasper.cmake\r\nA cmake/modules/FindRPC.cmake\r\nA cmake/modules/FindnetCDF-Fortran.cmake\r\nA cmake/modules/FindnetCDF.cmake\r\nA cmake/modules/FindpnetCDF.cmake\r\nA cmake/printOption.cmake\r\nA cmake/target_copy.cmake\r\nA cmake/template/WRFConfig.cmake.in\r\nA cmake/template/arch_config.cmake\r\nA cmake/template/commit_decl.cmake\r\nA cmake/wrf_case_setup.cmake\r\nA cmake/wrf_get_version.cmake\r\nA compile_new\r\nA confcheck/CMakeLists.txt\r\nA configure_new\r\nA dyn_em/CMakeLists.txt\r\nA external/CMakeLists.txt\r\nA external/RSL_LITE/CMakeLists.txt\r\nA external/atm_ocn/CMakeLists.txt\r\nA external/esmf_time_f90/CMakeLists.txt\r\nA external/fftpack/fftpack5/CMakeLists.txt\r\nA external/io_adios2/CMakeLists.txt\r\nA external/io_esmf/CMakeLists.txt\r\nA external/io_grib1/CMakeLists.txt\r\nA external/io_grib1/MEL_grib1/CMakeLists.txt\r\nA external/io_grib1/WGRIB/CMakeLists.txt\r\nA external/io_grib1/grib1_util/CMakeLists.txt\r\nA external/io_grib2/CMakeLists.txt\r\nA external/io_grib2/bacio-1.3/CMakeLists.txt\r\nA external/io_grib2/g2lib/CMakeLists.txt\r\nA external/io_grib2/g2lib/utest/CMakeLists.txt\r\nA external/io_grib_share/CMakeLists.txt\r\nA external/io_int/CMakeLists.txt\r\nA external/io_netcdf/CMakeLists.txt\r\nA external/io_netcdfpar/CMakeLists.txt\r\nA external/io_phdf5/CMakeLists.txt\r\nA external/io_pio/CMakeLists.txt\r\nA external/io_pnetcdf/CMakeLists.txt\r\nA external/ioapi_share/CMakeLists.txt\r\nA frame/CMakeLists.txt\r\nA inc/CMakeLists.txt\r\nA main/CMakeLists.txt\r\nA phys/CMakeLists.txt\r\nA share/CMakeLists.txt\r\nA test/em_b_wave/CMakeLists.txt\r\nA test/em_convrad/CMakeLists.txt\r\nA test/em_fire/CMakeLists.txt\r\nA test/em_grav2d_x/CMakeLists.txt\r\nA test/em_heldsuarez/CMakeLists.txt\r\nA test/em_hill2d_x/CMakeLists.txt\r\nA test/em_les/CMakeLists.txt\r\nA test/em_quarter_ss/CMakeLists.txt\r\nA test/em_real/CMakeLists.txt\r\nA test/em_scm_xy/CMakeLists.txt\r\nA test/em_seabreeze2d_x/CMakeLists.txt\r\nA test/em_squall2d_x/CMakeLists.txt\r\nA test/em_squall2d_y/CMakeLists.txt\r\nA test/em_tropical_cyclone/CMakeLists.txt\r\nA tools/CMakeLists.txt\r\nA tools/CodeBase/CMakeLists.txt\r\nA doc/README.cmake_build\r\nM tools/fseek_test.c\r\nM README\r\nM arch/configure.defaults\r\n\r\n\r\n- Modified file include an adjustment to a compile test to allow the test to be conducted in an out-of-source build manner as prescribed by CMake. Default logic of this test to still test on the existence of `Makefile`\r\n\r\nTESTS CONDUCTED: \r\n1. In various instances this build is faster and more reliable with meaningful diagnostics when errors occur\r\n\r\nRELEASE NOTE: \r\nIntroduction of a CMake build system for em_real and em_ideal","shortMessageHtmlLink":"CMake Build (#1896)"}},{"before":"3cadf04277ac3a050e65461efb6aa939349c60a8","after":"5db9f7fcef70c118de7ce624eebfcd12d9e4c711","ref":"refs/heads/develop","pushedAt":"2024-02-14T16:19:14.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"weiwangncar","name":null,"path":"/weiwangncar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12705680?s=80&v=4"},"commit":{"message":"Add KPP configure option to search for alternative version of libfl (#2008)\n\nTYPE: enhancement\r\n\r\nKEYWORDS: chem, KPP, configure_kpp, Derecho\r\n\r\nSOURCE: internal\r\n\r\nDESCRIPTION OF CHANGES: \r\nProblem: KPP would not compile on Derecho due to name differences in libfl: only libfl.so exists, not libfl.a.\r\n\r\nSolution:\r\nAdd flag to search for alternative name, libfl.so.\r\n\r\nLIST OF MODIFIED FILES: \r\n\r\nM chem/KPP/configure_kpp\r\n\r\nTESTS CONDUCTED: \r\n- Compiles with old intel compilers with libfl.a and compiles on Derecho with libfl.so\r\n- It passes regression tests.\r\n\r\nRELEASE NOTE: KPP configure option for alternative libfl name, libfl.so, in addition to libfl.a.","shortMessageHtmlLink":"Add KPP configure option to search for alternative version of libfl (#…"}},{"before":"53f346023824ecad3d11252c1ca82912099a35ac","after":"3cadf04277ac3a050e65461efb6aa939349c60a8","ref":"refs/heads/develop","pushedAt":"2024-02-07T00:26:11.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"weiwangncar","name":null,"path":"/weiwangncar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12705680?s=80&v=4"},"commit":{"message":"[Resubmit for PR #1881] New option for SLUCM to use global distributed urban aerodynamic parameters (#1986)\n\nTYPE: new feature\r\n\r\nKEYWORDS: SLUCM, urban parameters, anthropogenic heat\r\n\r\nSOURCE: Do Ngoc Khanh (Tokyo Institute of Technology)\r\n\r\nDESCRIPTION OF CHANGES:\r\nThis PR adds a new feature to WRF SLUCM by allowing consideration of spatially varying global distributed urban parameters and spatially hourly monthly varying anthropogenic heat.\r\n\r\nLIST OF MODIFIED FILES:\r\nM Registry/Registry.EM_COMMON\r\nM Registry/registry.dimspec\r\nM dyn_em/module_first_rk_step_part1.F\r\nM dyn_em/module_initialize_real.F\r\nM phys/module_pbl_driver.F\r\nM phys/module_physics_init.F\r\nM phys/module_sf_clm.F\r\nM phys/module_sf_noahdrv.F\r\nM phys/module_sf_urban.F\r\nM phys/module_surface_driver.F\r\nM phys/noahmp\r\nM share/output_wrf.F\r\n\r\nTESTS CONDUCTED:\r\n\r\n- The modification has been tested and used in previous publications.\r\nInitial development: Varquez, A. C. G., Nakayoshi, M., & Kanda, M. (2015). The effects of highly detailed urban roughness parameters on a sea-breeze numerical simulation. Boundary-layer meteorology, 154, 449-469. https://doi.org/10.1007/s10546-014-9985-4\r\nGlobal extension: Khanh, D. N., Varquez, A. C., & Kanda, M. (2023). Impact of urbanization on exposure to extreme warming in megacities. Heliyon, 9, e15511. https://doi.org/10.1016/j.heliyon.2023.e15511\r\n- The Jenkins tests are all passing.\r\n\r\nRELEASE NOTE: This modification adds two options (use_distributed_aerodynamics and distributed_ahe_opt) to WRF SLUCM (sf_urban_physics = 1) so that spatially varying urban morphological parameters (building height, plan area index, frontal area index, roughness length for momentum, and displacement height) can be considered.","shortMessageHtmlLink":"[Resubmit for PR #1881] New option for SLUCM to use global distribute…"}},{"before":"bcd3e504c818cc766e4eb40b26e2226ea626a057","after":"53f346023824ecad3d11252c1ca82912099a35ac","ref":"refs/heads/develop","pushedAt":"2024-02-05T17:19:33.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"weiwangncar","name":null,"path":"/weiwangncar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12705680?s=80&v=4"},"commit":{"message":"Fix compile on Cygwin (#2003)\n\nTYPE: bug fix\r\n\r\nKEYWORDS: compilation, Cygwin, doc files\r\n\r\nSOURCE: Daniel Wesloh (Penn State)\r\n\r\nDESCRIPTION OF CHANGES:\r\nProblem:\r\nCompiling WRF failed on Cygwin due to lack of netCDF4\r\n\r\nSolution:\r\nMatch assumptions about `USENETCDFPAR` (#1743 would also fix this) and pass flags to allow legacy Fortran constructs (disallowed by default with GCC 10)\r\n\r\nISSUE: For use when this PR closes an issue.\r\nFixes #1271\r\n\r\nLIST OF MODIFIED FILES: \r\nM configure\r\nM doc/README.cygwin.md\r\nM doc/README.netcdf4par\r\n\r\nTESTS CONDUCTED: \r\n1. Checked whether model compiles on Cygwin in DWesl/wrf#1\r\n2. The Jenkins tests have passed.\r\n\r\nRELEASE NOTE: Fix compilation on Cygwin.","shortMessageHtmlLink":"Fix compile on Cygwin (#2003)"}},{"before":"3491d8e297c32340ea97c41c312e82fcd67f232b","after":"bcd3e504c818cc766e4eb40b26e2226ea626a057","ref":"refs/heads/develop","pushedAt":"2024-02-02T18:30:23.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"weiwangncar","name":null,"path":"/weiwangncar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12705680?s=80&v=4"},"commit":{"message":"Bug fix for chem_opt=100 (vbs_het), racm_soa_vbs_het_kpp initialization (#2000)\n\nTYPE:bug fix\r\n\r\nKEYWORDS: racm_soa_vbs_het_kpp, aerosols\r\n\r\nSOURCE: Sergey Osipov (KAUST)\r\n\r\nDESCRIPTION OF CHANGES:\r\nProblem:\r\nThe bug was introduced after splitting chem_opt 100 and 106. Currently, the chemistry initialization always calls for module_aerosol_soa_vbs routine, leaving the module_aerosol_soa_vbs_HET and corresponding data constants unitialized. As a result, aerosol concentrations are set to 0 after the first time integration (10**-16).\r\n\r\nTo verify the bug fix, initialize WRF-Chem with non-trivial IC and save the next time step into nc. Check that values are non-trivial (e.g., so4aj, soila).\r\n\r\nSolution:\r\nDifferentiate between module_aerosol_soa_vbs and module_aerosol_soa_vbs_het initialization routines\r\n\r\nLIST OF MODIFIED FILES:\r\nM Registry/registry.chem\r\nM chem/chemics_init.F\r\nM chem/module_aerosols_soa_vbs_het.F\r\n\r\nTESTS CONDUCTED: \r\n- The Jenkins tests are all passing.\r\n\r\nRELEASE NOTE: This PR fixes a bug introduced after splitting chem_opt 100 and 106, which left the module_aerosol_soa_vbs_HET and corresponding data uninitialized.","shortMessageHtmlLink":"Bug fix for chem_opt=100 (vbs_het), racm_soa_vbs_het_kpp initializati…"}},{"before":"cb5fb2f48859e6dd772e4db4efdde9f32fd6fc38","after":"3491d8e297c32340ea97c41c312e82fcd67f232b","ref":"refs/heads/develop","pushedAt":"2024-02-02T18:20:55.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"weiwangncar","name":null,"path":"/weiwangncar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12705680?s=80&v=4"},"commit":{"message":"The WRF-SoilN-chem: a dynamic ammonia emission model (#1826)\n\nTYPE: enhancement\r\n\r\nKEYWORDS: ammonia emission, soil, dynamic, chem, gas phase.\r\n\r\nSOURCE: RenChuanhua and Huangxin, Nanjing University.\r\n\r\nDESCRIPTION OF CHANGES: \r\nProblem:\r\nThe traditional monthly emission inventory cannot characterize the variation of ammonia emission intensity under different meteorological conditions, which leads to the simulation bias of secondary inorganic aerosol (such as nitrate and sulfate).\r\n\r\nSolution:\r\nThe meteorological dependent dynamic emission factor (empirical function) is added to the emission file, which can calculate the ammonia emission rate according to hourly meteorological conditions and soil conditions.\r\n\r\nLIST OF MODIFIED FILES: list of changed files: \r\nRegistry/Registry.EM_COMMON\r\nRegistry/registry.chem\r\nchem/chem_driver.F\r\nchem/emissions_driver.F\r\n\r\nTESTS CONDUCTED: \r\nWe compiled and ran the revised model to simulate 2019 East China region, and it can run smoothly, and the running speed has not decreased significantly. Compared with the traditional static emission inventory, the NH3 and nitrate concentrations obtained by dynamic model are obviously optimized.\r\n\r\nThe code has passed the regression tests.\r\n\r\nRELEASE NOTE: This PR adds the meteorological dependent dynamic emission factor (empirical function) to the emission file, which may help correct simulation bias of secondary inorganic aerosol (such as nitrate and sulfate).\r\n\r\nThe whole source code and input dataset (binary data needed to be embedded into WPS geog_data_path) and model userguide can be found in:\r\nhttps://github.com/RenChuanhua/wrf-nh3-chem_v1.0\r\n\r\nRen, C., Huang, X., Liu, T., Song, Y., Wen, Z., Liu, X., Ding, A., and Zhu, T.: A dynamic ammonia emission model and the online coupling with WRF-Chem (WRF-SoilN-Chem v1.0): development and evaluation, Geosci. Model Dev. Discuss. [preprint], https://doi.org/10.5194/gmd-2022-231, 2022.","shortMessageHtmlLink":"The WRF-SoilN-chem: a dynamic ammonia emission model (#1826)"}},{"before":"c6cc0c537725a1d38352fec46c3a184eb70fb227","after":"cb5fb2f48859e6dd772e4db4efdde9f32fd6fc38","ref":"refs/heads/develop","pushedAt":"2024-02-02T18:13:19.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"weiwangncar","name":null,"path":"/weiwangncar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12705680?s=80&v=4"},"commit":{"message":"Shared physics sfclayrev (#1997)\n\nTYPE: enhancement, new feature\r\n\r\nKEYWORDS: shared physics, revised MM5 sfclay scheme\r\n\r\nSOURCE: internal\r\n\r\nDESCRIPTION OF CHANGES:\r\nAdd revised MM5 surface layer scheme from the shared physics directory, which is ccpp-compliant. Also added salinity effect in the shared physics subroutine. It also includes change made in [PR-1924.](https://github.com/wrf-model/WRF/pull/1924)\r\n\r\nThe CCPP-compliant revised MM5 surface layer code will be residing in phys/physics_mmm/ directory. Currently it is a copy of the code from the future MMM-physics repo, plus the salinity change made recently in WRF.\r\n\r\nLIST OF MODIFIED FILES: \r\nM arch/postamble\r\nM arch/preamble\r\nM clean\r\nM main/depend.common\r\nM phys/Makefile\r\nM phys/module_physics_init.F\r\nM phys/module_sf_sfclayrev.F\r\nM phys/module_surface_driver.F\r\nA phys/physics_mmm/sf_sfclayrev.F90\r\n\r\nTESTS CONDUCTED: \r\n1. The runs before and after this change produce bit-for-bit results when compiled with -d option.\r\n2. The Jenkins tests are all passing.\r\n\r\nRELEASE NOTE: Add revised MM5 surface layer scheme from the future shared MMM-physics repository.","shortMessageHtmlLink":"Shared physics sfclayrev (#1997)"}},{"before":"81410a36a3f784c8d90e871698e998cae6a0c9fe","after":"c6cc0c537725a1d38352fec46c3a184eb70fb227","ref":"refs/heads/develop","pushedAt":"2024-02-02T16:01:46.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"weiwangncar","name":null,"path":"/weiwangncar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12705680?s=80&v=4"},"commit":{"message":"Shared physics nTiedtke (#1994)\n\nTYPE: enhancement, new feature\r\n\r\nKEYWORDS: shared physics, new Tiedtke\r\n\r\nSOURCE: internal\r\n\r\nDESCRIPTION OF CHANGES:\r\nThis PR adds new Tiedtke scheme from the shared physics directory, which is ccpp-compliant.\r\n\r\nThe CCPP-compliant new Tiedtke code will be residing in phys/physics_mmm/ directory. Currently it is a copy of the code from the future MMM-physics repo.\r\n\r\nLIST OF MODIFIED FILES: \r\nM arch/postamble\r\nM arch/preamble\r\nM clean\r\nM main/depend.common\r\nM phys/Makefile\r\nM phys/module_cu_ntiedtke.F\r\nM phys/module_cumulus_driver.F\r\nA phys/physics_mmm/cu_ntiedtke.F90\r\n\r\nTESTS CONDUCTED: \r\n1. The runs before and after this change produce bit-for-bit results when compiled with -d option.\r\n2. The Jenkins tests are all passing.\r\n\r\nRELEASE NOTE: Add new Tiedtke cumulus scheme from the future shared MMM-physics repository.","shortMessageHtmlLink":"Shared physics nTiedtke (#1994)"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAETAeargA","startCursor":null,"endCursor":null}},"title":"Activity · wrf-model/WRF"}