public
Description: Merb Core: All you need. None you don't.
Homepage: http://www.merbivore.com
Clone URL: git://github.com/wycats/merb-core.git

Comments for wycats's merb-core   feed

michaelklishin commented on wycats/merb-core Fri Oct 10 04:45:31 -0700 2008
Comment in ea52be2:

Because in order to add deprecation message you gotta make it a method at some point. Why later rather than now?

cheba commented on wycats/merb-core Fri Oct 10 02:18:32 -0700 2008
Comment on lib/merb-core/core_ext/kernel.rb L187 in ea52be2:

Why not alias?

elliottcable commented on wycats/merb-core Thu Oct 09 18:22:33 -0700 2008
Comment in 037c6ec:

What should read $TESTING?

michaelklishin commented on wycats/merb-core Thu Oct 09 16:19:39 -0700 2008
Comment in 037c6ec:

This should read: using $TESTING. zsh or github seemed to swallow it as a variable.

michaelklishin commented on wycats/merb-core Thu Oct 09 15:17:33 -0700 2008
Comment in a84863d:

ok I removed that statement altogether. Freedom to those without init files!

michaelklishin commented on wycats/merb-core Thu Oct 09 15:06:49 -0700 2008
Comment in a84863d:

Merb.disable(:initfile) should do the trick.

benburkert commented on wycats/merb-core Wed Oct 08 21:39:07 -0700 2008
Comment on lib/merb-core/bootloader.rb L348 in a84863d:

This makes it impossible to run the specs for merb-cache. The Merb.start method is called without an init file. Can we change this to an “elsif Merb.environment == ‘development’”?

dudleyf commented on wycats/merb-core Sun Oct 05 09:54:21 -0700 2008
Comment in fed1939:

> What is use case for this? (just curious)

Merb on JRuby in a Java application server. The app server should handle signals, not the individual applications inside it.

michaelklishin commented on wycats/merb-core Sun Oct 05 00:00:16 -0700 2008
Comment in fed1939:

What is use case for this? (just curious)

michaelklishin commented on wycats/merb-core Fri Oct 03 00:40:55 -0700 2008
Comment in 1da4faa:

this should read: fixes merb -i exception

nagybence commented on wycats/merb-core Tue Sep 30 15:24:11 -0700 2008
Comment in 62bbcc4:

Oh, not a typo, sorry, too tired tonight…

nagybence commented on wycats/merb-core Tue Sep 30 15:22:15 -0700 2008
Comment in 62bbcc4:

“url(:blogpoost, 1)” → “url(:blogposts, 1)” in line 147?

felix commented on wycats/merb-core Mon Sep 29 20:55:01 -0700 2008
Comment in a6f6a98:

So which logger is going to be used, this one or extlibs? It was just removed in the previous commit.

dkubb commented on wycats/merb-core Mon Sep 29 20:42:45 -0700 2008
Comment on lib/merb-core/dispatch/router/route.rb L316 in 32ee4fa:

It would be even simpler (and probably faster) to use String#squeeze! and String#chomp! here instead of String#gsub with a regexp, eg: compiled.squeeze!(‘/’); compiled.chomp!(‘/’)

djwonk commented on wycats/merb-core Sun Sep 28 09:43:35 -0700 2008
michaelklishin commented on wycats/merb-core Sun Sep 28 06:51:32 -0700 2008
Comment in f57cc0c:

It does not really matter. But I am glad you know it exists with current level of documentation ;) Reading sources FTW.

cheba commented on wycats/merb-core Sun Sep 28 06:15:11 -0700 2008
Roman2K commented on wycats/merb-core Sat Sep 27 04:16:14 -0700 2008
Comment on lib/merb-core.rb L120 in 8b09d45:

What if “obj” is non-nil? Why isn’t it assigned to Thread.current[:merb_logger]?

ivey commented on wycats/merb-core Tue Sep 23 11:08:01 -0700 2008
Comment in 0534235:

Why does the Request generate URLs?

dkubb commented on wycats/merb-core Fri Sep 19 11:12:54 -0700 2008
Comment on lib/merb-core/rack/application.rb L20 in 1cc5494:

Not that it matters much given that this is commented out, but it would be better to use Time#httpdate when setting time based HTTP headers rather than Time#rfc2822 here.