@@ -1,4 +1,17 @@
# Most of this list is simply constants frozen for efficiency
+# and lowered memory consumption. Every time Ruby VM comes
+# across a string or a number or a regexp literal,
+# new object is created.
+#
+# This means if you refer to the same string 6 times per request
+# and your application takes 100 requests per second, there are
+# 600 objects for weak MRI garbage collector to work on.
+#
+# GC cycles take up to 80% (!) time of request processing in
+# some cases. Eventually Rubinius and maybe MRI 2.0 gonna
+# improve this situation but at the moment, all commonly used
+# strings, regexp and numbers used as constants so no extra
+# objects created and VM just operate pointers.
module Merb
module Const
@@ -41,5 +54,10 @@ module Merb
REQUEST_URI = "REQUEST_URI".freeze
REQUEST_PATH = "REQUEST_PATH".freeze
REMOTE_ADDR = "REMOTE_ADDR".freeze
+ BREAK_TAG = "<br/>".freeze
+ EMPTY_STRING = "".freeze
+ NEWLINE = "\n".freeze
+ DOUBLE_NEWLINE = "\n\n".freeze
+ LOCATION = "Location".freeze
end
end
lib/merb-core/constants.rb
@@ -16,9 +16,9 @@ module Merb
begin
rack_response = ::Merb::Dispatcher.handle(Merb::Request.new(env))
rescue Object => e
- return [500, {Merb::Const::CONTENT_TYPE => "text/html"}, e.message + "<br/>" + e.backtrace.join("<br/>")]
+ return [500, {Merb::Const::CONTENT_TYPE => "text/html"}, e.message + Merb::Const::BREAK_TAG + e.backtrace.join(Merb::Const::BREAK_TAG)]
end
- Merb.logger.info "\n\n"
+ Merb.logger.info Merb::Const::DOUBLE_NEWLINE
Merb.logger.flush
# unless controller.headers[Merb::Const::DATE]
@@ -41,7 +41,7 @@ module Merb
#
# @api private
def deferred?(env)
- path = env[Merb::Const::PATH_INFO] ? env[Merb::Const::PATH_INFO].chomp('/') : ""
+ path = env[Merb::Const::PATH_INFO] ? env[Merb::Const::PATH_INFO].chomp(Merb::Const::SLASH) : Merb::Const::EMPTY_STRING
if path =~ Merb.deferred_actions
Merb.logger.info! "Deferring Request: #{path}"
true
lib/merb-core/rack/application.rb
@@ -24,10 +24,10 @@ module Merb
Merb.logger.info("Dispatcher redirecting to: #{url} (#{status})")
Merb.logger.flush
- [status, { "Location" => url },
+ [status, { Merb::Const::LOCATION => url },
Merb::Rack::StreamWrapper.new("<html><body>You are being <a href=\"#{url}\">redirected</a>.</body></html>")]
end
end
end
-end
\ No newline at end of file
+end
lib/merb-core/rack/helpers.rb
173c4a1889afe4fa355cd768b0c8c66ebbe987f6
Michael S. Klishin
michael@novemberain.com
http://github.com/wycats/merb-core/commit/afa48c563f5faf06227e1b6b1b73f7638cfe960c
afa48c563f5faf06227e1b6b1b73f7638cfe960c
2008-10-12T07:45:54-07:00
2008-10-12T07:45:11-07:00
Use frozen constants on the hot path where possible.
28f0f4cac058b9c3f610d0b9042c2d3ae786ecc0
Michael S. Klishin
michael@novemberain.com