Comments for wycats's merb-more  

+1 to jnicklas … this seems like a mistake, especially for a 1.0 RC

It’s a “just in case” measure because we had slices generators not hooked up during sprint. We can load that with merb-haml.rb or something a bit later on when merbcamp is over and things settle down a bit.

Seriously, why is this necessary? It’s simply not. If you don’t have merb-haml set up as a dependency, why would you possibly need the haml generators?

yay for no mocks where real objects will do!

lol :-) why not just keep it consistent with the rest? with – instead of _

could you also add a way to specify adapter? would be great :)

This gonna complicate merge of new -helpers spec suite :( Sigh. Evil one liners.

Doing it that way seems like a better way. I copied what I saw in -slices. I know that when I made this change the mailer generator wasn’t showing in merb-gen’s list even though I had merb-mailer required.

@jnicklas can you confirm that this works properly without the Generators file?

BTW: here is the part that makes the Generators file redundant:

http://github.com/wycats/merb-more/tree/master/merb-mailer/lib/merb-mailer.rb#L6

this is a bad idea, imho. Generators files should only be used when absolutely necessary, as it adds an overhead to starting up merb-gen.

In this case, it’s not necessary. We only need mailer generators when merb-mailer is a part of the application, therefore the Generators file isn’t needed.

The commit has since been removed.

The commit has since been removed.

Thought I would try a commit from the Github website…oh well

Unfortunately, it swallows exception back trace.

should_not raise_error exists to convey meaning to the reader of the spec. without it, it looks like there’s a missing expectation.

How about making this auto generated when it is first required by the bundler scripts? Not everyone is going to need or want this directory…

We’re running against edge atm… Templater 0.2 should be released in the next few days.

FYI: doing a gem update didn’t get templater 0.2.0. Had to use http://github.com/jnicklas/templater

My current list:

Recursive dependencies: english mongrel erubis json mime-types xml-simple archive-tar-minitar rubigen rake ruby2ruby json_pure merb-core merb-more ParseTree builder rspec rack hpricot extlib libxml-ruby memcache-client templater haml mailfactory merb-action-args merb-assets merb-gen merb-haml merb-mailer merb-parts merb-builder merb-cache merb-freezer merb-slices merb-jquery merb sequel sequel_model

Note that I should remove the elements which get installed when installing merb core, more and plugins