wycats / thor

Rubyforge version was already updated. But unfortunately, not tagged. Do you need the older version in specific?

Closing! Feel free to reopen or open another ticket.

Just do:

class MyApp < Thor
  default_task :list
end

Is there a reason why this can be a security issue? If anyone is executing thor, that someone has access the machine, so thor instance_eval "p 12" is the last thing we would be concerned with. ;)

Anyway, fixed ;)

Yeah, I'm going to write some code that only uses the color on windows if win32console is enabled. And I'll fix the other issue asap. Thanks :)

i have win32console installed in my 1.9.1p243 (mingw) from http://rubyinstaller.org and cmd.exe still doesn't understand Thor's colorful language.

I had to implement the following brute force patch but it would be nice to see color if win32console is installed. That said, I don't think a hard dependency on win32console is appropriate as falling back on the Basic shell is OK.

diff --git a/lib/thor/shell.rb b/lib/thor/shell.rb
index 0d3f4d5..6fe4273 100644
--- a/lib/thor/shell.rb
+++ b/lib/thor/shell.rb
@@ -1,11 +1,13 @@
 require 'thor/shell/color'
+require 'rbconfig'

 class Thor
   module Base
     # Returns the shell used in all Thor classes. Default to color one.
     #
     def self.shell
-      @shell ||= Thor::Shell::Color
+      # TODO win32console patch if project will accept a soft dependency
+      @shell ||= RbConfig::CONFIG['host_os'] =~ /mswin|mingw/ ? Thor::Shell::Basic : Thor::Shell::Color
     end

     # Sets the shell used in all Thor classes.

What's the latest on this one?

I want to fix that tomorrow ;)

Sounds great.

FYI, last time I checked, the Console.so installed with gem install win32console was only linked against msvcrt-ruby18.dll which is a problem for 1.9.1 users and may be the root of http://github.com/luislavena/win32console/issues#issue/1

I don't know whether the fix Luis mentions addresses the 1.9.1 issue or not, but hopefully the fix will be a fat-binary supporting mswin and mingw on 1.8 and 1.9.

So I will give up checking for win32console on Windows. By default it will use only Thor::Shell::Basic. :)

And what is exactly the issue with Windows home? I want to represent that in the test suite. What were you getting and what it should return instead?

My main use was on Vista and I was getting the actual ASCII control codes printed out to cmd.exe. I think the same will occur on WinXP.

I'll revert out the patch I listed above and try things out (without win32console) on a Vista and XP machine both running Ruby 1.9.1p243 from http://rubyinstaller.org/ and post results in a bit.

Results from a quick run on Vista Home. Notice the control codes after running thor -T If this is different when I try it on XP, I'll post additional results.

C:\>type install_validator.thor
module RubyInstaller
module Extras
  class Install < Thor
    namespace :install

    desc 'validate', 'validate a RubyInstaller installation'
    def validate
      say 'Validating...'
    end
  end
end
end

C:\>thor -T
←[1m←[34minstall←[0m
-------
install:validate
# validate a RubyInstaller installation

Yeah, just committed a fix for it. Now I'm solving File.join(user_home, ".thor") issue, you have a test case for it?

I don't have a spec for my patch to shell.rb.

I'm not familiar with Thor's internals yet, but is there a way to programatically have Thor "say" to a string rather than the shell so we can easily do a regex match in a spec? If yes, let me know and I'll submit a spec for your review.

I don't need a test case, I just need to know what was happening so a patch was needed. It was searching for something like C:\ and it should be C:/ ?

Oh, I see what you're asking. I wasn't the guy reporting the path issue, I just reported the console coloring issue.

Oh yeah! :D Sorry!
So you haven't had that issue?

I haven't seen the path issue yet, but I also haven't run Thor through the gauntlet either :)

I suspect gauched saw the issue when trying thor install but that's only a guess.

Could you try installing anything please? You could use this command:

thor install http://github.com/wycats/thor/raw/master/spec/fixtures/task.thor

C:\Users\Jon\Documents>thor install http://github.com/wycats/thor/raw/master/spec/fixtures/task.thor
Your Thorfile contains:
# module: random

class Amazing < Thor
  desc "describe NAME", "say that someone is amazing"
  method_options :forcefully => :boolean
  def describe(name, opts)
    ret = "#{name} is amazing"
    puts opts["forcefully"] ? ret.upcase : ret
  end
end
Do you wish to continue [y/N]? y
Storing thor file in your system repository

which created a C:\Users\Jon.thor directory containing a .yml file and the SHA1 named thor file.

C:\Users\Jon\Documents>thor installed
Modules  Namespaces
-------  ----------
random   amazing

amazing
-------
amazing:describe NAME [--forcefully]
# say that someone is amazing

trying multiple ways to uninstall

C:\Users\Jon\Documents>thor uninstall amazing
Can't find module 'amazing'

C:\Users\Jon\Documents>thor uninstall random
Uninstalling random.
Done.

removed files from C:\Users\Jon.thor and left a semi-empty thor.yml file containing a single line --- {}\r\n\r\n

C:\Users\Jon\Documents>thor installed
No Thor tasks available

Thanks, I will close this ticket by now!

I just looked over the latest mod to shell.rb in which

@shell ||= if RUBY_PLATFORM =~ /mswin|mingw/

Need to check that this works properly with JRuby running on Windows as JRuby returns java for puts RUBY_PLATFORM

Just did the following quick test on JRuby 1.3.1

C:\Users\Jon\Documents\RubyDev\rubyinstaller-trunk\extras>"C:\jruby\bin\jruby" -I"c:/Users/Jon/Documents/RubyDev/thor-trunk/bin" -I"C:/Users/Jon/Documents/RubyDev/thor-trunk/lib" c:\Users\Jon\Documents\RubyDev\thor-trunk\bin\thor -T
WARNING: unable to load thorfile "C:/Users/Jon/.thor/thor.yml": undefined method `-@' for {}:Hash
←[1m←[34minstall←[0m
-------
install:validate
# validate a RubyInstaller installation

which shows the same control code problem.

There's a thread on the JRuby list on this issue of trying to figure out which platform you're running on, the the bottom line is that RbConfig::CONFIG['host_os'] =~ /mswin|mingw/ appears to be the most reliable solution so far.

http://groups.google.com/group/jruby-users/browse_thread/thread/ca1f0cf3c1a18912/987155124e9501fe

Awesome, I will update that!