Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
Fixes: #6302 If you try to use both the `$(ApplicationId)` MSBuild property and the `/manifest/@package` attribute within `AndroidManifest.xml` at the same time, you hit errors during deployment: Xamarin.Android.Common.Debugging.targets(611,5): error XA0132: The package was not installed. Please check you do not have it installed under any other user. If the package does show up on the device, try manually uninstalling it then try again. You should be able to uninstall the app via the Settings app on the device. From the spec, the `AndroidManifest.xml` value is *supposed* to be preferred. I found that the `<GetAndroidPackageName/>` MSBuild task is accidentally preferring the `$(ApplicationId)` MSBuild property. I reordered the logic and only use the property when no value is found in the `AndroidManifest.xml`. I could reproduce the issue in a test, which now passes.
- Loading branch information
1 parent
2a12a10
commit 0a6f9bd
Showing
2 changed files
with
32 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters