Skip to content

Commit

Permalink
[Xamarin.Android.Build.Tasks] JavaTypeSystem & XML Adjuster (#6444)
Browse files Browse the repository at this point in the history
Context: xamarin/java.interop@f658ab2

In commit 43243b4 we added the `$(_AndroidUseJavaLegacyResolver)`
MSBuild property to the `<BindingsGenerator/>` MSBuild task, to allow
users to use the older "API XML Adjuster" instead of the new
`Java.Interop.Tools.JavaTypeSystem.dll` infrastructure added in
xamarin/java.interop@f658ab26.

However, we call `generator` twice during the build: once for
`ApiXmlAdjuster`, and once to generate C# code, but  we only added
the the `$(_AndroidUseJavaLegacyResolver)` to the "generate C# code"
case.  Update the `_ExportJarToXml` target so that
`$(_AndroidUseJavaLegacyResolver)` is used in the `ApiXmlAdjuster`
scenario, which is where it is primarily needed.
  • Loading branch information
jpobst committed Oct 29, 2021
1 parent 85a50c8 commit 29740ab
Showing 1 changed file with 1 addition and 0 deletions.
Expand Up @@ -43,6 +43,7 @@ This file is only used by binding projects.
ToolPath="$(MonoAndroidToolsDirectory)"
ToolExe="$(BindingsGeneratorToolExe)"
Nullable="$(Nullable)"
UseJavaLegacyResolver="$(_AndroidUseJavaLegacyResolver)"
/>
</Target>

Expand Down

0 comments on commit 29740ab

Please sign in to comment.