Skip to content

Commit

Permalink
Bump SQLite to 3.37.0 (#6530)
Browse files Browse the repository at this point in the history
Context: https://sqlite.org/releaselog/3_37_0.html

Context: sqlite/sqlite@c2df4d6

Context: sqlite/sqlite@version-3.36.0...version-3.37.0

	% git diff --shortstat version-3.36.0...version-3.37.0
	 253 files changed, 13372 insertions(+), 4534 deletions(-)

Changes: xamarin/sqlite@a575761...88e12a9

	% git diff --shortstat a5757617...88e12a9e                                  
	 13 files changed, 62515 insertions(+), 39564 deletions(-)

An apparent undocumented "breaking change" that we encountered:
probably as of sqlite/sqlite@c2df4d6a, if a column type is one of a
known set of types, then the type is stored in the bit-field, not
as a string.

For example, given:

	CREATE TABLE TESTTABLE (DATA blob not null)

if you query the type of the `DATA` column, SQLite will now return
`BLOB`, whereas previously it would return `blob`; the case is no
longer preserved.  This broke one of our unit tests, which was fixed
by using a case-insensitive comparison.
  • Loading branch information
grendello committed Nov 30, 2021
1 parent c3710ee commit c52e6e6
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion external/sqlite
2 changes: 1 addition & 1 deletion tests/Mono.Android-Tests/Mono.Data.Sqlite/SqliteTests.cs
Expand Up @@ -126,7 +126,7 @@ public void BasicFunctionality ()
c.CommandText = "SELECT * FROM TESTTABLE";
using (var r = c.ExecuteReader ()) {
string typeName = r.GetDataTypeName (0);
Assert.IsFalse (typeName != "blob", $"Bug in DbDataReader.GetDataTypeName: should be 'blob', got: {typeName}");
Assert.IsTrue (String.Compare (typeName, "BLOB", StringComparison.OrdinalIgnoreCase) == 0, $"Bug in DbDataReader.GetDataTypeName: should be 'blob', got: {typeName}");
}
});
ItemsDb.Instance.WithCommand (c => {
Expand Down

0 comments on commit c52e6e6

Please sign in to comment.