[PVR] Recordings window: Respect setting SETTING_MYVIDEOS_SELECTACTIO… #10333

ksooo · 2016-08-23T21:39:08Z

Recordings window: Respect setting SETTING_MYVIDEOS_SELECTACTION also for recordings. Fixes inconsistent 'select item' behavior wrt 'normal' videos and recordings.

Reported here: http://forum.kodi.tv/showthread.php?tid=249318

@Jalle19: next one for review, if you like.

xbmc/pvr/windows/GUIWindowPVRRecordings.cpp

+                  bReturn = true;
+                  break;
+                case SELECT_ACTION_PLAY_OR_RESUME:
+                  PlayFile(m_vecItems->Get(iItem).get(), false, true);


…N also for recordings. Fixes inconsistent 'select item' behavior wrt 'normal' videos and recordings.

ksooo · 2016-08-24T12:30:38Z

@Jalle19 good to go now?

xbmc/pvr/windows/GUIWindowPVRRecordings.cpp

@@ -262,11 +262,34 @@ bool CGUIWindowPVRRecordings::OnMessage(CGUIMessage &message)
          {
            case ACTION_SELECT_ITEM:
            case ACTION_MOUSE_LEFT_CLICK:
+              switch(CSettings::GetInstance().GetInt(CSettings::SETTING_MYVIDEOS_SELECTACTION))


ksooo · 2016-08-25T07:22:53Z

jenkins build this please

MilhouseVH · 2016-08-26T01:27:00Z

According to a forum comment, "recording folders don't seem to work under liveTV", which I'm assuming is due to this change (as there's no other relevant change since the last working build).

ksooo · 2016-08-26T05:43:02Z

@MilhouseVH Thanks for the heads up. I will take look later today.

… introduced by xbmc#10333)

…ssion [PVR] Recordings window: Fix recording groups not working (regression introduced by #10333)

axbmcuser · 2016-08-28T15:32:15Z

With default select action set to "Show information", KODI now opens the Information Dialog of a recording (which is correct).

When i hit "play recording" within the info dialog, the dialog closes and opens up again, becuase Estuary does Dialog.close(PVRRecordingInfo,true) & Action(Select). I hope it hasn't been reported before. Thanks.

ksooo · 2016-08-28T16:12:30Z

Not related to this PR. Open a TRACK ticket if you find a new issue, please.

ksooo · 2016-08-28T16:14:48Z

On second thought this actually is related to this PR, although an Estuary problem. Thanks for reporting.

axbmcuser · 2016-08-28T16:29:48Z

I noticed it in comparison while building right before and after this PR got merged - combined with the intention of this PR it made sense to me that it's most likely related.

Side note: Replacing Action(Select) with Action(Play) in Estuary did not solve the issue in my quick tests. (Nothing happens with Action(Play))
But that was just a lucky guess - most likely it's the wrong approach and someone got another fix in mind.

ksooo · 2016-08-28T17:58:19Z

Using "Action(Play)" is the right approach; unfortunately currently this reveals another bug. I just tracked it down and will come up with a fix.

axbmcuser · 2016-08-29T18:26:05Z

@ksooo

This time i can't tell if truly related, but something quite bad regarding the recordings-folder i noticed recently is:

Reproduce 1 (almost works every time in my case):

Play LiveTV (in my case via tvheadend dvb-c)
While playback in background, open the discussed "recording" folder
Background playback of LiveTv freezes (Complete KODI GUI still active, just the LiveTV playback is stopped - sometimes Estuary showes the buffering indicator in this state, but playback never resumes)

Reproduce 2 (if example 1 does not reproduce):

Play LiveTV (in my case via tvheadend)
While playback in background, open "recording" folder
Open Information Dialog on any recording
Background playback of LiveTv freezes (Complete KODI GUI still active, just the LiveTV playback is stopped - sometimes Estuary showes the buffering indicator in this state, but playback never resumes)

Debug log:
http://pastebin.com/raw/Gyk59ALa

Tract is down (404), i'm happy to move the report there, once it's back.

Additional Info: Tested on LibreELEC nightly (debug log), additional testing with MillhouseLibreELEC 0828 + Windows win32 nightly 608220d all with same error/result). All setups fresh/clean

ksooo · 2016-08-29T19:07:45Z

This is definitely not related to this PR. please open a track ticket.

ksooo · 2016-08-29T20:22:22Z

@FernetMenta fyi, i quickly debugged this. When opening the recordings window, a thumbextractor gets created, but not by pvr code! You see the consequences... The playing Live TV channel gets stopped:

(lldb) thread backtrace
* thread #35: tid = 0xd6ea2, 0x0000000116f04524 pvr.hts.3.4.6.dylib`::CloseLiveStream() + 4 at client.cpp:322, name = 'JobWorker', stop reason = breakpoint 1.1
  * frame #0: 0x0000000116f04524 pvr.hts.3.4.6.dylib`::CloseLiveStream() + 4 at client.cpp:322
    frame #1: 0x0000000100d6b6ea Kodi`PVR::CPVRClient::CloseStream(this=0x0000000109ba0800) + 58 at PVRClient.cpp:1817
    frame #2: 0x00000001015de583 Kodi`PVR::CPVRClients::CloseStream(this=0x0000000106e3a710) + 99 at PVRClients.cpp:1345
    frame #3: 0x00000001016b0dca Kodi`PVR::CPVRManager::CloseStream(this=0x000000010705f000) + 474 at PVRManager.cpp:1204
    frame #4: 0x00000001017911de Kodi`CDVDInputStreamPVRManager::Close(this=0x0000000108c35bd0) + 110 at DVDInputStreamPVRManager.cpp:233
    frame #5: 0x000000010178f062 Kodi`CDVDInputStreamPVRManager::~CDVDInputStreamPVRManager(this=0x0000000108c35bd0) + 66 at DVDInputStreamPVRManager.cpp:63
    frame #6: 0x000000010178f185 Kodi`CDVDInputStreamPVRManager::~CDVDInputStreamPVRManager(this=0x0000000108c35bd0) + 21 at DVDInputStreamPVRManager.cpp:62
    frame #7: 0x000000010178f1e9 Kodi`CDVDInputStreamPVRManager::~CDVDInputStreamPVRManager(this=0x0000000108c35bd0) + 25 at DVDInputStreamPVRManager.cpp:62
    frame #8: 0x0000000100bec1fc Kodi`CDVDFileInfo::GetFileStreamDetails(pItem=0x000000011b5eb3d0) + 1868 at DVDFileInfo.cpp:351
    frame #9: 0x00000001018f6b4c Kodi`CThumbExtractor::DoWork(this=0x000000011b5eb390) + 5068 at VideoThumbLoader.cpp:140
    frame #10: 0x0000000100cae9df Kodi`CJobWorker::Process(this=0x000000011639cf10) + 111 at JobManager.cpp:69
    frame #11: 0x000000010094b080 Kodi`CThread::Action(this=0x000000011639cf10) + 896 at Thread.cpp:221
    frame #12: 0x0000000100949789 Kodi`CThread::staticThread(data=0x000000011639cf10) + 969 at Thread.cpp:131
    frame #13: 0x0000000106cc1805 libsystem_pthread.dylib`_pthread_body + 131
    frame #14: 0x0000000106cc1782 libsystem_pthread.dylib`_pthread_start + 168
    frame #15: 0x0000000106cbefa1 libsystem_pthread.dylib`thread_start + 13
(lldb)

ksooo · 2016-08-29T20:32:05Z

@FernetMenta Happens only if you select a recording folder. Then, for this folder on the right half of the recordings window a "folder listing" is displayed. I think the directory provider behind this listing tries to extract the thumbnails.

ksooo · 2016-08-29T20:42:59Z

@FernetMenta yep, the code defining the folder listing ui (around https://github.com/xbmc/xbmc/blob/master/addons/skin.estuary/1080i/MyPVRRecordings.xml#L252) is causing the trouble. I removed it for testing purposes and as expected Live TV no longer gets stopped when opening the recordings window.

Bad thing is that I don't have a good ida for a fix right now. Maybe we should not do the folder listing if pvr is playing live tv or a recording? What do you think?

axbmcuser · 2016-08-30T20:00:30Z

@ksooo
Another "recordings"-folder issue i noticed (not sure if you get notified by tract since it's assigned to "opdenkamp")
http://trac.kodi.tv/ticket/16866
Maybe - if you got the time - you want to take a look. :) Thanks, as always.

ksooo · 2016-08-30T20:08:52Z

@axbmcuser May I kindly ask you not to misuse random unrelated github PRs to contact me personally. Every github comment generates an email for every Team Kodi member. I check trac on a regular base, btw. Thanks.

axbmcuser · 2016-08-30T20:13:12Z

Understood.

ksooo added Type: Fix non-breaking change which fixes an issue Component: PVR v17 Krypton labels Aug 23, 2016

ksooo added this to the Krypton 17.0-beta2 milestone Aug 23, 2016

ksooo force-pushed the pvr-fix-recordings-defaultselectaction branch from d714d80 to 21b7fd2 Compare August 23, 2016 21:49

Jalle19 reviewed Aug 24, 2016
View reviewed changes

xbmc/pvr/windows/GUIWindowPVRRecordings.cpp

bReturn = true;

break;

case SELECT_ACTION_PLAY_OR_RESUME:

PlayFile(m_vecItems->Get(iItem).get(), false, true);

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

[PVR] Recordings window: Respect setting SETTING_MYVIDEOS_SELECTACTIO…

63198fd

…N also for recordings. Fixes inconsistent 'select item' behavior wrt 'normal' videos and recordings.

ksooo force-pushed the pvr-fix-recordings-defaultselectaction branch from 21b7fd2 to 63198fd Compare August 24, 2016 12:27

Jalle19 reviewed Aug 24, 2016
View reviewed changes

ksooo merged commit d283360 into xbmc:master Aug 25, 2016

ksooo deleted the pvr-fix-recordings-defaultselectaction branch August 25, 2016 08:03

ksooo added a commit to ksooo/xbmc that referenced this pull request Aug 26, 2016

[PVR] Recordings window: Fix recording groups not working (regression…

c4cc7ba

… introduced by xbmc#10333)

ksooo mentioned this pull request Aug 26, 2016

[PVR] Recordings window: Fix recording groups not working (regression introduced by #10333) #10342

Merged

ksooo added a commit that referenced this pull request Aug 28, 2016

Merge pull request #10342 from ksooo/pvr-fix-recordings-folders-regre…

4c18c6b

…ssion [PVR] Recordings window: Fix recording groups not working (regression introduced by #10333)

ksooo mentioned this pull request Aug 28, 2016

[Estuary][PVR] Recordings Info dialog: Fix 'Play recording' button. #10358

Merged

ksooo referenced this pull request in ksooo/xbmc Aug 30, 2016

[Listprovider] No thumbnail extraction for pvr recordings.

c2846a9

ksooo referenced this pull request in ksooo/xbmc Aug 30, 2016

[Listprovider] No thumbnail extraction for pvr recordings.

931700a

ksooo referenced this pull request in ksooo/xbmc Aug 30, 2016

[Listprovider] No thumbnail extraction for pvr recordings.

3f2019f

ksooo mentioned this pull request Aug 31, 2016

[PVR] Recordings: Prevent thumbnail extraction (as it cannot work pro… #10373

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PVR] Recordings window: Respect setting SETTING_MYVIDEOS_SELECTACTIO… #10333

[PVR] Recordings window: Respect setting SETTING_MYVIDEOS_SELECTACTIO… #10333

ksooo commented Aug 23, 2016

This comment was marked as spam.

This comment was marked as spam.

ksooo commented Aug 24, 2016

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

ksooo commented Aug 25, 2016

MilhouseVH commented Aug 26, 2016

ksooo commented Aug 26, 2016

axbmcuser commented Aug 28, 2016

ksooo commented Aug 28, 2016

ksooo commented Aug 28, 2016

axbmcuser commented Aug 28, 2016 •

edited

ksooo commented Aug 28, 2016

axbmcuser commented Aug 29, 2016 •

edited

ksooo commented Aug 29, 2016

ksooo commented Aug 29, 2016 •

edited

ksooo commented Aug 29, 2016

ksooo commented Aug 29, 2016 •

edited

axbmcuser commented Aug 30, 2016

ksooo commented Aug 30, 2016

axbmcuser commented Aug 30, 2016

[PVR] Recordings window: Respect setting SETTING_MYVIDEOS_SELECTACTIO… #10333

[PVR] Recordings window: Respect setting SETTING_MYVIDEOS_SELECTACTIO… #10333

Conversation

ksooo commented Aug 23, 2016

This comment was marked as spam.

This comment was marked as spam.

ksooo commented Aug 24, 2016

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

ksooo commented Aug 25, 2016

MilhouseVH commented Aug 26, 2016

ksooo commented Aug 26, 2016

axbmcuser commented Aug 28, 2016

ksooo commented Aug 28, 2016

ksooo commented Aug 28, 2016

axbmcuser commented Aug 28, 2016 • edited

ksooo commented Aug 28, 2016

axbmcuser commented Aug 29, 2016 • edited

ksooo commented Aug 29, 2016

ksooo commented Aug 29, 2016 • edited

ksooo commented Aug 29, 2016

ksooo commented Aug 29, 2016 • edited

axbmcuser commented Aug 30, 2016

ksooo commented Aug 30, 2016

axbmcuser commented Aug 30, 2016

axbmcuser commented Aug 28, 2016 •

edited

axbmcuser commented Aug 29, 2016 •

edited

ksooo commented Aug 29, 2016 •

edited

ksooo commented Aug 29, 2016 •

edited