[cmake] Move to root

[hudokkow]

Just to get the ball rolling.
cc/ @fetzerch, @wsnipex, @notspiff and anyone else interested in testing/debugging.

Build-tested under linux (core/addons).

buildsteps/depends stuff separated on purpose. Unified deps and jenkins scripts are voodoo to me.

[fetzerch]

this btw would also allow later also to get rid of the CORE_SOURCE_DIR variable (and we can use CMAKE_SOURCE_DIR) instead

[hudokkow]

Yeap, that's the plan. BTW, I need a bool in jenkins to test this. Something like "CMakeLists.txt is in root folder."

Crap, need to rebase again.

[Paxxi]

Can we get rid of the treedata with this? It feels wrong but maybe there's a good reason for it that I am missing

[fetzerch]

The treedata is sth different. That tells cmake which CMakeLists from which subfolders to include.
Alternative is to use add_subdirectories in the main CMakeLists.txt and all that contain folders.
I think @notspiff's main intention with that was to be able to conditionally include folders on a per platform level. I don't have a very strong opinion about it, the add_subdirectories approach is probably easier to understand for people that have used cmake in other projects.

[Paxxi]

That's my thinking, add_directory is easier to follow and translates better between projects. I know it's not really related but thought maybe we can sneak it in here

[notspiff]

Separation of code and data is the reason.

1. okt. 2016 19:36 skrev "Pär Björklund" notifications@github.com:

That's my thinking, add_directory is easier to follow and translates
better between projects. I know it's not really related but thought maybe
we can sneak it in here

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#10446 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AFktYPWIA-nXyGYQQUAz4kSBrwvR6Dspks5qxoMNgaJpZM4J5fjm
.

[afedchin]

+1 to get rid of treedata. I think add_directory for each first level subdirectory it'a a better way.
something like this afedchin@84aa2cb?diff=unified#diff-3de6f69aaaeae7bbc934887287370c56R69