Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cmake] Add support for Bluetooth #11137

Merged
merged 1 commit into from Dec 12, 2016
Merged

[cmake] Add support for Bluetooth #11137

merged 1 commit into from Dec 12, 2016

Conversation

hudokkow
Copy link
Member

@hudokkow hudokkow commented Dec 11, 2016 •
edited

Description

Build with bluetooth support if we find it.

Motivation and Context

Get CMake up to par with autotools. See gentoo/gentoo#3027 (comment)
Fixes http://trac.kodi.tv/ticket/17129

How Has This Been Tested?

Build tested under linux64

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)

ping @wsnipex

@hudokkow hudokkow added CMake Type: Fix non-breaking change which fixes an issue v18 Leia labels Dec 11, 2016
@hudokkow
Copy link
Member Author

Corrected after chat with @wsnipex.
jenkins build this please

@stefansaraev
Copy link
Contributor

are those extra eventlients that require bluetooth still in use ?

@hudokkow
Copy link
Member Author

That's a good question but I don't use any of them myself. Would love to know. ;)

@hudokkow hudokkow mentioned this pull request Dec 11, 2016
Merged
@hauihau hauihau mentioned this pull request Dec 11, 2016
Closed
@hudokkow
Copy link
Member Author

jenkins build and merge

@hudokkow
Copy link
Member Author

Build is fine: http://jenkins.kodi.tv/view/Helpers/job/BuildMulti-PR-Manually/244/

@hudokkow hudokkow added this to the L 18.0-alpha1 milestone Dec 12, 2016
@hudokkow hudokkow merged commit 997bd70 into xbmc:master Dec 12, 2016
@hudokkow hudokkow deleted the cmake_bluetooth branch December 12, 2016 10:46
@candrews
Copy link
Contributor

With this change, I'm still seeing this message from cmake:

  Manually-specified variables were not used by the project:
    ENABLE_BLUETOOTH

Is the variable named something different?

@hudokkow
Copy link
Member Author

Just did a clean build with ENABLE_BLUETOOTH=no and it's honored. Can't see those lines in my build log. Same without the variable (auto mode).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wsnipex wsnipex wsnipex approved these changes

Assignees
No one assigned
Labels
Backport: Done CMake Type: Fix non-breaking change which fixes an issue v18 Leia
Projects
None yet
Milestone
Leia 18.0-alpha1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hudokkow @stefansaraev @candrews @wsnipex