Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cmake] add imx support #11288

Merged
merged 2 commits into from Jan 2, 2017
Merged

[cmake] add imx support #11288

merged 2 commits into from Jan 2, 2017

Conversation

lrusak
Copy link
Contributor

@lrusak lrusak commented Dec 28, 2016

Description

Add imx support to cmake

This supercedes #10563

I'm not sure if we want to use IMX or IMXVPU

Backport is available here, lrusak@6d60b50

Motivation and Context

So kodi can be built for imx SOC's

How Has This Been Tested?

In LibreELEC

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the Code guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have added tests to cover my change
  • All new and existing tests passed

@lrusak
Copy link
Contributor Author

lrusak commented Dec 29, 2016

ping @mk01

ping cmake people @fetzerch @hudokkow

@mk01
Copy link
Contributor

mk01 commented Dec 29, 2016

@lrusak
looks to be working

fetzerch
fetzerch reviewed Dec 30, 2016
View reviewed changes
Copy link
Member

@fetzerch fetzerch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small issue, otherwise looks fine to me. thanks

cmake/modules/FindIMX.cmake
set(IMX_DEFINITIONS -DHAS_IMXVPU=1 -DLINUX -DEGL_API_FB)
endif()

mark_as_advanced(IMX_INCLUDE_DIR IMX_LIBRARIES IMX_DEFINITIONS)

This comment was marked as spam.

Sign in to view

@lrusak
Copy link
Contributor Author

lrusak commented Dec 30, 2016

thanks @fetzerch. updated.

fetzerch
fetzerch approved these changes Dec 31, 2016
View reviewed changes
Copy link
Member

@fetzerch fetzerch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks

jenkins build this please

@lrusak lrusak mentioned this pull request Dec 31, 2016
Merged
9 tasks
@fetzerch
Copy link
Member

fetzerch commented Jan 1, 2017

jenkins build this please

@fetzerch fetzerch merged commit 2c4c414 into xbmc:master Jan 2, 2017
@MartijnKaijser MartijnKaijser added this to the L 18.0-alpha1 milestone Jan 5, 2017
@lrusak lrusak deleted the imx branch February 11, 2022 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fetzerch fetzerch fetzerch approved these changes

Assignees
No one assigned
Labels
Backport: Done CMake v18 Leia
Projects
None yet
Milestone
Leia 18.0-alpha1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lrusak @mk01 @fetzerch @MartijnKaijser