New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CORE] settings refactor #6669
[CORE] settings refactor #6669
Conversation
@MartijnKaijser Saw this also, came from auto conversion in visual studio |
That "Media Management" section sticks out a bit due to being 2 words and everything else being 1. Isn't "Media" Enough? |
Media Management was the term that came up in the forum discussion. |
/me takes Popcorn and opens the bikeshedding pandora: Media Management might be confusing with actual Sources configuration. What about Media Settings - as those are "settings" after all? Edit: I have forgotten two words. |
Again 2 words ;) |
What about: Content? |
To be honest, I like "Media Management", although it is a two word term |
Nah, that´s not |
@mkortstiege There is a forum thread. See first post of this PR |
Sorry, puzzled it with another one. |
Part of the reason for the name Media Management was that as a next step a central "sources" management section for all media types could be added in here, which would probably fit well with Montellese's media import work. |
Yep its fine, was just commenting that the 1st screenshot looked slightly out of line. Maybe I'm just too obsessed with labels looking similar. I'll bikeshed in the forum thread in future ;) |
@zag2me it might look totally different in other languages. edit: |
it is less clicks on the remote to get to karaoke than to video settings. not ideal :( |
@FernetMenta BTW: Don't forget that settings level here is expert...karaoke should not be visible in standard |
putting video first makes my life easier :) BTW: that's the point, I always use expert level |
Yeah, guess video goes first... |
BTW: win32 testbuild online: https://www.dropbox.com/s/ofak23j4h13jalo/KodiSetup-20150309-3487f9f-settings_refactor.exe?dl=0 |
IMO reshuffling settings categories only makes sense when we rebuild the entire settings tree, so also regroup settings to new categories etc. I also think we might need a third level because it doesn't make much sense to have "Video library", "Video filelist", "Music library" and "Music filelist" in the media section. I would make more sense and also be cleaner if library and filelist would be grouped in a Video and Music node with the possibility to split up the settings into more subgroups. |
we're working in something so this is kinda obsolete |
Hey guys,
as mentioned and discussed in the forums ( http://forum.kodi.tv/showthread.php?tid=189031 ), I have refactored the settings to a new layout.
I left the old settings windows in the code for backwards compatibility, but still this needs some updates in other skin, as the old windows can be opened but are empty.
I hope this is fine.
ToDo:
Here we go with a little preview:
Win32 Testbuild can be found here: https://www.dropbox.com/s/ofak23j4h13jalo/KodiSetup-20150309-3487f9f-settings_refactor.exe?dl=0
Any opinions? There is a need for a final structure ;)
Shall the commits be squashed into one?
@Montellese Thanks for your help!
cheers,
mad-max