[cleanup] remove karaoke support #8285
Conversation
mkortstiege
added
the
Type: Cleanup
|
jenkins build this please. |
|
tested! :D |
|
please remove this as well: https://github.com/xbmc/xbmc/blob/master/addons/skin.confluence/language/resource.language.en_gb/strings.po#L421 rest of the confluence changes are ok. |
|
I think it can come back as an addon easily after @AchimTuran AESource interface has landed. |
|
this line can go as well https://github.com/xbmc/xbmc/blob/master/xbmc/guilib/GUIControlFactory.cpp#L103 |
|
Updated. will squash later. |
|
don't forget to revert en_us ;-) |
It's part of "some more .." |
mkortstiege
force-pushed
the
y_u_no_sing_with_me
branch
from
a40eead
to
a46acf6
Compare
|
Squashed. jenkins build this please. |
|
@FernetMenta how much will this hurt your rebase? |
|
@MartijnKaijser should be fine. Removals only will not result in any hard to resolve merge conflicts. |
[cleanup] remove karaoke support
| @@ -3934,11 +3896,15 @@ void CMusicDatabase::UpdateTables(int version) | |||
| m_pDS->exec("DROP TABLE album"); | |||
| m_pDS->exec("ALTER TABLE album_new RENAME TO album"); | |||
| } | |||
| if (version < 55) | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
great! lets get the xbox out again |
|
Keep the comments somewhere else |
|
@mkortstiege, sorry mate would appear to be close but no cigar. Jarvis Beta1 on windows build is showing this in the log 12:25:52 T:5504 INFO: Loading skin file: DialogMuteBug.xml, load type: LOAD_ON_GUI_INIT After removing the skin files as per Jarvis skin requirements, Kodi is still looking for the files. I suspect you did not get everything you should have. |
|
@wyrm65 are you 100% sure you're running beta 1? edit: check your DialogMuteBug.xml and DialogSeekBar.xml files. |
|
@ronie yep 100% sure on ,"am I running beta 1". Yes you were right on the DialogMuteBug.xml and DialogSeeBar.xml files (plus a couple of others). You might want to drop a hint for others in the skin update thread so they don't also look like a goose like me. PEBCAK error, Kodi beta 1 is fine. |
As requested by a lot of team members ..
Needs testing before merge!