[PVR] Addon API: Add PVR_PROPERTIES.iEpgMaxDays, PVR_RECORDING.channelType #9295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksooo
added
Type: Fix
|
@Jalle19 mind taking a look |
| @@ -237,6 +237,7 @@ extern "C" { | |||
| { | |||
| const char* strUserPath; /*!< @brief path to the user profile */ | |||
| const char* strClientPath; /*!< @brief path to this add-on */ | |||
| int iEpgMaxDays; /*!< @brief if > EPG_TIMEFRAME_UNLIMITED, in async epg mode, deliver only events in the range from 'end time > now' to 'start time < now + iEpgMaxDays. EPG_TIMEFRAME_UNLIMITED, notify all events. */ | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Need also a increase of The |
| @@ -195,9 +196,6 @@ ADDON_STATUS CPVRClient::Create(int iClientId) | |||
| catch (std::exception &e) { LogException(e, __FUNCTION__); } | |||
|
|
|||
| m_bReadyToUse = bReadyToUse; | |||
|
|
|||
| SetEPGTimeFrame(CSettings::GetInstance().GetInt(CSettings::SETTING_EPG_DAYSTODISPLAY)); | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
This pr will merged together with #9290 to avoid another api bump within a short timeframe. 9290 does the api bump. |
| CFileItemPtr GetSelectedChannelItem() const; | ||
| PVR::CPVRChannelPtr GetChannel(int iIndex); | ||
| PVR::CPVRChannelPtr GetSelectedChannel(); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
jenkins build this please |
ksooo
changed the title
ksooo
added a commit
that referenced
this pull request
Mar 8, 2016
[PVR] Addon API: Add PVR_PROPERTIES.iEpgMaxDays, PVR_RECORDING.channelType
This was referenced Mar 8, 2016
This was referenced Mar 8, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a PVR addon API change. It will get merged immediately after #9290 to keep number of api bumps for Krypton small.
Epg max days (number of days the user wants Kodi to hold epg event data) now will be transferred along with PVR_PROPERTIES to Addon_Create function. Thus, the pvr addon knows the correct value immediately when it gets created. Before, the value was transferred some time after the addon got created, making it impossible for the addon to initialize it's backend connection with the correct epg max days value without deferring connecting to the backend until epg max days values got set by Kodi, making a true asynchronous backend connection setup impossible.
Introduce PVR_RECORDING.channelType. This way, addons can flag recordings as TV or radio recordings making it possible to distinguish in kodi between these types, for instance to provide separate listings of tv and radio recordings, implement separate next recording widgets for radio and tv, .... It must be up to the addons/backend to supply this information as it is not always possible to obtain the type of a given channel at runtime, because the channel the recoding has been done may no longer be available at the time the channel type is needed. Kodi core implementation will be done in a followup PR.
Due to this API change, all PVR addons need to be recompiled, no other changes are required, unless async epg data transfer including addon-side filtering of transferred epg data according to epg max days value shall be implemented.
Second commit fixes crash due to a multithreading issue with CGUIEPGGridContainer that occured while testing the API change.