Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

t/sync.t currently fails #3

Closed
eserte opened this issue Nov 26, 2015 · 5 comments
Closed

t/sync.t currently fails #3

eserte opened this issue Nov 26, 2015 · 5 comments

Comments

@eserte
Copy link

eserte commented Nov 26, 2015

Can't fetch http://imgs.xkcd.com/comics/: Not Found at t/sync.t line 38.
# Looks like you planned 18 tests but ran 5.
# Looks like your test exited with 255 just after 5.
t/sync.t ................. 
Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 13/18 subtests 

Last success report on cpantesters was before about a week, since yesterday there are just fail reports:
http://fast-matrix.cpantesters.org/?dist=WWW-xkcd;reports=1#sl=7,1

@ambs
Copy link
Contributor

ambs commented May 2, 2016

2016 are all PASS, so I think this cn be safely closed.

@xsawyerx
Copy link
Owner

xsawyerx commented May 2, 2016

That's not the problem @eserte's test shows. His test shows that a request was made to a URL of a comic without the comic ID number. This means there was either a problem with the test or with the code which led to a bad request.

That needs to be researched and fixed.

@eserte
Copy link
Author

eserte commented Jan 20, 2018

Currently there seems to be a https vs. http issue. With WWW-xkcd-0.008:

#   Failed test 'Correct img'
#   at t/fetch_metadata_fail.t line 49.
#          got: 'https://xkcd.com/100/info.0.json'
#     expected: 'http://xkcd.com/100/info.0.json'
# Looks like you planned 8 tests but ran 6.
# Looks like you failed 1 test of 6 run.
t/fetch_metadata_fail.t .. 
Dubious, test returned 1 (wstat 256, 0x100)
Failed 3/8 subtests 

@xsawyerx
Copy link
Owner

I fixed that and tried to release a new version but I cannot seem to get any response with AnyEvent::HTTP. Might be a certain version that doesn't work. Haven't had the time to figure what the problem is. :/

xsawyerx added a commit that referenced this issue Jul 21, 2018
@xsawyerx
Copy link
Owner

Fixed and released in 0.009. Thank you, @eserte.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants