Add support for ACF Options pages #931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for ACF Options page values.
Mentioned here: #919
I'm struggling a little bit to find a coherent log format, maybe someone has input. Right now it's hard coded to
<Field name> of "settings page" option.. The crux is the only way to figure out what settings page this is on is by grabbingget_current_screen()or$_GET['page']. Neither of these provide the human-readable page name, but rather something liketoplevel_page_my_settings. Would that still be better than not setting it?I'd also like a more natural language:
Option <Field name> on <Settings page name>, but the current connector can not be easily adapted to this format. Any thoughts here?