Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for mercator domain mapping plugin #993

Merged
merged 3 commits into from Jan 15, 2019

Conversation

spacedmonkey
Copy link

Mercator is a popular domain mapping plugin rewritten by Human made. This plugin is used by a number of VIP GO / high scale projects. This drop-in, should be logged by stream as well.

@spacedmonkey
Copy link
Author

Any chance this gets merged / review
cc @lukecarbis @shadyvb

@shadyvb
Copy link
Contributor

shadyvb commented Dec 19, 2018

LGTM!

Also check https://github.com/xwp/stream/blob/develop/connectors/class-connector-edd.php#L350 for how Stream dealt with very similar actions like the ones here, essentially where action is the only difference in the log message.

@spacedmonkey
Copy link
Author

I looked at a custom connector, but as mercator WordPress drop-in, there were issues around order of loading. I am using a custom connector right now, so I am using in production right now. Just thought I would share the code with XWP. 👍

@lukecarbis lukecarbis merged commit 56d870e into xwp:develop Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants