Skip to content
This repository has been archived by the owner on Dec 27, 2022. It is now read-only.

Pass (snapshot object) to customize_snapshot_save filter. #77

Merged
merged 5 commits into from Aug 22, 2016

Conversation

lgedeon
Copy link
Contributor

@lgedeon lgedeon commented Aug 20, 2016

No description provided.

@coveralls
Copy link

coveralls commented Aug 20, 2016

Coverage Status

Coverage remained the same at 90.797% when pulling 8c5953a on feature/pass-snapshot into 856d135 on develop.

@westonruter
Copy link
Contributor

A unit test should be added for the save method to verify that the snapshot object is passed as the second filter param.

@westonruter
Copy link
Contributor

Such a test will help guard against the filter getting inadvertently removed or changed and thus breaking plugins that make use of it.

@coveralls
Copy link

coveralls commented Aug 21, 2016

Coverage Status

Coverage remained the same at 90.797% when pulling d22d95c on feature/pass-snapshot into 856d135 on develop.

@coveralls
Copy link

coveralls commented Aug 22, 2016

Coverage Status

Coverage remained the same at 90.797% when pulling 7110036 on feature/pass-snapshot into 856d135 on develop.

@coveralls
Copy link

coveralls commented Aug 22, 2016

Coverage Status

Coverage remained the same at 90.797% when pulling 17b82dd on feature/pass-snapshot into 856d135 on develop.

@westonruter westonruter merged commit 089cf81 into develop Aug 22, 2016
@westonruter westonruter deleted the feature/pass-snapshot branch August 22, 2016 03:43
@westonruter westonruter added this to the 0.5.1 milestone Aug 22, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants