Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tiff stream decoding performance #360

Merged
merged 1 commit into from Sep 4, 2021

Conversation

KazkiMatz
Copy link
Contributor

Hi, thank you for the great gem.

I've found on some PDFs with large embedded TIFF assets,tiff_depredict gets really slow because of the cost of MRI's array appending operation on the buffer unfiltered. The profiler also shows the MRI's GC cost are also dominant here.
This PR uses string instead of array for buffering. In my particular case, the processing duration improved 15x (from 30 secs to 2 secs).

Copy link
Owner

@yob yob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yob yob merged commit 8557768 into yob:main Sep 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants