@@ -31,7 +31,9 @@ module ActsAsQuickbooksModel # set qbxml attributes that exist in map and model model_qbxml_attributes = [] qbxml_model_map.keys.each do |key| - model_qbxml_attributes << key if self.respond_to?("#{key}=") + if self.respond_to?("#{key}=") && self.class.reflections[key.to_sym].nil? + model_qbxml_attributes << key + end end node = xml.respond_to?('innerHTML') ? xml : Hpricot.XML(xml).root lib/acts_as_quickbooks_model.rb @@ -2,8 +2,13 @@ require File.dirname(__FILE__) + '/test_helper' class Customer < ActiveRecord::Base acts_as_quickbooks_model + has_many :notes alias_attribute :is_active, :active end +class Note < ActiveRecord::Base + belongs_to :customer +end + class Payment < ActiveRecord::Base acts_as_quickbooks_model 'ReceivePayment' end @@ -43,6 +48,7 @@ CUSTOMER_RET = <<-XML <ParentRef> <ListID>456</ListID> </ParentRef> + <Notes>foo bar</Notes> </CustomerRet> XML @@ -195,4 +201,11 @@ context 'A model using acts_as_quickbooks_model' do other_charge_product.list_id.should.equal '345' other_charge_product.special_item_type.should.equal 'foo' end + + specify 'should not attempt to assign a has_many if an identical node appears as a QB element' do + # Example: Customer has_many notes + # CustomerRet sends back <Notes> node + customer = Customer.create!(:qbxml => CUSTOMER_RET) + customer.notes.should.be.empty + end end \ No newline at end of file test/model_test.rb @@ -8,6 +8,12 @@ ActiveRecord::Schema.define(:version => 1) do t.string :foo end + create_table :notes, :force => true do |t| + t.integer :id + t.integer :customer_id + t.string :note + end + create_table :invoices, :force => true do |t| t.integer :id t.string :txn_id test/schema.rb 6ec30a0bf39b4f68bf97f9ec49099b4ed33dd2a5 Zack Chandler zackchandler@depixelate.com http://github.com/zackchandler/acts_as_quickbooks_model/commit/9872b6d2a1db36fd9618cb09e695ff852a17647c 9872b6d2a1db36fd9618cb09e695ff852a17647c 2009-01-05T14:04:32-08:00 2009-01-05T14:04:32-08:00 don't inadvertently set has_many model if it's signature matches an element in returned QBXML 8375ba994fae0c1fb380d461b93ab6850b47bb4d Zack Chandler zackchandler@depixelate.com