db/migrate/048_default_stories_bucket_to_null.rb spec/migrations/048_default_stories_bucket_to_null_spec.rb @@ -1,7 +1,5 @@ -.gitignore .DS_Store config/database.yml -db/schema.rb log/* coverage/* nginx.conf .gitignore @@ -81,7 +81,7 @@ class Story < ActiveRecord::Base def self.find_backlog options = {} with_scope :find => options do - find :all, :conditions => { :bucket_id => nil } + find :all, :conditions => "bucket_id IS NULL" end end end app/models/story.rb @@ -9,7 +9,7 @@ # # It's strongly recommended to check this file into your version control system. -ActiveRecord::Schema.define(:version => 47) do +ActiveRecord::Schema.define(:version => 48) do create_table "activities", :force => true do |t| t.integer "actor_id" db/schema.rb @@ -135,4 +135,31 @@ describe Story, "complete" do story = Story.new :status => statuses(:blocked) story.should be_incomplete end +end + +describe Story, '.find_backlog' do +=begin def self.find_backlog options = {} + with_scope :find => options do + find :all, :conditions => "bucket_id IS NULL" + end + end +=end + + before do + bucket = Generate.bucket + @stories_without_a_bucket = Generate.stories :count => 2, :bucket => nil + @stories_with_a_bucket = Generate.stories :count => 2, :bucket => bucket + end + + it "finds all stories which don't belong to a bucket" do + Story.find_backlog.should == @stories_without_a_bucket + end + + it "uses the passed in find options to help refine the search while still only including stories without a bucket" do + @stories_without_a_bucket.first.update_attribute(:description, "BAZ") + Story.find_backlog( + :conditions => "description = 'BAZ'" + ).should == [@stories_without_a_bucket.first] + end + end \ No newline at end of file spec/models/story_spec.rb @@ -76,6 +76,14 @@ class Generate end end end + + def self.stories(attributes={}) + stories = [] + attributes.delete(:count).times do + stories << Generate.story(attributes) + end + stories + end def self.story(attributes={}) @story_count ||= 0 spec/spec_helpers/model_generation.rb d6f9c7e7971f8275fb92a5b53dd46f2348a59463 Zach Dennis zach.dennis@gmail.com http://github.com/zdennis/strac/commit/2124e79c59ce2793c24162a91d829e2e8a7b1bf8 2124e79c59ce2793c24162a91d829e2e8a7b1bf8 2008-03-28T18:59:06-07:00 2008-03-28T18:59:06-07:00 Added a migration which forces that a story's bucket_id default to nil/null to avoid issues where some mysql setups default integer fields to NULL and others to 0. 69b835812e8f67deb7cc74b6c33196c5940e3c56 Zach Dennis zach.dennis@gmail.com