Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parallel build of KLU #7

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from
Open

Conversation

thasti
Copy link

@thasti thasti commented Jul 13, 2020

Here's another minor one (I'm trying to get this packaged for Arch Linux).

When running make all with a multi-CPU option (-j8 in my case), the KLU patch fails to be applied as the patch and unpack targets are evaluated simultaneously - leading to a race condition of unpacking not having finished before patching is attempted. Putting unpack (though not a true file target) as a dependency of patch fixed that.

@thasti
Copy link
Author

thasti commented Jul 13, 2020

On closer inspection, it looks like the build system generally does not cope well with the -j option in various places (installation being one of them). In many places, the actual dependencies don't appear to be modeled, especially when archives are part of the build.
In case I were to look at this more systematically, would you be accepting a larger patch set (and should we move the associated discussion to a Github issue instead)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant