Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssl: Avoid explicitly setting verifypeer to 1 #13704

Closed
wants to merge 1 commit into from

Conversation

orgads
Copy link
Contributor

@orgads orgads commented May 19, 2024

It is the default, just like verifyhost.

@orgads
Copy link
Contributor Author

orgads commented May 19, 2024

I was wondering also about the lengthy documentation of the differences between 1 and 2 for CURLOPT_SSL_VERIFYHOST. It looks like the effective default is TRUE (I couldn't find 2 anywhere), and there is no difference for current versions between 1 and 2, so maybe the documentation should not state the difference in the main description? It can be stated later in a comment, that previous versions had a difference between 1 and 2 and describe this difference.

Same goes for CURLOPT_DOH_SSL_VERIFYHOST.

src/tool_operate.c Outdated Show resolved Hide resolved
@bagder
Copy link
Member

bagder commented May 19, 2024

I can agree to this change. But I would also like:

  1. the code removed, not commented. The entire else clause is unused then.
  2. the same logic applied to the proxy and doh equivalent options

@orgads
Copy link
Contributor Author

orgads commented May 20, 2024

I can agree to this change. But I would also like:

  1. the code removed, not commented. The entire else clause is unused then.
  2. the same logic applied to the proxy and doh equivalent options

Done

@orgads orgads force-pushed the ssl-verifypeer-default branch 3 times, most recently from f3cf2db to 28b024d Compare May 24, 2024 07:10
It is the default, just like verifyhost.
@bagder bagder closed this in 96a4cad May 25, 2024
@bagder
Copy link
Member

bagder commented May 25, 2024

Thanks!

@orgads orgads deleted the ssl-verifypeer-default branch May 26, 2024 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants