[slice] Don't create Slice if Workload doesn't have Topology Assignment.

[mbobrovskyi]

Fixes / Features

• Don't create Slice if Workload doesn't have Topology Assignment.

[mbobrovskyi]

@PBundyra @IrvingMg PTAL

[mbobrovskyi]

It can be possible that Workload have PodSetAssignments but doesn't have TopologyAssignment.

[PBundyra]

Can we move this logic outside of the loop?

[mbobrovskyi]

No, because psa.TopologyAssignment can be nil, and we can only check that inside the loop.

[mbobrovskyi]

Or you mean to check it before execute newSlice?

[mbobrovskyi]

Added method hasTopologyAssignment to check it before adding finalizer.

[PBundyra]

Can we add a UT for a case where TopologyAssignment arrives after some delay?

[mbobrovskyi]

We have this test:

xpk/slice/internal/controller/workload_controller_test.go

Lines 103 to 153 in 3975e28

	"parse TAS Assignment to populate NodeSelector in Slice": {
	request: baseRequest,
	workload: baseWorkloadWrapper.Clone().
	UID(types.UID(baseWorkloadName)).
	PodSetAssignments(utiltesting.MakePodSetAssignment("psa1").
	TopologyAssignment(nil, []kueue.TopologyDomainAssignment{
	{
	Values: []string{"domain1", "domain2"},
	Count: 2,
	},
	}).Obj(),
	utiltesting.MakePodSetAssignment("psa2").
	TopologyAssignment(nil, []kueue.TopologyDomainAssignment{
	{
	Values: []string{"domain2", "domain3"},
	Count: 2,
	},
	}).
	Obj(),
	).Obj(),
	wantWorkloads: []kueue.Workload{
	*baseWorkloadWrapper.Clone().
	UID(types.UID(baseWorkloadName)).
	PodSetAssignments(utiltesting.MakePodSetAssignment("psa1").
	TopologyAssignment(nil, []kueue.TopologyDomainAssignment{
	{
	Values: []string{"domain1", "domain2"},
	Count: 2,
	},
	}).Obj(),
	utiltesting.MakePodSetAssignment("psa2").
	TopologyAssignment(nil, []kueue.TopologyDomainAssignment{
	{
	Values: []string{"domain2", "domain3"},
	Count: 2,
	},
	}).
	Obj(),
	).
	Finalizers(CleanupSliceFinalizerName).
	Obj(),
	},
	wantSlices: []v1alpha1.Slice{
	*baseSliceWrapper.Clone().
	ControllerReference(kueue.GroupVersion.WithKind("Workload"), baseWorkloadName, baseWorkloadName).
	NodeSelector(map[string][]string{
	TPUReservationSubblockLabel: {"domain1", "domain2", "domain3"},
	}).
	Obj(),
	},
	},

[mbobrovskyi]

@PBundyra PTAL