Skip to content

ci: azure-ipam patch upgrade testing #3678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 30, 2025

Conversation

camrynl
Copy link
Contributor

@camrynl camrynl commented May 22, 2025

Reason for Change:
First pr for patch upgrade testing in CNI release pipeline. The CNI release patch upgrade tests will follow the same flow that we use for cilium patch upgrade tests.
Create cluster > deploy current images > e2e > deploy upgrade images > e2e > delete cluster

  • Adding TEST_AZURE_IPAM_VERSION/UPGRADE_AZURE_IPAM_VERSION and TEST_CNS_VERSION/UPGRADE_CNS_VERSION and new conditions to check these vars in the upgrade scenario.
    (CNS patch upgrade work still needs to be completed for non cilium)

  • Adding parameter upgradeScenario as a field to check off in pipeline run to determine if new patch needs to be deployed/tested

further documentation/instruction for use will be added when pipeline work is complete, but here is a quick guide for how values are expected to be set

  • upgradeScenario [T/F] - true will deploy patches and retest, false will run pipeline as usual
  • if upgradeScenario is true
    TEST_AZURE_IPAM_VERSION: set to current azure ipam patch
    UPGRADE_AZURE_IPAM_VERSION: set to upgrade azure ipam patch
    TEST_CNS_VERSION: set to current cns patch
    UPGRADE_CNS_VERSION: set to upgrade cns patch

if the TEST_* or UPGRADE_* values are not set it will use make to get the pipeline image build

Issue Fixed:

Requirements:

Notes:

@camrynl camrynl added the ci Infra or tooling. label May 22, 2025
@camrynl camrynl marked this pull request as ready for review May 29, 2025 17:54
@Copilot Copilot AI review requested due to automatic review settings May 29, 2025 17:54
@camrynl camrynl requested a review from a team as a code owner May 29, 2025 17:54
@camrynl camrynl requested a review from ibezrukavyi May 29, 2025 17:54
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces patch upgrade testing for Azure Container Networking by adding upgrade-specific pipeline parameters and stages to mirror the existing Cilium patch upgrade flow.

  • Added new parameters (upgradeScenario, upgradeAzureIpam) and conditions to support upgrade testing.
  • Updated multiple pipeline and load test templates to conditionally publish logs and deploy upgrade-specific jobs.
  • Extended the cilium overlay load test template with upgrade logic for IPAM and CNS versions.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
.pipelines/templates/log-template.yaml Added conditional artifact publishing based on logType.
.pipelines/cni/pipeline.yaml Introduced new upgradeScenario parameter and upgrade job stages.
.pipelines/cni/load-test-templates/restart-node-template.yaml Updated logType condition to support upgrade scenarios.
.pipelines/cni/load-test-templates/restart-cns-template.yaml Updated logType condition to support upgrade scenarios.
.pipelines/cni/load-test-templates/pod-deployment-template.yaml Added conditional logType assignment for pod deployment testing.
.pipelines/cni/cilium/cilium-overlay-load-test-template.yaml Extended upgrade logic with conditional deployment steps for IPAM/CNS.

vipul-21
vipul-21 previously approved these changes Jun 11, 2025
Copy link
Contributor

@QxBytes QxBytes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed some failures on the CNI Release test pipeline-- are those unrelated to these changes? Also is it possible to run I believe the lsg pipeline since I think it also uses the load-test-templates? Not sure if other pipelines should be run as well but trying to minimize us breaking pipelines that use these templates (fairly confident they shouldn't break but wouldn't hurt to just have it running in the background)

@camrynl camrynl enabled auto-merge June 30, 2025 19:06
@QxBytes
Copy link
Contributor

QxBytes commented Jun 30, 2025

/azp run Azure Container Networking PR

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@camrynl camrynl added this pull request to the merge queue Jun 30, 2025
Merged via the queue into master with commit 8a2dac9 Jun 30, 2025
15 of 16 checks passed
@camrynl camrynl deleted the camrynl/azureipam-patch-upgrade-test branch June 30, 2025 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Infra or tooling.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants