Skip to content

Bump fuel deps #7228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 20 commits into
base: master
Choose a base branch
from
Draft

Bump fuel deps #7228

wants to merge 20 commits into from

Conversation

Dentosal
Copy link
Member

@Dentosal Dentosal commented Jun 12, 2025

Description

Bumps fuel-vm, fuel-core fuels-rs and forc-wallet to latest versions. Upgrades Rust to 2021 edition.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
    • I believe this is non-breaking from user code perspective but I'm not too sure about that
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@Dentosal Dentosal self-assigned this Jun 12, 2025
Copy link

codspeed-hq bot commented Jun 12, 2025

CodSpeed Performance Report

Merging #7228 will not alter performance

Comparing dento/bump-fuel-deps (5a2eff1) with master (cd89f62)

Summary

✅ 24 untouched benchmarks

@Dentosal Dentosal marked this pull request as ready for review June 12, 2025 16:19
@Dentosal Dentosal requested review from a team as code owners June 12, 2025 16:19
@IGI-111 IGI-111 added the breaking May cause existing user code to break. Requires a minor or major release. label Jun 13, 2025
sender: Bech32Address::default(),
recipient: predicate_bech32_address.clone(),
sender: Address::default(),
recipient: predicate_address,
nonce: 0.into(),
amount: message_amount,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we shuold probably update this to also be u128; i think where possible we should update amount to u128 since that is the default balance type it seems

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Balances are u128. But the amount to transfer is u64. You cannot transfer more than u64::MAX.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting; i raised this because I repeatedly saw amount as u128 when tracing up the layers of abstraction:
https://github.com/FuelLabs/fuel-core/blob/85b2356d510a30cffaa8be7015203bb8ac30fee6/crates/client/src/client/types/balance.rs#L13

But it seems like the rust sdk will first need to account for this; i guess maybe a future release

@zees-dev zees-dev marked this pull request as draft June 18, 2025 00:31
@zees-dev
Copy link
Contributor

zees-dev commented Jun 18, 2025

All looks good!
Converting to draft however since this release contains breaking changes; it will be blocked until #7235 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking May cause existing user code to break. Requires a minor or major release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants