-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Bump fuel deps #7228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Bump fuel deps #7228
Conversation
CodSpeed Performance ReportMerging #7228 will not alter performanceComparing Summary
|
test/src/sdk-harness/test_projects/predicate_data_simple/mod.rs
Outdated
Show resolved
Hide resolved
test/src/sdk-harness/test_projects/ec_recover_and_match_predicate/mod.rs
Show resolved
Hide resolved
sender: Bech32Address::default(), | ||
recipient: predicate_bech32_address.clone(), | ||
sender: Address::default(), | ||
recipient: predicate_address, | ||
nonce: 0.into(), | ||
amount: message_amount, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we shuold probably update this to also be u128; i think where possible we should update amount to u128 since that is the default balance type it seems
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Balances are u128
. But the amount to transfer is u64
. You cannot transfer more than u64::MAX
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting; i raised this because I repeatedly saw amount
as u128
when tracing up the layers of abstraction:
https://github.com/FuelLabs/fuel-core/blob/85b2356d510a30cffaa8be7015203bb8ac30fee6/crates/client/src/client/types/balance.rs#L13
But it seems like the rust sdk will first need to account for this; i guess maybe a future release
All looks good! |
Description
Bumps fuel-vm, fuel-core fuels-rs and forc-wallet to latest versions. Upgrades Rust to 2021 edition.
Checklist
Breaking*
orNew Feature
labels where relevant.