-
Notifications
You must be signed in to change notification settings - Fork 5.4k
feat: add workspace support to forc docs #7229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…/JoE11-y/sway into feat/forc-doc-support-workspaces
@@ -27,6 +27,7 @@ sway-features.workspace = true | |||
sway-lsp.workspace = true | |||
sway-types.workspace = true | |||
swayfmt.workspace = true | |||
tokio = { workspace = true, features = ["macros", "rt-multi-thread"] } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems weird you'd need to include a full async runtime just to deal with some http errors, surely there are some synchronous facilities to do that even if the given library is written with an async client in mind.
Can you specifically explain the reasoning here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yeah the actual error is this:
There is no reactor running must be called from the context of a tokio-1-x-runtime
Usually occurs if any of the library deps is from github or the forc registry.
Description
Closes #4103
Preview
Checklist
Breaking*
orNew Feature
labels where relevant.