Skip to content
This repository was archived by the owner on Sep 20, 2023. It is now read-only.
This repository was archived by the owner on Sep 20, 2023. It is now read-only.

Mute and more buttons don't work when a thread is read #2657

@mesqueeb

Description

@mesqueeb

GitHawk Upload by mesqueeb

Activity

RJ-Clegg

RJ-Clegg commented on Feb 28, 2019

@RJ-Clegg

I'll take a look at this if no one has started on it yet

added
✨ good first issueAn issue suitable for someone looking to get familiar with the codebase
on Feb 28, 2019
mesqueeb

mesqueeb commented on Mar 11, 2019

@mesqueeb
Author

@RJ-Clegg How it going?

  • It's often I mark a thread as "read" by mistake, try to mark it "unread" again, but can't because of this bug.
  • Another case I often have is I mark a thread "read", then try to turn off notifications, but cannot do that because of this bug.

I feel a looooot of people would be really excited for your fix! 💘🎉

albertbass86

albertbass86 commented on Mar 28, 2019

@albertbass86

Hi, is there an update on this?

Sent with GitHawk

mesqueeb

mesqueeb commented on Mar 28, 2019

@mesqueeb
Author

I think not yet, it's still bugged in my version 😔very annoying but it's a free app so I won't complain? 😁

Sent with GitHawk

albertbass86

albertbass86 commented on Mar 28, 2019

@albertbass86

Well I ask because I would like to contribute to the project and seemed like this would be a good issue to work on. However it looks like @RJ-Clegg was working on it?

I don’t understand how issue assignment works here.

BasThomas

BasThomas commented on Mar 28, 2019

@BasThomas
Collaborator

It’s a bit tricky as you can’t assign tickets to outside contributors. Feel free to pick it up, @albertbass86, and let us know if we can help!

Sent with GitHawk

albertbass86

albertbass86 commented on Mar 28, 2019

@albertbass86

Cool! I was wondering if it was fine for me to just pick it. Will give it a try. Thank you 👌

Sent with GitHawk

albertbass86

albertbass86 commented on Mar 29, 2019

@albertbass86

Hi again, I have a simple solution but it feels a bit like a workaround.

It involves just adding a hitTest to the notification cell so touches are captured by the buttons instead of the cell. I feel like there is a different solution but I do not have enough context of the app to be sure.

Do you want me to create a PR and see @BasThomas or do you have pointers towards a different approach?

BasThomas

BasThomas commented on Mar 29, 2019

@BasThomas
Collaborator

Feel free to open a pull request, and we can continue from there.

I think it already uses a hit test rather than being able to tap the buttons in the cell?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    ✨ good first issueAn issue suitable for someone looking to get familiar with the codebase🐛 bugUnintended behaviour within the app

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Participants

      @albertbass86@mesqueeb@BasThomas@RJ-Clegg

      Issue actions

        Mute and more buttons don't work when a thread is read · Issue #2657 · GitHawkApp/GitHawk