-
-
Notifications
You must be signed in to change notification settings - Fork 663
(frontend): Incremental migration to svelte 5 #2755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@Keavon I've enabled runes mode for the whole project with the last commit, but still testing it. Let me know if you find anything that's breaking |
Thanks. Please keep testing it extensively and do any polishing you find 'til I get the chance to code review this. There are a few PRs in front of yours in the priority queue so it might be a couple of days, but I'll try my best to keep it from taking too long. |
I'm done with my bug fixes ✌️. Let me know if anything else is breaking as I'm not well aware of the UI hot paths and user workflow |
Migration Plan step by step
dynamicCompileOptions
forvite-plugin-svelte
, and add files in the runes whitelist (runesGlobs
)svelte/legacy
depracation warnings (AvoidingcreateBubbler
over here)runes
compatible, start chiping away the remainingsvelte/legacy
compat bindings.git-blame-ignore-revs
for a cleaner git blameFollowing the svelte 5 migration guide
Known Issues
patchWidgetLayout
doesn't update deeply nested properties reactively - 0d360bfGraph.svelte
(Node Graph) is invisible on load, displays after clicking on screen - 6f18e46NodeCatalog.svelte
reactive bindings messed up for sub-menus and node creation - f278827