Skip to content

(frontend): Incremental migration to svelte 5 #2755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

sm17p
Copy link

@sm17p sm17p commented Jun 25, 2025

Migration Plan step by step

  • Turn on dynamicCompileOptions for vite-plugin-svelte, and add files in the runes whitelist (runesGlobs)
  • Run the migration script for whitelisted files
  • Fix svelte/legacy depracation warnings (Avoiding createBubbler over here)
  • Once all the components are runes compatible, start chiping away the remainingsvelte/legacy compat bindings
  • Add commits to .git-blame-ignore-revs for a cleaner git blame

Following the svelte 5 migration guide


Known Issues

  • patchWidgetLayout doesn't update deeply nested properties reactively - 0d360bf
  • Graph.svelte (Node Graph) is invisible on load, displays after clicking on screen - 6f18e46
  • NodeCatalog.svelte reactive bindings messed up for sub-menus and node creation - f278827

@sm17p
Copy link
Author

sm17p commented Jun 26, 2025

@Keavon I've enabled runes mode for the whole project with the last commit, but still testing it. Let me know if you find anything that's breaking

@Keavon
Copy link
Member

Keavon commented Jun 26, 2025

Thanks. Please keep testing it extensively and do any polishing you find 'til I get the chance to code review this. There are a few PRs in front of yours in the priority queue so it might be a couple of days, but I'll try my best to keep it from taking too long.

@sm17p sm17p force-pushed the migrate-svelte-5 branch from 8536c50 to aa22517 Compare June 26, 2025 14:17
@sm17p sm17p force-pushed the migrate-svelte-5 branch from aa22517 to e80d066 Compare June 26, 2025 14:26
@sm17p
Copy link
Author

sm17p commented Jun 28, 2025

I'm done with my bug fixes ✌️. Let me know if anything else is breaking as I'm not well aware of the UI hot paths and user workflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants