Explicitly clear NODE environment variables to prevent affecting the spawned app

Author: JamesMessinger

lib/apply-defaults.js

@@ -6,10 +6,7 @@ module.exports = applyDefaults;
  * Applies default values (if any) to the arguments
  */
 function applyDefaults (defaults, originalArgs) {
-  if (!defaults || (!defaults.command && !defaults.args && !defaults.options)) {
-    // No defaults are set, so just return the args as-is
-    return originalArgs;
-  }
+  defaults = defaults || {};
 
   let command = defaults.command;
   let args = Array.prototype.slice.call(originalArgs);
@@ -71,6 +68,16 @@ function applyDefaults (defaults, originalArgs) {
     }
   }
 
+  // By default, use the current process's environment variables.
+  // except for NODE environment variables, which could impact how the child process runs.
+  options = options || {};
+  if (!options.env) {
+    options.env = Object.assign({}, process.env, {
+      NODE_ENV: "",
+      NODE_OPTIONS: "",
+    });
+  }
+
   if (typeof args === "string") {
     return [command + " " + args, options];
   }

test/specs/defaults.spec.js

@@ -144,7 +144,7 @@ describe("defaults", () => {
 
   describe("defaults.options", () => {
     it("should use the default options", () => {
-      chaiExec.defaults.options = { env: { ...process.env, foo: "Hello", bar: "world" }};
+      chaiExec.defaults.options = { env: { ...process.env, NODE_OPTIONS: "", foo: "Hello", bar: "world" }};
       let cli = chaiExec("test/fixtures/bin/echo-env foo bar");
 
       cli.command.should.equal("test/fixtures/bin/echo-env");
@@ -155,7 +155,7 @@ describe("defaults", () => {
 
     it("should use the default command and options", () => {
       chaiExec.defaults.command = "test/fixtures/bin/echo-env";
-      chaiExec.defaults.options = { env: { ...process.env, foo: "Hello", bar: "world" }};
+      chaiExec.defaults.options = { env: { ...process.env, NODE_OPTIONS: "", foo: "Hello", bar: "world" }};
       let cli = chaiExec("foo bar");
 
       cli.command.should.equal("test/fixtures/bin/echo-env");
@@ -166,7 +166,7 @@ describe("defaults", () => {
     it("should use the default command, args, and options", () => {
       chaiExec.defaults.command = "test/fixtures/bin/echo-env";
       chaiExec.defaults.args = "foo bar";
-      chaiExec.defaults.options = { env: { ...process.env, foo: "Hello", bar: "world" }};
+      chaiExec.defaults.options = { env: { ...process.env, NODE_OPTIONS: "", foo: "Hello", bar: "world" }};
       let cli = chaiExec();
 
       cli.command.should.equal("test/fixtures/bin/echo-env");
@@ -176,7 +176,7 @@ describe("defaults", () => {
 
     it("should append args to the default args, and options", () => {
       chaiExec.defaults.args = ["foo", "bar"];
-      chaiExec.defaults.options = { env: { ...process.env, foo: "Hello", bar: "world", biz: "AAA", baz: "BBB" }};
+      chaiExec.defaults.options = { env: { ...process.env, NODE_OPTIONS: "", foo: "Hello", bar: "world", biz: "AAA", baz: "BBB" }};
       let cli = chaiExec(["test/fixtures/bin/echo-env", "biz", "baz"]);
 
       cli.command.should.equal("test/fixtures/bin/echo-env");
@@ -187,7 +187,7 @@ describe("defaults", () => {
     it("should append args to the default command, args, and options", () => {
       chaiExec.defaults.command = "test/fixtures/bin/echo-env";
       chaiExec.defaults.args = "foo bar";
-      chaiExec.defaults.options = { env: { ...process.env, foo: "Hello", bar: "world", biz: "AAA", baz: "BBB" }};
+      chaiExec.defaults.options = { env: { ...process.env, NODE_OPTIONS: "", foo: "Hello", bar: "world", biz: "AAA", baz: "BBB" }};
       let cli = chaiExec("biz baz");
 
       cli.command.should.equal("test/fixtures/bin/echo-env");