-
Notifications
You must be signed in to change notification settings - Fork 4
make ChainRulesCore dependency into an extension #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #12 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 3 +1
Lines 61 61
=========================================
Hits 61 61
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@KristofferC I hadn't been aware of Pkg extensions until just now (but I'm very much in favor of the concept!). If I understand the docs correctly this will be backward-compatible down to at least Julia v1.6, right? Do extensions eliminate the drawbacks of Requires.jl (no precompilation and often big hit on load time of stacks of packages)? |
Should be backwards compatible to Julia 1.0.
Yes, that's the idea. These extensions get precompiled like a normal package. |
Oh, that is awesome! |
Do you know if that's deployed now? |
Yes, it should be! So we can try this out. |
Ok, let's try it! :-) |
Seems to work like a charm with Julia v1.9.0-beta3: julia> @time_imports import ChangesOfVariables
0.6 ms ChangesOfVariables
julia> @time_imports import ChainRulesCore
0.1 ms Compat
58.9 ms ChainRulesCore
0.4 ms ChangesOfVariables → ChainRulesCoreExt @devmotion, if you have no objections I'll tag a ChangesOfVariables release with this? |
Sure, I'm really excited about weak dependencies 🙂 |
Me too, I hope this will start a minor (maybe not so minor) revolution across the ecosystem. |
Shouldn't be merged until the Registrator deployment of JuliaRegistries/Registrator.jl#397 is done.