Add support for Base.BroadcastFunction #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #19 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 2 -1
Lines 61 60 -1
=========================================
- Hits 61 60 -1
☔ View full report in Codecov by Sentry. |
oschulz
force-pushed
the
broadcast_function
branch
2 times, most recently
from
fe0e303 to
07811b2
Compare
|
Fixed things on Julia v1.0. |
Tricky to implement a correct rrule here that handles tangents which contain NoTangent or ZeroTangent.
|
If you have no objections, I'd merge and release this, @devmotion . |
Makes docs more readable and use of Julia v1.0 is very rare.
oschulz
force-pushed
the
broadcast_function
branch
from
07811b2 to
079346d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we can do
See also JuliaMath/InverseFunctions.jl#31