Skip to content

Handle NoLogAbsDetJacobian in ComposedFunction #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 15, 2022
Merged

Conversation

oschulz
Copy link
Collaborator

@oschulz oschulz commented Jul 14, 2022

No description provided.

@oschulz oschulz requested a review from devmotion July 14, 2022 21:18
@codecov
Copy link

codecov bot commented Jul 14, 2022

Codecov Report

Merging #9 (ced80e0) into master (acd2a0c) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master        #9   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           55        61    +6     
=========================================
+ Hits            55        61    +6     
Impacted Files Coverage Δ
src/with_ladj.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acd2a0c...ced80e0. Read the comment docs.

@oschulz oschulz force-pushed the fix-composed-ladj branch from 5c234c6 to ced80e0 Compare July 15, 2022 15:25
Copy link
Member

@devmotion devmotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@oschulz oschulz merged commit 41ca2a3 into master Jul 15, 2022
@oschulz oschulz deleted the fix-composed-ladj branch July 15, 2022 21:50
@oschulz
Copy link
Collaborator Author

oschulz commented Jul 15, 2022

LGTM.

Thanks! I'll tag a bugfix release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants