[indexer-alt-framework] Improve test coverage for commit_watermark #22400
+872
−130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
tpham-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
tpham-mysten
force-pushed
the
indexer-alt-framework-commit-watermark-test
branch
from
137486b to
6971eb5
Compare
tpham-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
tpham-mysten
force-pushed
the
indexer-alt-framework-committer-test
branch
from
70db46e to
9d8f876
Compare
tpham-mysten
force-pushed
the
indexer-alt-framework-committer-test
branch
from
9d8f876 to
c3aed67
Compare
tpham-mysten
force-pushed
the
indexer-alt-framework-commit-watermark-test
branch
from
6971eb5 to
8bcc9a5
Compare
tpham-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
tpham-mysten
force-pushed
the
indexer-alt-framework-committer-test
branch
2 times, most recently
from
16b9e30 to
ff4a66e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve test coverage for concurrent/commit_watermark.rs
Test coverage includes:
Test plan
How did you test the new or updated feature?
Stack
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.