Skip to content

[indexer-alt-framework] Improve test coverage for reader_watermark #22407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: indexer-alt-framework-committer-test
Choose a base branch
from

Conversation

tpham-mysten
Copy link
Contributor

@tpham-mysten tpham-mysten commented Jun 16, 2025

Description

Improve test coverage for concurrent/reader_watermark.rs

Test coverage includes:

  • Basic watermark update
  • Watermark no update with smaller reader_lo
  • DB connection failure
  • DB set_reader_watermark falure

Test plan

How did you test the new or updated feature?

cargo test -p sui-indexer-alt-framework  reader_watermark  --lib

Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • gRPC:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:

Stack

@tpham-mysten tpham-mysten temporarily deployed to sui-typescript-aws-kms-test-env June 16, 2025 16:03 — with GitHub Actions Inactive
Copy link

vercel bot commented Jun 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 16, 2025 4:33pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Jun 16, 2025 4:33pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Jun 16, 2025 4:33pm

@tpham-mysten tpham-mysten requested review from amnn, emmazzz and wlmyng June 16, 2025 16:04
@tpham-mysten tpham-mysten force-pushed the indexer-alt-framework-committer-test branch from 70db46e to 9d8f876 Compare June 16, 2025 16:07
@tpham-mysten tpham-mysten force-pushed the indexer-alt-framework-committer-test branch from 9d8f876 to c3aed67 Compare June 16, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant