[move-compiler] A leaner version of pre-compiled libs #22422
+1,092
−474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
awelc
commented
Jun 17, 2025
| @@ -19,7 +19,7 @@ function version(path: string, args?: readonly string[]): string | null { | |||
| const versionString = childProcess.spawnSync( | |||
| path, args, { encoding: 'utf8' }, | |||
| ); | |||
| return versionString.stdout; | |||
| return versionString.stdout || null; | |||
There was a problem hiding this comment.
This is unrelated change fixing a problem discovered when debugging move-analyzer changes for this PR
| @@ -195,6 +195,14 @@ impl<'a> ParsingAnalysisContext<'a> { | |||
| assert!(self.current_mod_ident_str.is_none()); | |||
| self.current_mod_ident_str = Some(mod_ident_str.clone()); | |||
|
|
|||
| if mod_use_defs.get(&mod_ident_str).is_none() { | |||
There was a problem hiding this comment.
This did not need handling before as we were doing compilation with pre-compiled libraries right from the start. Now we do the first. Now we do first compilation without pre-compiled libraries as explained in the PR description.
awelc
force-pushed
the
aw/move-compiler-new-precompiled
branch
from
7f71e86 to
3bedb91
Compare
awelc
force-pushed
the
aw/move-compiler-new-precompiled
branch
from
3bedb91 to
305fa04
Compare
awelc
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
awelc
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
awelc
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
awelc
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces
FullyCompiledProgramused for testing and in to speed up compilation inmove-analyzerwith a much leaner per-moduleCompiledModuleInfostructure.The effect on
move-analyzer's memory consumption is quite dramatic - for a single package with default dependencies, memory footprint shrinks to ~350M vs. 1.4GB before this optimization was implemented.The changes to
move-analyzerare more involved than simply swappingFullyCompiledProgramwithCompiledModuleInfofor the following reason. Prior to this PR we could use pre-compiled dependencies during first compilation as it contained full parsing and typing ASTs that could be directly plugged into the analysis even though the pre-analyzed dependencies were not available during this first compilation. Now we no longer have full ASTs available so we do the first compilation without pre-compiled dependencies (so that full ASTs for both user program and dependencies can be produced), and use both pre-compiled dependencies (for faster compilation) and pre-analyzed dependencies (to avoid re-analyzing them) during subsequent compilations. This results in the first compilation to be slower but I'd say it's an acceptable trade-offTest plan
All CI tests must pass. Tested
move-analyzermodifications manually