Stackless bytecode #22428
Open
Stackless bytecode #22428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Playing with model-2
- A bit of refactoring - ```move stackless --old``` now prints the old stackless bytecode version - ```move stackless --disassemble``` now prints the disassembled source bytecode using move-model-2 (a lot of opcodes are still missing) - ```move stackless``` now prints the first attempt of stackless conversion (a lot of opcodes are still missing)
## Description See title ## Test plan New tests, and now `cargo insta test` and `cargo insta review` work for the stackless bytecode generator. --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] gRPC: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: --------- Co-authored-by: Cameron Swords <cgswords@CameronacStudio.hsd1.wa.comcast.net>
…stack-and-labels' into lorenzo/stackless-bytecode-2
Constant inlining optimization to the stackless bytecode translation process added. Deserializing constant Vectors from BCS.
CLI --optimized flag added
…to lorenzo/stackless-bytecode-2
Error[E03006]: unexpected name in this position ┌─ tests/move/vector/sources/Vector.move:30:9 │ │ vector::tabulate!(10, |i| i ) │ ^^^^^^ Could not resolve the name 'vector'
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
cgswords
reviewed
Jun 18, 2025
external-crates/move/crates/move-stackless-bytecode-2/src/disassembler.rs
Outdated
Show resolved
Hide resolved
cgswords
reviewed
Jun 18, 2025
Comment on lines
1
to
3
| // Copyright (c) The Diem Core Contributors | ||
| // Copyright (c) The Move Contributors | ||
| // SPDX-License-Identifier: Apache-2.0 |
There was a problem hiding this comment.
This file (and all new files) should have the following copyright header:
Suggested change
| // Copyright (c) The Diem Core Contributors | |
| // Copyright (c) The Move Contributors | |
| // SPDX-License-Identifier: Apache-2.0 | |
| // Copyright (c) The Move Contributors | |
| // SPDX-License-Identifier: Apache-2.0 |
There was a problem hiding this comment.
.Move files have this copyright:
// Copyright (c) Mysten Labs, Inc.
// SPDX-License-Identifier: Apache-2.0
Should I replace those as well?
cgswords
reviewed
Jun 18, 2025
external-crates/move/crates/move-stackless-bytecode-2/src/stackless/translate.rs
Outdated
Show resolved
Hide resolved
cgswords
reviewed
Jun 18, 2025
| @@ -29,17 +29,12 @@ members = [ | |||
|
|
|||
There was a problem hiding this comment.
It is concerning that we removed so much from the toml -- perhaps a rebase is in order?
cgswords
reviewed
Jun 18, 2025
| @@ -0,0 +1,79 @@ | |||
| // Copyright (c) The Move Contributors | |||
cgswords
reviewed
Jun 18, 2025
external-crates/move/crates/move-stackless-bytecode-2/src/tester.rs
Outdated
Show resolved
Hide resolved
cgswords
reviewed
Jun 18, 2025
external-crates/move/crates/move-stackless-bytecode-2/src/utils.rs
Outdated
Show resolved
Hide resolved
cgswords
reviewed
Jun 18, 2025
external-crates/move/crates/move-stackless-bytecode-2/tests/tests.rs
Outdated
Show resolved
Hide resolved
cgswords
reviewed
Jun 18, 2025
external-crates/move/crates/move-stackless-bytecode-2/src/stackless/translate.rs
Outdated
Show resolved
Hide resolved
cgswords
reviewed
Jun 18, 2025
external-crates/move/crates/move-stackless-bytecode-2/src/stackless/translate.rs
Outdated
Show resolved
Hide resolved
cgswords
reviewed
Jun 18, 2025
external-crates/move/crates/move-stackless-bytecode-2/src/stackless/translate.rs
Outdated
Show resolved
Hide resolved
cgswords
reviewed
Jun 18, 2025
Comment on lines
293
to
299
| let args = _struct_ref | ||
| .struct_ | ||
| .fields | ||
| .0 | ||
| .iter() | ||
| .map(|_| Var(ctxt.pop_register())) | ||
| .collect::<Vec<_>>(); |
There was a problem hiding this comment.
Consider a macro or helper function for this pattern, as it is repeated a number of places.
There was a problem hiding this comment.
Done, for this I added this:
macro_rules! make_vec {
($n:expr, $e:expr) => {{ (0..$n).map(|_| $e).collect::<Vec<_>>() }};
}
I also added push!()and pop!() macros
…to lorenzo/stackless-bytecode-2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First version of stackless bytecode implemented using model 2.
It also contains optimization for immediates inlining.