-
Notifications
You must be signed in to change notification settings - Fork 16
New landing page design #119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Preview the changes: https://turinglang.org/pr-previews/119 |
If anyone is interested, then please feel free to take on this PR! |
* very basic redesign * make buttons interactive
* add dangling code example * add code example section
* quickfix alignment * add news and clean up scss
* improve colors * better link hover color
* paste in svg * responsive svg header
using the same background colour for the team "cards" as for the non-hoverable cards on the landing page
- added links to discourse and slack to the buttons at the top of the page - moved link to libraries page to "Learn more" section
Co-authored-by: Penelope Yong <penelopeysm@gmail.com>
0046a57
to
e9e14d5
Compare
I will definitely have time to finish this in July. Which points would you like to see addressed before this PR can be merged? |
Revisiting this. Is there a reason why the old PR was closed? Also, I'd personally be happy to merge if some of the placeholder content is removed. Honestly, it's not like the existing front page has any resources, so even a fairly clean slate would be a huge improvement over the current one. |
I think the custom page layout (i.e., going all the way to the edges of the viewer) works out for laptop screens but I find my eyes jumping across large distances to capture all the information on a normal size desktop screen. I think I'm generally for having some padding on each side, as well as a maximum width for the content to prevent what I described on desktop screens. What were the advantages you saw for the wide layout over the more narrow one? |
Thanks a lot for pointing this out, I actually haven't thought of desktop screen!🥲 You are right, we should have a max width, let me update that too...! |
Actually using custom layout was allowing us to start logo animation header to begin from start of screen to end without any width! |
Oh, that's great! I was sure that there was a good reason for choosing the custom layout, it's just hard to sift through all the changes retrospectively. Thanks you for the explanation! |
We are thinking of removing the complex splash animation, do you have any suggestions for alternate branding option? And please, feel free to take over or push new commits in this PR! |
Were you thinking about something similar to a logo or a different animation? I don't have any experience creating either of these unfortunately. But if anyone else has those and an idea comes to my mind, I'll certainly share it with you. The new
There's currently nothing I'd want to add, but I'm happy to help if you're looking for something specific to be added. One very minor UX point (this might very well be personal taste!) would be that I get confused by elements with hover effects that turn out to be otherwise non-interactive. I'm aware that the hover animation we're using for interactive elements is "louder", but I somehow still perceive it as distracting for the non-interactive elements. Currently, these are the three cards "Expressive", "General-purpose", "Composable", and the cards below "Start Your Journey". But again, take this with a grain of salt – I absolutely get the visual appeal of hover effects and I'm fine keeping it as is, too. :) |
…rove overall responsiveness
… descriptions and few urls
No animation, just simple branding header, I used new logo now and its looking good!
Thank You!
I added some consistent styles for border and hover effect, lets keep it for now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really neat, good work @shravanngoswamii!
Only thing I would change is that in the News section, I'm not sure how the items that are displayed are picked, but currently it shows e.g. a post from 2019 announcing our blog. Maybe it could instead just show the three newest ones?
We just have to put |
Continuing #105
Preview the changes: https://turinglang.org/pr-previews/119