-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Description
Describe the bug
In DungeonEscape, push settings has attribute agentRotationSpeed available,
However in PushAgentEscape.cs, it uses hardcoded value 200f instead.
ml-agents/Project/Assets/ML-Agents/Examples/DungeonEscape/Scripts/PushAgentEscape.cs
Line 66 in 5b6cb98
transform.Rotate(rotateDir, Time.fixedDeltaTime * 200f); |
I feel agentRotationSpeed should default to 200f, instead of 15, and the 200f
should be replaced by m_PushBlockSettings.agentRotationSpeed
?
To Reproduce
Go to github link
ml-agents/Project/Assets/ML-Agents/Examples/DungeonEscape/Scripts/PushAgentEscape.cs
Line 66 in 5b6cb98
transform.Rotate(rotateDir, Time.fixedDeltaTime * 200f); |
Console logs / stack traces
N/A
Screenshots
ml-agents/Project/Assets/ML-Agents/Examples/DungeonEscape/Scripts/PushAgentEscape.cs
Line 66 in 5b6cb98
transform.Rotate(rotateDir, Time.fixedDeltaTime * 200f); |
Environment (please complete the following information):
develop
branch, and at least as far back as release_20
Activity
Change hard-coded 200f to m_PushBlockSettings.agentRotationSpeed; add…
stale commentedon Jun 18, 2023
This issue has been automatically marked as stale because it has not had activity in the last 90 days. It will be closed in the next 30 days if no further activity occurs. Thank you for your contributions.
hughperkins commentedon Oct 8, 2023
this isnt completed. the value is still set to 200f, see
ml-agents/Project/Assets/ML-Agents/Examples/DungeonEscape/Scripts/PushAgentEscape.cs
Line 66 in 6203c7e