Skip to content

DungeonEscape: rotate multplier 200f should be m_PushBlockSettings.agentRotationSpeed I feel? #5850

@hughperkins

Description

@hughperkins

Describe the bug

In DungeonEscape, push settings has attribute agentRotationSpeed available,

However in PushAgentEscape.cs, it uses hardcoded value 200f instead.

transform.Rotate(rotateDir, Time.fixedDeltaTime * 200f);

I feel agentRotationSpeed should default to 200f, instead of 15, and the 200f should be replaced by m_PushBlockSettings.agentRotationSpeed?

To Reproduce
Go to github link

transform.Rotate(rotateDir, Time.fixedDeltaTime * 200f);
. See the hardcoded constant.

Console logs / stack traces
N/A

Screenshots

transform.Rotate(rotateDir, Time.fixedDeltaTime * 200f);

Environment (please complete the following information):
develop branch, and at least as far back as release_20

Activity

added
bugIssue describes a potential bug in ml-agents.
on Dec 22, 2022
stale

stale commented on Jun 18, 2023

@stale

This issue has been automatically marked as stale because it has not had activity in the last 90 days. It will be closed in the next 30 days if no further activity occurs. Thank you for your contributions.

added
staleIssues that have been idle for a while. Automatically closed by a bot if idle for too long.
on Jun 18, 2023
hughperkins

hughperkins commented on Oct 8, 2023

@hughperkins
Author

this isnt completed. the value is still set to 200f, see

transform.Rotate(rotateDir, Time.fixedDeltaTime * 200f);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugIssue describes a potential bug in ml-agents.staleIssues that have been idle for a while. Automatically closed by a bot if idle for too long.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Participants

      @hughperkins@miguelalonsojr

      Issue actions

        DungeonEscape: rotate multplier `200f` should be `m_PushBlockSettings.agentRotationSpeed` I feel? · Issue #5850 · Unity-Technologies/ml-agents