Skip to content

Documentation for 'import/no-extraneous-dependencies' is missing #2727

Open
@cseas

Description

@cseas

The rule is set to error in the config:
https://github.com/airbnb/javascript/blob/master/packages/eslint-config-airbnb-base/rules/imports.js#L71

But there's no mention of it in the guide:
https://github.com/airbnb/javascript/blob/master/README.md

This rule should be mentioned under the Modules section.

Activity

ljharb

ljharb commented on Feb 14, 2023

@ljharb
Collaborator

Sure, that's fine. It's been a best practice in node for over a decade so I guess it just went without saying :-)

MohitBansal321

MohitBansal321 commented on Feb 22, 2023

@MohitBansal321

Sure, that's fine. It's been a best practice in node for over a decade so I guess it just went without saying :-)

I didn't find link related to this rule on eslint

ljharb

ljharb commented on Feb 22, 2023

@ljharb
Collaborator

It's part of eslint-plugin-import.

MohitBansal321

MohitBansal321 commented on Feb 23, 2023

@MohitBansal321

It's part of eslint-plugin-import.

Link (this one?)
on which part of the modules should be added?

ljharb

ljharb commented on Feb 23, 2023

@ljharb
Collaborator

Yep, that's the rule.

I guess as a new section at the end of Modules?

meddy672

meddy672 commented on Mar 23, 2023

@meddy672

I have a PR up. Please take a look.

Vivek-04022001

Vivek-04022001 commented on Mar 24, 2023

@Vivek-04022001
ljharb

ljharb commented on Mar 24, 2023

@ljharb
utkarsh-shrivastav77

utkarsh-shrivastav77 commented on May 15, 2023

@utkarsh-shrivastav77
ljharb

ljharb commented on May 15, 2023

@ljharb
cyberwarrior-20

cyberwarrior-20 commented on Jul 30, 2023

@cyberwarrior-20

hi @cseas i can solve this issue please assign me

angeloreale

angeloreale commented on Apr 18, 2024

@angeloreale

My .50 cents? Why is it something should be made a code style pattern if it can directly affect bundle sizes for ES modules?

1 remaining item

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @ljharb@meddy672@angeloreale@cseas@MohitBansal321

      Issue actions

        Documentation for 'import/no-extraneous-dependencies' is missing · Issue #2727 · airbnb/javascript