Skip to content

lines-around-directive rule should replaced with padding-line-between-statements #2689

Open
@mvorisek

Description

@mvorisek

see eslint/eslint#16629 (comment) from the eslint maintainer

Activity

HemanthPaila

HemanthPaila commented on Mar 31, 2023

@HemanthPaila

Hi there,

I want to contribute to this project and take on this issue as my first task. Could you please assign it to me? I am excited to work towards resolving it and will keep the team updated on my progress.

Thanks!

ljharb

ljharb commented on Mar 31, 2023

@ljharb
Collaborator

@HemanthPaila theres no need to request assignment; most open source projects don’t operate that way. Just make a PR and link it to the issue.

HemanthPaila

HemanthPaila commented on Apr 2, 2023

@HemanthPaila

Thanks @ljharb . I am on it.

HemanthPaila

HemanthPaila commented on Apr 2, 2023

@HemanthPaila

I made a PR on this issue. could you please review and merge it?

linked a pull request that will close this issue on Apr 2, 2023
HemanthPaila

HemanthPaila commented on Apr 2, 2023

@HemanthPaila

Hello sir i made another PR could you please review it once?

ljharb

ljharb commented on Apr 2, 2023

@ljharb
Collaborator

@HemanthPaila please don't make duplicate PRs - now both #2756 and #2757 must remain open and be kept in sync. I've reviewed it, and in the future you don't need to ask for review, you can just wait more than a few minutes :-)

HemanthPaila

HemanthPaila commented on Apr 2, 2023

@HemanthPaila

Sir could you please clarify my doubt:
- What I want to add to the issue for a successful merge.
- I regret removing the entry, but I will correct the issue by returning it to the appropriate place.

speedywarp

speedywarp commented on Aug 3, 2024

@speedywarp

is the issue resolved?

ljharb

ljharb commented on Aug 6, 2024

@ljharb
Collaborator

No, the linked PR, #2757, has unresolved comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @ljharb@mvorisek@HemanthPaila@speedywarp

      Issue actions

        `lines-around-directive` rule should replaced with `padding-line-between-statements` · Issue #2689 · airbnb/javascript